Skip to content
  1. Sep 14, 2013
    • Björn Jacke's avatar
    • Sachin Prabhu's avatar
      cifs: Avoid calling unlock_page() twice in cifs_readpage() when using fscache · 466bd31b
      Sachin Prabhu authored
      When reading a single page with cifs_readpage(), we make a call to
      fscache_read_or_alloc_page() which once done, asynchronously calls
      the completion function cifs_readpage_from_fscache_complete(). This
      completion function unlocks the page once it has been populated from
      cache. The module then attempts to unlock the page a second time in
      cifs_readpage() which leads to warning messages.
      
      In case of a successful call to fscache_read_or_alloc_page() we should skip
      the second unlock_page() since this will be called by the
      cifs_readpage_from_fscache_complete() once the page has been populated by
      fscache.
      
      With the modifications to cifs_readpage_worker(), we will need to re-grab the
      page lock in cifs_write_begin().
      
      The problem was first noticed when testing new fscache patches for cifs.
      https://bugzilla.redhat.com/show_bug.cgi?id=1005737
      
      
      
      Signed-off-by: default avatarSachin Prabhu <sprabhu@redhat.com>
      Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
      Signed-off-by: default avatarSteve French <smfrench@gmail.com>
      466bd31b
    • Sachin Prabhu's avatar
      cifs: Do not take a reference to the page in cifs_readpage_worker() · a9e9b7bc
      Sachin Prabhu authored
      
      
      We do not need to take a reference to the pagecache in
      cifs_readpage_worker() since the calling function will have already
      taken one before passing the pointer to the page as an argument to the
      function.
      
      Signed-off-by: default avatarSachin Prabhu <sprabhu@redhat.com>
      Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
      Signed-off-by: default avatarSteve French <smfrench@gmail.com>
      a9e9b7bc
    • Linus Torvalds's avatar
      Merge tag 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging · bdbdfdef
      Linus Torvalds authored
      Pull hwmon fixes from Guenter Roeck:
       "Some more low risk cleanup patches:
      
         - Remove unnecessary pci_set_drvdata in k10temp driver from Jingoo Han
         - Fix return values in several drivers from Sachin Kamat
         - Remove redundant break in amc6821 driver from Sachin Kamat"
      
      * tag 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging:
        hwmon: (k10temp) remove unnecessary pci_set_drvdata()
        hwmon: (tmp421) Fix return value
        hwmon: (amc6821) Remove redundant break
        hwmon: (amc6821) Fix return value
        hwmon: (ibmaem) Fix return value
        hwmon: (emc2103) Fix return value
      bdbdfdef
    • Linus Torvalds's avatar
      Merge tag 'xtensa-next-20130912' of git://github.com/czankel/xtensa-linux · 67002151
      Linus Torvalds authored
      Pull Xtensa updates from Chris Zankel.
      
      * tag 'xtensa-next-20130912' of git://github.com/czankel/xtensa-linux:
        xtensa: Fix broken allmodconfig build
        xtensa: remove CCOUNT_PER_JIFFY
        xtensa: fix !CONFIG_XTENSA_CALIBRATE_CCOUNT build failure
        xtensa: don't use echo -e needlessly
        xtensa: new fast_alloca handler
        xtensa: keep a3 and excsave1 on entry to exception handlers
        xtensa: enable kernel preemption
        xtensa: check thread flags atomically on return from user exception
      67002151
    • Linus Torvalds's avatar
      Merge git://git.kvack.org/~bcrl/aio-next · 9bf12df3
      Linus Torvalds authored
      Pull aio changes from Ben LaHaise:
       "First off, sorry for this pull request being late in the merge window.
        Al had raised a couple of concerns about 2 items in the series below.
        I addressed the first issue (the race introduced by Gu's use of
        mm_populate()), but he has not provided any further details on how he
        wants to rework the anon_inode.c changes (which were sent out months
        ago but have yet to be commented on).
      
        The bulk of the changes have been sitting in the -next tree for a few
        months, with all the issues raised being addressed"
      
      * git://git.kvack.org/~bcrl/aio-next: (22 commits)
        aio: rcu_read_lock protection for new rcu_dereference calls
        aio: fix race in ring buffer page lookup introduced by page migration support
        aio: fix rcu sparse warnings introduced by ioctx table lookup patch
        aio: remove unnecessary debugging from aio_free_ring()
        aio: table lookup: verify ctx pointer
        staging/lustre: kiocb->ki_left is removed
        aio: fix error handling and rcu usage in "convert the ioctx list to table lookup v3"
        aio: be defensive to ensure request batching is non-zero instead of BUG_ON()
        aio: convert the ioctx list to table lookup v3
        aio: double aio_max_nr in calculations
        aio: Kill ki_dtor
        aio: Kill ki_users
        aio: Kill unneeded kiocb members
        aio: Kill aio_rw_vect_retry()
        aio: Don't use ctx->tail unnecessarily
        aio: io_cancel() no longer returns the io_event
        aio: percpu ioctx refcount
        aio: percpu reqs_available
        aio: reqs_active -> reqs_available
        aio: fix build when migration is disabled
        ...
      9bf12df3
  2. Sep 13, 2013