Skip to content
  1. Nov 18, 2023
  2. Nov 17, 2023
    • Daniele Ceraolo Spurio's avatar
      drm/i915/huc: Stop printing about unsupported HuC on MTL · d3715a64
      Daniele Ceraolo Spurio authored
      
      
      On MTL, the HuC is only supported on the media GT, so our validation
      check on the module parameter detects an inconsistency on the root GT
      (the modparams asks to enable HuC, but the support is not there) and
      prints the following info message:
      
      [drm] GT0: Incompatible option enable_guc=3 - HuC is not supported!
      
      This can be confusing to the user and make them think that something is
      wrong when it isn't, so we need to silence it.
      Given that any platform that supports HuC also supports GuC, if a user
      tries to enable HuC on a platform that really doesn't support it they'll
      already see a message about GuC not being supported, so instead of just
      silencing the HuC message on newer platforms we can just get rid of it
      entirely.
      
      Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
      Cc: John Harrison <john.c.harrison@intel.com>
      Reviewed-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20231109235436.2349963-1-daniele.ceraolospurio@intel.com
      d3715a64
  3. Nov 16, 2023
  4. Nov 10, 2023
  5. Nov 09, 2023
    • Sam James's avatar
      drm: i915: Adapt to -Walloc-size · bae9fca9
      Sam James authored
      
      
      GCC 14 introduces a new -Walloc-size included in -Wextra which errors out
      like:
      ```
      drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c: In function ‘eb_copy_relocations’:
      drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1681:24: error: allocation of insufficient size ‘1’ for type ‘struct drm_i915_gem_relocation_entry’ with size ‘32’ [-Werror=alloc-size]
       1681 |                 relocs = kvmalloc_array(size, 1, GFP_KERNEL);
            |                        ^
      
      ```
      
      So, just swap the number of members and size arguments to match the prototype, as
      we're initialising 1 element of size `size`. GCC then sees we're not
      doing anything wrong.
      
      Signed-off-by: default avatarSam James <sam@gentoo.org>
      Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
      Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20231107215538.1891359-1-sam@gentoo.org
      bae9fca9
  6. Nov 08, 2023
  7. Nov 07, 2023
  8. Nov 06, 2023
  9. Nov 03, 2023
  10. Nov 02, 2023
  11. Oct 31, 2023
  12. Oct 30, 2023
  13. Oct 29, 2023
  14. Oct 27, 2023
  15. Oct 26, 2023
    • Nirmoy Das's avatar
      drm/i915/gt: Use proper priority enum instead of 0 · ffc02c67
      Nirmoy Das authored
      
      
      I915_PRIORITY_NORMAL is 0 so use that instead for better
      readability.
      
      Cc: John Harrison <John.C.Harrison@Intel.com>
      Signed-off-by: default avatarNirmoy Das <nirmoy.das@intel.com>
      Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20231023121305.12560-1-nirmoy.das@intel.com
      ffc02c67
    • Arnd Bergmann's avatar
      drm/i915/mtl: avoid stringop-overflow warning · 0520b30b
      Arnd Bergmann authored
      The newly added memset() causes a warning for some reason I could not
      figure out:
      
      In file included from arch/x86/include/asm/string.h:3,
                       from drivers/gpu/drm/i915/gt/intel_rc6.c:6:
      In function 'rc6_res_reg_init',
          inlined from 'intel_rc6_init' at drivers/gpu/drm/i915/gt/intel_rc6.c:610:2:
      arch/x86/include/asm/string_32.h:195:29: error: '__builtin_memset' writing 16 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=]
        195 | #define memset(s, c, count) __builtin_memset(s, c, count)
            |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      drivers/gpu/drm/i915/gt/intel_rc6.c:584:9: note: in expansion of macro 'memset'
        584 |         memset(rc6->res_reg, INVALID_MMIO_REG.reg, sizeof(rc6->res_reg));
            |         ^~~~~~
      In function 'intel_rc6_init':
      
      Change it to an normal initializer and an added memcpy() that does not have
      this problem.
      
      Fixes: 4bb9ca7e
      
       ("drm/i915/mtl: C6 residency and C state type for MTL SAMedia")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
      Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20231016201012.1022812-1-arnd@kernel.org
      0520b30b
  16. Oct 25, 2023
    • Umesh Nerlige Ramappa's avatar
      drm/i915/pmu: Check if pmu is closed before stopping event · 31f6a06f
      Umesh Nerlige Ramappa authored
      When the driver unbinds, pmu is unregistered and i915->uabi_engines is
      set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine
      events, it issues a warn_on because engine lookup fails.
      
      All perf hooks are taking care of this using a pmu->closed flag that is
      set when PMU unregisters. The stop event seems to have been left out.
      
      Check for pmu->closed in pmu_event_stop as well.
      
      Based on discussion here -
      https://patchwork.freedesktop.org/patch/492079/?series=105790&rev=2
      
      v2: s/is/if/ in commit title
      v3: Add fixes tag and cc stable
      
      Cc: <stable@vger.kernel.org> # v5.11+
      Fixes: b00bccb3
      
       ("drm/i915/pmu: Handle PCI unbind")
      Signed-off-by: default avatarUmesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
      Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
      Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
      Signed-off-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20231020152441.3764850-1-umesh.nerlige.ramappa@intel.com
      31f6a06f
    • Matt Roper's avatar
      drm/i915/mcr: Hold GT forcewake during steering operations · 8fa1c7cd
      Matt Roper authored
      The steering control and semaphore registers are inside an "always on"
      power domain with respect to RC6.  However there are some issues if
      higher-level platform sleep states are entering/exiting at the same time
      these registers are accessed.  Grabbing GT forcewake and holding it over
      the entire lock/steer/unlock cycle ensures that those sleep states have
      been fully exited before we access these registers.
      
      This is expected to become a formally documented/numbered workaround
      soon.
      
      Note that this patch alone isn't expected to have an immediately
      noticeable impact on MCR (mis)behavior; an upcoming pcode firmware
      update will also be necessary to provide the other half of this
      workaround.
      
      v2:
       - Move the forcewake inside the Xe_LPG-specific IP version check.  This
         should only be necessary on platforms that have a steering semaphore.
      
      Fixes: 3100240b
      
       ("drm/i915/mtl: Add hardware-level lock for steering")
      Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
      Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
      Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
      Reviewed-by: default avatarRadhakrishna Sripada <radhakrishna.sripada@intel.com>
      Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
      Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20231019170241.2102037-2-matthew.d.roper@intel.com
      8fa1c7cd
  17. Oct 24, 2023
  18. Oct 23, 2023
    • Dave Airlie's avatar
      Merge tag 'drm-msm-next-2023-10-17' of https://gitlab.freedesktop.org/drm/msm into drm-next · 3f5ba636
      Dave Airlie authored
      
      
      Updates for v6.7
      
      DP:
      - use existing helpers for DPCD handling instead of open-coded functions
      - set the subconnector type according to the plugged cable / dongle
        skip validity check for DP CTS EDID checksum
      
      DPU:
      - continued migration of feature flags to use core revision checks
      - reworked interrupts code to use '0' as NO_IRQ, removed raw IRQ indices
        from log / trace output
      
      gpu:
      - a7xx support (a730, a740)
      - fixes and additional speedbins for a635, a643
      
      core:
      - decouple msm_drv from kms to more cleanly support headless devices (like
        imx5+a2xx)
      
      From: Rob Clark <robdclark@gmail.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/CAF6AEGvzkBL2_OgyOeP_b6rVEjrNdfm8jcKzaB04HqHyT5jYwA@mail.gmail.com
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      3f5ba636