Skip to content
  1. Oct 30, 2019
  2. Oct 29, 2019
    • Anton Eidelman's avatar
      nvme-multipath: remove unused groups_only mode in ana log · 86cccfbf
      Anton Eidelman authored
      
      
      groups_only mode in nvme_read_ana_log() is no longer used: remove it.
      
      Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
      Signed-off-by: default avatarAnton Eidelman <anton@lightbitslabs.com>
      Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      86cccfbf
    • Anton Eidelman's avatar
      nvme-multipath: fix possible io hang after ctrl reconnect · af8fd042
      Anton Eidelman authored
      
      
      The following scenario results in an IO hang:
      1) ctrl completes a request with NVME_SC_ANA_TRANSITION.
         NVME_NS_ANA_PENDING bit in ns->flags is set and ana_work is triggered.
      2) ana_work: nvme_read_ana_log() tries to get the ANA log page from the ctrl.
         This fails because ctrl disconnects.
         Therefore nvme_update_ns_ana_state() is not called
         and NVME_NS_ANA_PENDING bit in ns->flags is not cleared.
      3) ctrl reconnects: nvme_mpath_init(ctrl,...) calls
         nvme_read_ana_log(ctrl, groups_only=true).
         However, nvme_update_ana_state() does not update namespaces
         because nr_nsids = 0 (due to groups_only mode).
      4) scan_work calls nvme_validate_ns() finds the ns and re-validates OK.
      
      Result:
      The ctrl is now live but NVME_NS_ANA_PENDING bit in ns->flags is still set.
      Consequently ctrl will never be considered a viable path by __nvme_find_path().
      IO will hang if ctrl is the only or the last path to the namespace.
      
      More generally, while ctrl is reconnecting, its ANA state may change.
      And because nvme_mpath_init() requests ANA log in groups_only mode,
      these changes are not propagated to the existing ctrl namespaces.
      This may result in a mal-function or an IO hang.
      
      Solution:
      nvme_mpath_init() will nvme_read_ana_log() with groups_only set to false.
      This will not harm the new ctrl case (no namespaces present),
      and will make sure the ANA state of namespaces gets updated after reconnect.
      
      Note: Another option would be for nvme_mpath_init() to invoke
      nvme_parse_ana_log(..., nvme_set_ns_ana_state) for each existing namespace.
      
      Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
      Signed-off-by: default avatarAnton Eidelman <anton@lightbitslabs.com>
      Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      af8fd042
  3. Oct 28, 2019
  4. Oct 27, 2019
    • Linus Torvalds's avatar
      Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 153a971f
      Linus Torvalds authored
      Pull x86 fixes from Thomas Gleixner:
       "Two fixes for the VMWare guest support:
      
         - Unbreak VMWare platform detection which got wreckaged by converting
           an integer constant to a string constant.
      
         - Fix the clang build of the VMWAre hypercall by explicitely
           specifying the ouput register for INL instead of using the short
           form"
      
      * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86/cpu/vmware: Fix platform detection VMWARE_PORT macro
        x86/cpu/vmware: Use the full form of INL in VMWARE_HYPERCALL, for clang/llvm
      153a971f
    • Linus Torvalds's avatar
      Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 2b776b54
      Linus Torvalds authored
      Pull timer fixes from Thomas Gleixner:
       "A small set of fixes for time(keeping):
      
         - Add a missing include to prevent compiler warnings.
      
         - Make the VDSO implementation of clock_getres() POSIX compliant
           again. A recent change dropped the NULL pointer guard which is
           required as NULL is a valid pointer value for this function.
      
         - Fix two function documentation typos"
      
      * 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        posix-cpu-timers: Fix two trivial comments
        timers/sched_clock: Include local timekeeping.h for missing declarations
        lib/vdso: Make clock_getres() POSIX compliant again
      2b776b54
    • Linus Torvalds's avatar
      Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · a8a31fdc
      Linus Torvalds authored
      Pull perf fixes from Thomas Gleixner:
       "A set of perf fixes:
      
        kernel:
      
         - Unbreak the tracking of auxiliary buffer allocations which got
           imbalanced causing recource limit failures.
      
         - Fix the fallout of splitting of ToPA entries which missed to shift
           the base entry PA correctly.
      
         - Use the correct context to lookup the AUX event when unmapping the
           associated AUX buffer so the event can be stopped and the buffer
           reference dropped.
      
        tools:
      
         - Fix buildiid-cache mode setting in copyfile_mode_ns() when copying
           /proc/kcore
      
         - Fix freeing id arrays in the event list so the correct event is
           closed.
      
         - Sync sched.h anc kvm.h headers with the kernel sources.
      
         - Link jvmti against tools/lib/ctype.o to have weak strlcpy().
      
         - Fix multiple memory and file descriptor leaks, found by coverity in
           perf annotate.
      
         - Fix leaks in error handling paths in 'perf c2c', 'perf kmem', found
           by a static analysis tool"
      
      * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        perf/aux: Fix AUX output stopping
        perf/aux: Fix tracking of auxiliary trace buffer allocation
        perf/x86/intel/pt: Fix base for single entry topa
        perf kmem: Fix memory leak in compact_gfp_flags()
        tools headers UAPI: Sync sched.h with the kernel
        tools headers kvm: Sync kvm.h headers with the kernel sources
        tools headers kvm: Sync kvm headers with the kernel sources
        tools headers kvm: Sync kvm headers with the kernel sources
        perf c2c: Fix memory leak in build_cl_output()
        perf tools: Fix mode setting in copyfile_mode_ns()
        perf annotate: Fix multiple memory and file descriptor leaks
        perf tools: Fix resource leak of closedir() on the error paths
        perf evlist: Fix fix for freed id arrays
        perf jvmti: Link against tools/lib/ctype.h to have weak strlcpy()
      a8a31fdc
    • Linus Torvalds's avatar
      Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 1e1ac1cb
      Linus Torvalds authored
      Pull irq fixes from Thomas Gleixner:
       "Two fixes for interrupt controller drivers:
      
         - Skip IRQ_M_EXT entries in the device tree when initializing the
           RISCV PLIC controller to avoid a double init attempt.
      
         - Use the correct ITS list when issuing the VMOVP synchronization
           command so the operation works only on the ITS instances which are
           associated to a VM"
      
      * 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        irqchip/sifive-plic: Skip contexts except supervisor in plic_init()
        irqchip/gic-v3-its: Use the exact ITSList for VMOVP
      1e1ac1cb
    • Linus Torvalds's avatar
      Merge tag '5.4-rc5-smb3-fixes' of git://git.samba.org/sfrench/cifs-2.6 · c9a2e4a8
      Linus Torvalds authored
      Pull cifs fixes from Steve French:
       "Seven cifs/smb3 fixes, including three for stable"
      
      * tag '5.4-rc5-smb3-fixes' of git://git.samba.org/sfrench/cifs-2.6:
        cifs: Fix cifsInodeInfo lock_sem deadlock when reconnect occurs
        CIFS: Fix use after free of file info structures
        CIFS: Fix retry mid list corruption on reconnects
        cifs: Fix missed free operations
        CIFS: avoid using MID 0xFFFF
        cifs: clarify comment about timestamp granularity for old servers
        cifs: Handle -EINPROGRESS only when noblockcnt is set
      c9a2e4a8
    • Linus Torvalds's avatar
      Merge tag 'riscv/for-v5.4-rc5-b' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux · 6995a6a5
      Linus Torvalds authored
      Pull RISC-V fixes from Paul Walmsley:
       "Several minor fixes and cleanups for v5.4-rc5:
      
         - Three build fixes for various SPARSEMEM-related kernel
           configurations
      
         - Two cleanup patches for the kernel bug and breakpoint trap handler
           code"
      
      * tag 'riscv/for-v5.4-rc5-b' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux:
        riscv: cleanup do_trap_break
        riscv: cleanup <asm/bug.h>
        riscv: Fix undefined reference to vmemmap_populate_basepages
        riscv: Fix implicit declaration of 'page_to_section'
        riscv: fix fs/proc/kcore.c compilation with sparsemem enabled
      6995a6a5
    • Linus Torvalds's avatar
      Merge tag 'mips_fixes_5.4_3' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux · 5a1e843c
      Linus Torvalds authored
      Pull MIPS fixes from Paul Burton:
       "A few MIPS fixes:
      
         - Fix VDSO time-related function behavior for systems where we need
           to fall back to syscalls, but were instead returning bogus results.
      
         - A fix to TLB exception handlers for Cavium Octeon systems where
           they would inadvertently clobber the $1/$at register.
      
         - A build fix for bcm63xx configurations.
      
         - Switch to using my @kernel.org email address"
      
      * tag 'mips_fixes_5.4_3' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux:
        MIPS: tlbex: Fix build_restore_pagemask KScratch restore
        MIPS: bmips: mark exception vectors as char arrays
        mips: vdso: Fix __arch_get_hw_counter()
        MAINTAINERS: Use @kernel.org address for Paul Burton
      5a1e843c
    • Linus Torvalds's avatar
      Merge tag 'tty-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty · 29768954
      Linus Torvalds authored
      Pull tty/serial driver fix from Greg KH:
       "Here is a single tty/serial driver fix for 5.4-rc5 that resolves a
        reported issue.
      
        It has been in linux-next for a while with no problems"
      
      * tag 'tty-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty:
        8250-men-mcb: fix error checking when get_num_ports returns -ENODEV
      29768954
    • Linus Torvalds's avatar
      Merge tag 'staging-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging · 228bd624
      Linus Torvalds authored
      Pull staging driver fix from Greg KH:
       "Here is a single staging driver fix, for the wlan-ng driver, that
        resolves a reported issue.
      
        It is been in linux-next for a while with no reported issues"
      
      * tag 'staging-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging:
        staging: wlan-ng: fix exit return when sme->key_idx >= NUM_WEPKEYS
      228bd624
    • Linus Torvalds's avatar
      Merge tag 'driver-core-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core · 13fa692e
      Linus Torvalds authored
      Pull driver core fix from Greg KH:
       "Here is a single sysfs fix for 5.4-rc5.
      
        It resolves an error if you actually try to use the __BIN_ATTR_WO()
        macro, seems I never tested it properly before :(
      
        This has been in linux-next for a while with no reported issues"
      
      * tag 'driver-core-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core:
        sysfs: Fixes __BIN_ATTR_WO() macro
      13fa692e
    • Linus Torvalds's avatar
      Merge tag 'char-misc-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc · a03885d5
      Linus Torvalds authored
      Pull binder fix from Greg KH:
       "This is a single binder fix to resolve a reported issue by Jann. It's
        been in linux-next for a while with no reported issues"
      
      * tag 'char-misc-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc:
        binder: Don't modify VMA bounds in ->mmap handler
      a03885d5
    • Linus Torvalds's avatar
      Merge tag 'usb-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb · 0ecdd78c
      Linus Torvalds authored
      Pull USB fixes from Greg KH:
       "Here are a number of small USB driver fixes for 5.4-rc5.
      
        More "fun" with some of the misc USB drivers as found by syzbot, and
        there are a number of other small bugfixes in here for reported
        issues.
      
        All have been in linux-next for a while with no reported issues"
      
      * tag 'usb-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb:
        usb: cdns3: Error out if USB_DR_MODE_UNKNOWN in cdns3_core_init_role()
        USB: ldusb: fix read info leaks
        USB: serial: ti_usb_3410_5052: clean up serial data access
        USB: serial: ti_usb_3410_5052: fix port-close races
        USB: usblp: fix use-after-free on disconnect
        usb: udc: lpc32xx: fix bad bit shift operation
        usb: cdns3: Fix dequeue implementation.
        USB: legousbtower: fix a signedness bug in tower_probe()
        USB: legousbtower: fix memleak on disconnect
        USB: ldusb: fix memleak on disconnect
      0ecdd78c
    • Linus Torvalds's avatar
      Merge branch 'i2c/for-current-fixed' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · 992cb107
      Linus Torvalds authored
      Pull i2c fixes from Wolfram Sang:
       "A few driver fixes for the I2C subsystem"
      
      * 'i2c/for-current-fixed' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
        i2c: stm32f7: remove warning when compiling with W=1
        i2c: stm32f7: fix a race in slave mode with arbitration loss irq
        i2c: stm32f7: fix first byte to send in slave mode
        i2c: mt65xx: fix NULL ptr dereference
        i2c: aspeed: fix master pending state handling
      992cb107
    • Linus Torvalds's avatar
      Merge tag 'for-linus-2019-10-26' of git://git.kernel.dk/linux-block · acf913b7
      Linus Torvalds authored
      Pull block and io_uring fixes from Jens Axboe:
       "A bit bigger than usual at this point in time, mostly due to some good
        bug hunting work by Pavel that resulted in three io_uring fixes from
        him and two from me. Anyway, this pull request contains:
      
         - Revert of the submit-and-wait optimization for io_uring, it can't
           always be done safely. It depends on commands always making
           progress on their own, which isn't necessarily the case outside of
           strict file IO. (me)
      
         - Series of two patches from me and three from Pavel, fixing issues
           with shared data and sequencing for io_uring.
      
         - Lastly, two timeout sequence fixes for io_uring (zhangyi)
      
         - Two nbd patches fixing races (Josef)
      
         - libahci regulator_get_optional() fix (Mark)"
      
      * tag 'for-linus-2019-10-26' of git://git.kernel.dk/linux-block:
        nbd: verify socket is supported during setup
        ata: libahci_platform: Fix regulator_get_optional() misuse
        nbd: handle racing with error'ed out commands
        nbd: protect cmd->status with cmd->lock
        io_uring: fix bad inflight accounting for SETUP_IOPOLL|SETUP_SQTHREAD
        io_uring: used cached copies of sq->dropped and cq->overflow
        io_uring: Fix race for sqes with userspace
        io_uring: Fix broken links with offloading
        io_uring: Fix corrupted user_data
        io_uring: correct timeout req sequence when inserting a new entry
        io_uring : correct timeout req sequence when waiting timeout
        io_uring: revert "io_uring: optimize submit_and_wait API"
      acf913b7
  5. Oct 26, 2019
    • Linus Torvalds's avatar
      Merge tag 's390-5.4-5' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux · f877bee5
      Linus Torvalds authored
      Pull s390 fixes from Vasily Gorbik:
      
       - Add R_390_GLOB_DAT relocation type support. This fixes boot problem
         on linux-next.
      
       - Fix memory leak in zcrypt
      
      * tag 's390-5.4-5' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux:
        s390/kaslr: add support for R_390_GLOB_DAT relocation type
        s390/zcrypt: fix memleak at release
      f877bee5
    • Linus Torvalds's avatar
      Merge tag 'for-linus-5.4-rc5-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip · 4fac2407
      Linus Torvalds authored
      Pull xen fixlet from Juergen Gross:
       "Just one patch for issuing a deprecation warning for 32-bit Xen pv
        guests"
      
      * tag 'for-linus-5.4-rc5-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
        xen: issue deprecation warning for 32-bit pv guest
      4fac2407
    • Linus Torvalds's avatar
      Merge tag 'dma-mapping-5.4-2' of git://git.infradead.org/users/hch/dma-mapping · 964f9cfa
      Linus Torvalds authored
      Pull dma-mapping fix from Christoph Hellwig:
       "Fix a regression in the intel-iommu get_required_mask conversion
        (Arvind Sankar)"
      
      * tag 'dma-mapping-5.4-2' of git://git.infradead.org/users/hch/dma-mapping:
        iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU
      964f9cfa
    • Linus Torvalds's avatar
      Merge tag 'dax-fix-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm · 485fc4b6
      Linus Torvalds authored
      Pull dax fix from Dan Williams:
       "Fix a performance regression that followed from a fix to the
        conversion of the fsdax implementation to the xarray. v5.3 users
        report that they stop seeing huge page mappings on an application +
        filesystem layout that was seeing huge pages previously on v5.2"
      
      * tag 'dax-fix-5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm:
        fs/dax: Fix pmd vs pte conflict detection
      485fc4b6
    • Linus Torvalds's avatar
      Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 1c4e395c
      Linus Torvalds authored
      Pull SCSI fixes from James Bottomley:
       "Nine changes, eight to drivers (qla2xxx, hpsa, lpfc, alua, ch,
        53c710[x2], target) and one core change that tries to close a race
        between sysfs delete and module removal"
      
      * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: lpfc: remove left-over BUILD_NVME defines
        scsi: core: try to get module before removing device
        scsi: hpsa: add missing hunks in reset-patch
        scsi: target: core: Do not overwrite CDB byte 1
        scsi: ch: Make it possible to open a ch device multiple times again
        scsi: fix kconfig dependency warning related to 53C700_LE_ON_BE
        scsi: sni_53c710: fix compilation error
        scsi: scsi_dh_alua: handle RTPG sense code correctly during state transitions
        scsi: qla2xxx: fix a potential NULL pointer dereference
      1c4e395c
    • Christoph Hellwig's avatar
      riscv: cleanup do_trap_break · e8f44c50
      Christoph Hellwig authored
      
      
      If we always compile the get_break_insn_length inline function we can
      remove the ifdefs and let dead code elimination take care of the warn
      branch that is now unreadable because the report_bug stub always
      returns BUG_TRAP_TYPE_BUG.
      
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarAnup Patel <anup@brainfault.org>
      Signed-off-by: default avatarPaul Walmsley <paul.walmsley@sifive.com>
      e8f44c50
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input · b4b61b22
      Linus Torvalds authored
      Pull input fix from Dmitry Torokhov:
       "A fix for st1232 driver to properly report coordinates for 2nd and
        subsequent fingers when more than one is on the surface"
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
        Input: st1232 - fix reporting multitouch coordinates
      b4b61b22
    • Mike Christie's avatar
      nbd: verify socket is supported during setup · cf1b2326
      Mike Christie authored
      
      
      nbd requires socket families to support the shutdown method so the nbd
      recv workqueue can be woken up from its sock_recvmsg call. If the socket
      does not support the callout we will leave recv works running or get hangs
      later when the device or module is removed.
      
      This adds a check during socket connection/reconnection to make sure the
      socket being passed in supports the needed callout.
      
      Reported-by: default avatar <syzbot+24c12fa8d218ed26011a@syzkaller.appspotmail.com>
      Fixes: e9e006f5
      
       ("nbd: fix max number of supported devs")
      Tested-by: default avatarRichard W.M. Jones <rjones@redhat.com>
      Signed-off-by: default avatarMike Christie <mchristi@redhat.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      cf1b2326
    • Mark Brown's avatar
      ata: libahci_platform: Fix regulator_get_optional() misuse · 962399bb
      Mark Brown authored
      
      
      This driver is using regulator_get_optional() to handle all the supplies
      that it handles, and only ever enables and disables all supplies en masse
      without ever doing any other configuration of the device to handle missing
      power. These are clear signs that the API is being misused - it should only
      be used for supplies that may be physically absent from the system and in
      these cases the hardware usually needs different configuration if the
      supply is missing. Instead use normal regualtor_get(), if the supply is
      not described in DT then the framework will substitute a dummy regulator in
      so no special handling is needed by the consumer driver.
      
      In the case of the PHY regulator the handling in the driver is a hack to
      deal with integrated PHYs; the supplies are only optional in the sense
      that that there's some confusion in the code about where they're bound to.
      From a code point of view they function exactly as normal supplies so can
      be treated as such. It'd probably be better to model this by instantiating
      a PHY object for integrated PHYs.
      
      Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      962399bb
    • Josef Bacik's avatar
      nbd: handle racing with error'ed out commands · 7ce23e8e
      Josef Bacik authored
      
      
      We hit the following warning in production
      
      print_req_error: I/O error, dev nbd0, sector 7213934408 flags 80700
      ------------[ cut here ]------------
      refcount_t: underflow; use-after-free.
      WARNING: CPU: 25 PID: 32407 at lib/refcount.c:190 refcount_sub_and_test_checked+0x53/0x60
      Workqueue: knbd-recv recv_work [nbd]
      RIP: 0010:refcount_sub_and_test_checked+0x53/0x60
      Call Trace:
       blk_mq_free_request+0xb7/0xf0
       blk_mq_complete_request+0x62/0xf0
       recv_work+0x29/0xa1 [nbd]
       process_one_work+0x1f5/0x3f0
       worker_thread+0x2d/0x3d0
       ? rescuer_thread+0x340/0x340
       kthread+0x111/0x130
       ? kthread_create_on_node+0x60/0x60
       ret_from_fork+0x1f/0x30
      ---[ end trace b079c3c67f98bb7c ]---
      
      This was preceded by us timing out everything and shutting down the
      sockets for the device.  The problem is we had a request in the queue at
      the same time, so we completed the request twice.  This can actually
      happen in a lot of cases, we fail to get a ref on our config, we only
      have one connection and just error out the command, etc.
      
      Fix this by checking cmd->status in nbd_read_stat.  We only change this
      under the cmd->lock, so we are safe to check this here and see if we've
      already error'ed this command out, which would indicate that we've
      completed it as well.
      
      Reviewed-by: default avatarMike Christie <mchristi@redhat.com>
      Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
      
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      7ce23e8e
    • Josef Bacik's avatar
      nbd: protect cmd->status with cmd->lock · de6346ec
      Josef Bacik authored
      
      
      We already do this for the most part, except in timeout and clear_req.
      For the timeout case we take the lock after we grab a ref on the config,
      but that isn't really necessary because we're safe to touch the cmd at
      this point, so just move the order around.
      
      For the clear_req cause this is initiated by the user, so again is safe.
      
      Reviewed-by: default avatarMike Christie <mchristi@redhat.com>
      Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      de6346ec
    • Linus Torvalds's avatar
      Merge tag 'modules-for-v5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux · 9e2dd2ca
      Linus Torvalds authored
      Pull modules fixes from Jessica Yu:
      
       - Revert __ksymtab_$namespace.$symbol naming scheme back to
         __ksymtab_$symbol, as it was causing issues with depmod.
      
         Instead, have modpost extract a symbol's namespace from __kstrtabns
         and __ksymtab_strings.
      
       - Fix `make nsdeps` for out of tree kernel builds (make O=...) caused
         by unescaped '/'.
      
         Use a different sed delimiter to avoid this problem.
      
      * tag 'modules-for-v5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux:
        scripts/nsdeps: use alternative sed delimiter
        symbol namespaces: revert to previous __ksymtab name scheme
        modpost: make updating the symbol namespace explicit
        modpost: delegate updating namespaces to separate function
      9e2dd2ca
    • Linus Torvalds's avatar
      Merge tag 'armsoc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc · 63cbb3b3
      Linus Torvalds authored
      Pull ARM SoC fixes from Olof Johansson:
       "A slightly larger set of fixes have accrued in the last two weeks.
        Mostly a collection of the usual smaller fixes:
      
         - Marvell Armada: USB phy setup issues on Turris Mox
      
         - Broadcom: GPIO/pinmux DT mapping corrections for Stingray, MMC bus
           width fix for RPi Zero W, GPIO LED removal for RPI CM3. Also some
           maintainer updates.
      
         - OMAP: Fixlets for display config, interrupt settings for wifi, some
           clock/PM pieces. Also IOMMU regression fix and a ti-sysc
           no-watchdog regression fix.
      
         - i.MX: A few fixes around PM/settings, some devicetree fixlets and
           catching up with config option changes in DRM
      
         - Rockchip: RockRro64 misc DT fixups, Hugsun X99 USB-C, Kevin display
           panel settings
      
        ... and some smaller fixes for Davinci (backlight, McBSP DMA),
        Allwinner (phy regulators, PMU removal on A64, etc)"
      
      * tag 'armsoc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc: (42 commits)
        ARM: dts: stm32: relax qspi pins slew-rate for stm32mp157
        MAINTAINERS: Update the Spreadtrum SoC maintainer
        MAINTAINERS: Remove Gregory and Brian for ARCH_BRCMSTB
        ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue
        bus: ti-sysc: Fix watchdog quirk handling
        ARM: OMAP2+: Add pdata for OMAP3 ISP IOMMU
        ARM: OMAP2+: Plug in device_enable/idle ops for IOMMUs
        ARM: davinci_all_defconfig: enable GPIO backlight
        ARM: davinci: dm365: Fix McBSP dma_slave_map entry
        ARM: dts: bcm2835-rpi-zero-w: Fix bus-width of sdhci
        ARM: imx_v6_v7_defconfig: Enable CONFIG_DRM_MSM
        arm64: dts: imx8mn: Use correct clock for usdhc's ipg clk
        arm64: dts: imx8mm: Use correct clock for usdhc's ipg clk
        arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk
        ARM: dts: imx7s: Correct GPT's ipg clock source
        ARM: dts: vf610-zii-scu4-aib: Specify 'i2c-mux-idle-disconnect'
        ARM: dts: imx6q-logicpd: Re-Enable SNVS power key
        arm64: dts: lx2160a: Correct CPU core idle state name
        mailmap: Add Simon Arlott (replacement for expired email address)
        arm64: dts: rockchip: Fix override mode for rk3399-kevin panel
        ...
      63cbb3b3
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · 8c123380
      Linus Torvalds authored
      Pull KVM fixes from Paolo Bonzini:
       "Bugfixes for ARM, PPC and x86, plus selftest improvements"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        KVM: nVMX: Don't leak L1 MMIO regions to L2
        KVM: SVM: Fix potential wrong physical id in avic_handle_ldr_update
        kvm: clear kvmclock MSR on reset
        KVM: x86: fix bugon.cocci warnings
        KVM: VMX: Remove specialized handling of unexpected exit-reasons
        selftests: kvm: fix sync_regs_test with newer gccs
        selftests: kvm: vmx_dirty_log_test: skip the test when VMX is not supported
        selftests: kvm: consolidate VMX support checks
        selftests: kvm: vmx_set_nested_state_test: don't check for VMX support twice
        KVM: Don't shrink/grow vCPU halt_poll_ns if host side polling is disabled
        selftests: kvm: synchronize .gitignore to Makefile
        kvm: x86: Expose RDPID in KVM_GET_SUPPORTED_CPUID
        KVM: arm64: pmu: Reset sample period on overflow handling
        KVM: arm64: pmu: Set the CHAINED attribute before creating the in-kernel event
        arm64: KVM: Handle PMCR_EL0.LC as RES1 on pure AArch64 systems
        KVM: arm64: pmu: Fix cycle counter truncation
        KVM: PPC: Book3S HV: XIVE: Ensure VP isn't already in use
      8c123380
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2019-10-25' of git://anongit.freedesktop.org/drm/drm · 8caacaad
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Quiet week this week, which I suspect means some people just didn't
        get around to sending me fixes pulls in time. This has 2 komeda and a
        bunch of amdgpu fixes in it:
      
        komeda:
         - typo fixes
         - flushing pipes fix
      
        amdgpu:
         - Fix suspend/resume issue related to multi-media engines
         - Fix memory leak in user ptr code related to hmm conversion
         - Fix possible VM faults when allocating page table memory
         - Fix error handling in bo list ioctl"
      
      * tag 'drm-fixes-2019-10-25' of git://anongit.freedesktop.org/drm/drm:
        drm/komeda: Fix typos in komeda_splitter_validate
        drm/komeda: Don't flush inactive pipes
        drm/amdgpu/vce: fix allocation size in enc ring test
        drm/amdgpu: fix error handling in amdgpu_bo_list_create
        drm/amdgpu: fix potential VM faults
        drm/amdgpu: user pages array memory leak fix
        drm/amdgpu/vcn: fix allocation size in enc ring test
        drm/amdgpu/uvd7: fix allocation size in enc ring test (v2)
        drm/amdgpu/uvd6: fix allocation size in enc ring test (v2)
      8caacaad
    • Linus Torvalds's avatar
      Merge tag 'mmc-v5.4-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc · f6492848
      Linus Torvalds authored
      Pull MMC fixes from Ulf Hansson:
       "MMC host fixes:
      
         - mxs: Fix flags passed to dmaengine_prep_slave_sg
      
         - cqhci: Add a missing memory barrier
      
         - sdhci-omap: Fix tuning procedure for temperatures < -20C"
      
      * tag 'mmc-v5.4-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc:
        mmc: mxs: fix flags passed to dmaengine_prep_slave_sg
        mmc: cqhci: Commit descriptors before setting the doorbell
        mmc: sdhci-omap: Fix Tuning procedure for temperatures < -20C
      f6492848
    • Jens Axboe's avatar
      io_uring: fix bad inflight accounting for SETUP_IOPOLL|SETUP_SQTHREAD · 2b2ed975
      Jens Axboe authored
      
      
      We currently assume that submissions from the sqthread are successful,
      and if IO polling is enabled, we use that value for knowing how many
      completions to look for. But if we overflowed the CQ ring or some
      requests simply got errored and already completed, they won't be
      available for polling.
      
      For the case of IO polling and SQTHREAD usage, look at the pending
      poll list. If it ever hits empty then we know that we don't have
      anymore pollable requests inflight. For that case, simply reset
      the inflight count to zero.
      
      Reported-by: default avatarPavel Begunkov <asml.silence@gmail.com>
      Reviewed-by: default avatarPavel Begunkov <asml.silence@gmail.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      2b2ed975
    • Jens Axboe's avatar
      io_uring: used cached copies of sq->dropped and cq->overflow · 498ccd9e
      Jens Axboe authored
      
      
      We currently use the ring values directly, but that can lead to issues
      if the application is malicious and changes these values on our behalf.
      Created in-kernel cached versions of them, and just overwrite the user
      side when we update them. This is similar to how we treat the sq/cq
      ring tail/head updates.
      
      Reported-by: default avatarPavel Begunkov <asml.silence@gmail.com>
      Reviewed-by: default avatarPavel Begunkov <asml.silence@gmail.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      498ccd9e