[ci] project_controller.rb#add_maintained_project

Test for app/controllers/webui/project_controller.rb#add_maintained_project

Pair programming with @Ana06, and @bgeuken

Remove P0 label from CONTRIBUTING.md

[api][webui] Fix deprecated string callback

Remove P0 label from the Contribution readme as it does not exist.

Closes https://github.com/openSUSE/open-build-service/issues/2146

Improve remove_maintained_project test

DEPRECATION WARNING: Passing string to define callback is deprecated and will be removed in Rails 5.1 without replacement.

Improve project_controller#remove_maintained_project test:

- Remove unnecessary comment.
- Check that the maintained project is truly removed in the successful case.

This broke with 878e479f

=======

CodeQualityTest
  test_code_complexity                                            FAIL (11.83s)

Minitest::Assertion:         'RequestController#render_request_collection' => 82.38,

        test/unit/code_quality_test.rb:143:in `block in <class:CodeQualityTest>'
        test/test_helper.rb:124:in `block in __run'
        test/test_helper.rb:124:in `map'
        test/test_helper.rb:124:in `__run'

FATE#320699

Fix bs request counter

[ci] Fix monitor controller spec

Remove unnecessary line in project controller spec

Fix Makefile to support 'make all' command.

Fix monitor controller spec occasionally failing.

This line is not necessary as by default the user home project hasn't got maintenance kind.

We cannot execute "make install" command  before executing "make all"
comand. Let's replace "all:" with "apidocs:" target from Makefile
for an appropriate name. And, append "clean:" target.

$ make
$ make install
$ make clean

This PR is tested on Ubuntu 16.04 LTS X64 distribution.

Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
Reviewed-by: Frank Schreiner <M0ses@github.com>

Should have been in commit 2538c032

So that the logfile contains not just "received truncted answer"...

[webui] Fix issue #2125 - webui can't handle .yaml suffixed files

[webui] Fix has_local_distribution

taking the project name into account. This worked for remote instances but not on build.o.o.

This reverts commit e9bd6d10.

This was causing development systems to crash with a ActiveRecord::StatementInvalid: Mysql2::Error: Table 'api_development.configurations' doesn't exist

Running the migrations to wasn't possible due to a failing SpacesInTrackerRegexen migration.

=====

> vagrant exec rails s
=> Booting Unicorn
=> Rails 5.0.0.1 application starting in development on http://localhost:3000
=> Run `rails server -h` for more startup options
Custom development.vagrant-openSUSE-Leap.rb not found - using defaults
Exiting
/usr/lib64/ruby/gems/2.3.0/gems/mysql2-0.4.4/lib/mysql2/client.rb:107:in `_query': Mysql2::Error: Table 'api_development.configurations' doesn't exist: SELECT  `configurations`.* FROM `configurations` ORDER BY `configurations`.`id` ASC LIMIT 1 (ActiveRecord::StatementInvalid)
	from /usr/lib64/ruby/gems/2.3.0/gems/mysql2-0.4.4/lib/mysql2/client.rb:107:in `block in query'
	from /usr/lib64/ruby/gems/2.3.0/gems/mysql2-0.4.4/lib/mysql2/client.rb:106:in `handle_interrupt'
	from /usr/lib64/ruby/gems/2.3.0/gems/mysql2-0.4.4/lib/mysql2/client.rb:106:in `query'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract_mysql_adapter.rb:218:in `block in execute'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract_adapter.rb:566:in `block in log'
	from /usr/lib64/ruby/gems/2.3.0/gems/activesupport-5.0.0.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract_adapter.rb:560:in `log'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract_mysql_adapter.rb:218:in `execute'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/mysql/database_statements.rb:46:in `execute'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract_mysql_adapter.rb:225:in `execute_and_free'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/mysql/database_statements.rb:51:in `exec_query'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/database_statements.rb:373:in `select'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/database_statements.rb:41:in `select_all'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/query_cache.rb:70:in `select_all'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/mysql/database_statements.rb:10:in `select_all'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/querying.rb:39:in `find_by_sql'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/relation.rb:699:in `exec_queries'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/relation.rb:580:in `load'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/relation.rb:260:in `records'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/relation.rb:256:in `to_a'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/relation/finder_methods.rb:561:in `find_nth_with_limit'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/relation/finder_methods.rb:590:in `find_nth_with_limit_and_offset'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/relation/finder_methods.rb:543:in `find_nth'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/relation/finder_methods.rb:122:in `first'
	from /usr/lib64/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/querying.rb:3:in `first'
	from /vagrant/src/api/config/environments/development.rb:60:in `block (2 levels) in <top (required)>'

Write test for app/controllers/webui/project_controller.rb#remove_maintained_project

Write test for app/controllers/webui/project_controller.rb#remove_maintained_project.

Correct typo in CONTRIBUTING.md

memer -> member

Improve project_controller#remove_maintained_project by rendering an error when the MaintainedProject is not found and by using destroy in the if condition instead of save after doing delete.

Write test for app/controllers/webui/project_controller.rb#unlock.

Pairprogramming with Ana.

This allows to create bs requests with customized bs request actions.

Pairprogramming with Ana.

Write test for app/controllers/webui/project_controller.rb#unlock

[webui][api] Sync configuration to backend on boot

Rails was routing certain .* extensions (.json, .txt, .yml, ...) as different format, which
caused the view file page not to work properly.
This probably is a regression of the recent Rails 5 update.

Setting the specific route to 'html' format by default fixes the issue.