Skip to content
  1. Dec 13, 2012
  2. Dec 11, 2012
  3. Dec 10, 2012
    • Maarten Lankhorst's avatar
      drm/ttm: remove no_wait_reserve, v3 · 97a875cb
      Maarten Lankhorst authored
      
      
      All items on the lru list are always reservable, so this is a stupid
      thing to keep. Not only that, it is used in a way which would
      guarantee deadlocks if it were ever to be set to block on reserve.
      
      This is a lot of churn, but mostly because of the removal of the
      argument which can be nested arbitrarily deeply in many places.
      
      No change of code in this patch except removal of the no_wait_reserve
      argument, the previous patch removed the use of no_wait_reserve.
      
      v2:
       - Warn if -EBUSY is returned on reservation, all objects on the list
         should be reservable. Adjusted patch slightly due to conflicts.
      v3:
       - Focus on no_wait_reserve removal only.
      
      Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@canonical.com>
      Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      97a875cb
    • Maarten Lankhorst's avatar
      drm/ttm: cope with reserved buffers on lru list in ttm_mem_evict_first, v2 · e7ab2019
      Maarten Lankhorst authored
      
      
      Replace the goto loop with a simple for each loop, and only run the
      delayed destroy cleanup if we can reserve the buffer first.
      
      No race occurs, since lru lock is never dropped any more. An empty list
      and a list full of unreservable buffers both cause -EBUSY to be returned,
      which is identical to the previous situation, because previously buffers
      on the lru list were always guaranteed to be reservable.
      
      This should work since currently ttm guarantees items on the lru are
      always reservable, and reserving items blockingly with some bo held
      are enough to cause you to run into a deadlock.
      
      Currently this is not a concern since removal off the lru list and
      reservations are always done with atomically, but when this guarantee
      no longer holds, we have to handle this situation or end up with
      possible deadlocks.
      
      Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@canonical.com>
      Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      e7ab2019
    • Maarten Lankhorst's avatar
      drm/ttm: cope with reserved buffers on swap list in ttm_bo_swapout, v2 · 2b7b3ad2
      Maarten Lankhorst authored
      
      
      Replace the while loop with a simple for each loop, and only run the
      delayed destroy cleanup if we can reserve the buffer first.
      
      No race occurs, since lru lock is never dropped any more. An empty list
      and a list full of unreservable buffers both cause -EBUSY to be returned,
      which is identical to the previous situation.
      
      Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@canonical.com>
      Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      2b7b3ad2
    • Maarten Lankhorst's avatar
      drm/ttm: call ttm_bo_cleanup_refs with reservation and lru lock held, v3 · 85b144f8
      Maarten Lankhorst authored
      
      
      By removing the unlocking of lru and retaking it immediately, a race is
      removed where the bo is taken off the swap list or the lru list between
      the unlock and relock. As such the cleanup_refs code can be simplified,
      it will attempt to call ttm_bo_wait non-blockingly, and if it fails
      it will drop the locks and perform a blocking wait, or return an error
      if no_wait_gpu was set.
      
      The need for looping is also eliminated, since swapout and evict_mem_first
      will always follow the destruction path, no new fence is allowed
      to be attached. As far as I can see this may already have been the case,
      but the unlocking / relocking required a complicated loop to deal with
      re-reservation.
      
      Changes since v1:
       - Simplify no_wait_gpu case by folding it in with empty ddestroy.
       - Hold a reservation while calling ttm_bo_cleanup_memtype_use again.
      Changes since v2:
       - Do not remove bo from lru list while waiting
      
      Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@canonical.com>
      Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      85b144f8
    • Maarten Lankhorst's avatar
      drm/radeon: allow move_notify to be called without reservation · 6ed9ccb4
      Maarten Lankhorst authored
      
      
      The few places that care should have those checks instead.
      This allows destruction of bo backed memory without a reservation.
      It's required for being able to rework the delayed destroy path,
      as it is no longer guaranteed to hold a reservation before unlocking.
      
      However any previous wait is still guaranteed to complete, and it's
      one of the last things to be done before the buffer object is freed.
      
      Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@canonical.com>
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      6ed9ccb4
    • Maarten Lankhorst's avatar
      drm/ttm: change fence_lock to inner lock · 4154f051
      Maarten Lankhorst authored
      
      
      This requires changing the order in ttm_bo_cleanup_refs_or_queue to
      take the reservation first, as there is otherwise no race free way to
      take lru lock before fence_lock.
      
      Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@canonical.com>
      Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      4154f051
    • Dave Airlie's avatar
      Merge branch 'drm-next-3.8' of git://people.freedesktop.org/~agd5f/linux into drm-next · 1a1494de
      Dave Airlie authored
      Alex writes:
      Pretty minor -next pull request.  We some additional new bits waiting
      internally for release.  Hopefully Monday we can get at least some of
      them out.  The others will probably take a few more weeks.
      
      Highlights of the current request:
      - ELD registers for passing audio information to the sound hardware
      - Handle GPUVM page faults more gracefully
      - Misc fixes
      
      Merge radeon test
      * 'drm-next-3.8' of git://people.freedesktop.org/~agd5f/linux: (483 commits)
        drm/radeon: bump driver version for new info ioctl requests
        drm/radeon: fix eDP clk and lane setup for scaled modes
        drm/radeon: add new INFO ioctl requests
        drm/radeon/dce32+: use fractional fb dividers for high clocks
        drm/radeon: use cached memory when evicting for vram on non agp
        drm/radeon: add a CS flag END_OF_FRAME
        drm/radeon: stop page faults from hanging the system (v2)
        drm/radeon/dce4/5: add registers for ELD handling
        drm/radeon/dce3.2: add registers for ELD handling
        radeon: fix pll/ctrc mapping on dce2 and dce3 hardware
        Linux 3.7-rc7
        powerpc/eeh: Do not invalidate PE properly
        Revert "drm/i915: enable rc6 on ilk again"
        ALSA: hda - Fix build without CONFIG_PM
        of/address: sparc: Declare of_iomap as an extern function for sparc again
        PM / QoS: fix wrong error-checking condition
        bnx2x: remove redundant warning log
        vxlan: fix command usage in its doc
        8139cp: revert "set ring address before enabling receiver"
        MPI: Fix compilation on MIPS with GCC 4.4 and newer
        ...
      
      Conflicts:
      	drivers/gpu/drm/exynos/exynos_drm_encoder.c
      	drivers/gpu/drm/exynos/exynos_drm_fbdev.c
      	drivers/gpu/drm/nouveau/core/engine/disp/nv50.c
      1a1494de
  4. Dec 08, 2012
  5. Dec 06, 2012
    • Dave Airlie's avatar
      Merge branch 'connector-to-object-prop' of git://github.com/robclark/kernel-omap4 into drm-next · 8de9e417
      Dave Airlie authored
      * 'connector-to-object-prop' of git://github.com/robclark/kernel-omap4:
        drm: remove legacy drm_connector_property fxns
        drm/nouveau: drm_connector_property -> drm_object_property
        drm/i915: One more drm_connector_property -> drm_object_property
        drm/i2c: drm_connector_property -> drm_object_property
        drm/vmwgfx: drm_connector_property -> drm_object_property
        drm/udl: drm_connector_property -> drm_object_property
        drm/shmob: drm_connector_property -> drm_object_property
        drm/radeon: drm_connector_property -> drm_object_property
        drm/gma500: drm_connector_property -> drm_object_property
      8de9e417
    • Dave Airlie's avatar
      Merge branch 'exynos-drm-next' of... · 00f09afd
      Dave Airlie authored
      Merge branch 'exynos-drm-next' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-next
      
      This patch set adds iommu support, userptr feature to g2d, minor fixups
      and code cleanups.
      
      And the iommu feature has dependency of the below patches related to
      dma mapping framework.
      
      This patch is used to allocate fully physically contiguous memory region.
      - add sending AVI and AVI info frames.
        . this adds some codes for composing AVI and AUI info frames
          and send them every VSYNC for HDMI Certification.
      - bug fix to previous pull request.
      - add some code cleanup
      
      * 'exynos-drm-next' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos: (32 commits)
        drm/exynos: sending AVI and AUI info frames
        drm/exynos: Use devm_clk_get in exynos_drm_fimd.c
        drm/exynos: Use devm_* APIs in exynos_hdmi.c
        drm/exynos: Use devm_clk_get in exynos_mixer.c
        drm/exynos: Fix potential NULL pointer dereference
        drm/exynos: Use devm_clk_get in exynos_drm_g2d.c
        drm/exynos: use sgt instead of pages for framebuffer address
        drm: exynos: fix for loosing display mode header during mode adjustment
        drm/exynos: fix memory leak to EDID block
        drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer
        drm/exynos: add exynos drm specific fb_mmap function
        drm/exynos: make sure that overlay data are updated
        drm/exynos: add vm_ops to specific gem mmaper
        drm/exynos: add userptr feature for g2d module
        drm/exynos: remove unnecessary sg_alloc_table call
        drm: exynos: fix for mapping of dma buffers
        drm/exynos: remove EXYNOS_BO_NONCONTIG type checking.
        drm/exynos: add iommu support for g2d
        drm/exynos: add iommu support for hdmi driver
        drm/exynos: add iommu support to fimd driver
        ...
      00f09afd
  6. Dec 05, 2012