Skip to content
  1. Jun 18, 2018
    • Arnd Bergmann's avatar
      ALSA: line6: stop using get_seconds() · a8eaad7b
      Arnd Bergmann authored
      
      
      The get_seconds() function is deprecated because it truncates the
      timestamp to 32 bits, so all users should change to ktime_get_seconds()
      or ktime_get_real_seconds().
      
      The firmware interface for passing the timestamp is also limited to
      32 bits, so this patch only has the cosmetic effect of avoiding the
      old interface.
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      a8eaad7b
    • Stefan Agner's avatar
      ALSA: ctxfi: use enum type CT_SUM_CTL where appropriate · a753af30
      Stefan Agner authored
      
      
      Currently a variable of type enum CT_AMIXER_CTL is used for enum
      CT_SUM_CTL values. This leads to warnings when using clang:
      sound/pci/ctxfi/ctmixer.c:945:32: warning: implicit conversion from enumeration type
            'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL'
            [-Wenum-conversion]
              for (i = AMIXER_MASTER_F, j = SUM_IN_F;
                                          ~ ^~~~~~~~
      sound/pci/ctxfi/ctmixer.c:975:29: warning: implicit conversion from enumeration type
            'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL'
            [-Wenum-conversion]
              for (i = AMIXER_PCM_F, j = SUM_IN_F; i <= AMIXER_PCM_S; i++, j++) {
                                       ~ ^~~~~~~~
      
      Introduce enum CT_SUM_CTL k and it instead.
      
      Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      a753af30
    • Stefan Agner's avatar
      ALSA: ice1724: remove unused array · 01655193
      Stefan Agner authored
      
      
      This fixes a warning seen with clang:
      
      sound/pci/ice1712/prodigy_hifi.c:321:28: warning: variable 'wm_vol' is not
            needed and will not be emitted [-Wunneeded-internal-declaration]
      static const unsigned char wm_vol[256] = {
                                 ^
      
      Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      01655193
  2. Jun 17, 2018
    • Alastair Bridgewater's avatar
      ALSA: hda/ca0132: Fix DMic data rate for Alienware M17x R4 · a57a46b9
      Alastair Bridgewater authored
      
      
      The commentary says to use various parameters, and lays out what
      the mapping is...  The code used a 32KHz rate when the comment
      says that it needs to use a 48KHz rate.  And this has been the
      case since day one.
      
      On the Alienware M17x R4, the DMic used to have exceptionally quiet
      pickup and a lot of noise.  Changing the data rate fixes both of
      these issues.
      
      Searching the kernel bug tracker for ca0132-related issues shows no
      mention of this being an issue for other hardware, and I have no
      other hardware to test with, so a quirk is used to limit the effect
      to just the M17x R4.
      
      Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      a57a46b9
    • Alastair Bridgewater's avatar
      ALSA: hda/ca0132: Restore PCM Analog Mic-In2 · 5f8ddc6e
      Alastair Bridgewater authored
      Commit 009b8f97 conditionalized
      adding the "CA0132 Analog Mic-In2" PCM with a comment to the
      effect that, "desktops don't use this ADC", but the test was set
      up such that the ADC was only created for desktops.  Invert the
      test.
      
      Fixes: 009b8f97
      
       ("ALSA: hda/ca0132: update core functions for sbz + r3di")
      Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      5f8ddc6e
    • Alastair Bridgewater's avatar
      ALSA: hda/ca0132: Don't test for QUIRK_NONE · 126b75e0
      Alastair Bridgewater authored
      
      
      QUIRK_NONE is, quite explicitly, the default case.  The entire
      point of a quirks system is to allow "programming by difference"
      from a given base case, which requires that merely defining a new
      quirk for some piece of hardware should not change the behavior of
      the driver for that hardware.  In turn, this means that testing
      for QUIRK_NONE explicitly is a violation of that implicit contract.
      
      Change a test for QUIRK_NONE and QUIRK_ALIENWARE to default, and
      add a test for QUIRK_SBZ to disable the default behavior in that
      instance.
      
      Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      126b75e0
    • Alastair Bridgewater's avatar
      ALSA: hda/ca0132: Restore behavior of QUIRK_ALIENWARE · 365c7f25
      Alastair Bridgewater authored
      Commit e93ac30a (ALSA: HDA/ca0132:
      add extra init functions for r3di + sbz) introduced an extra
      initialization function that was improperly guarded, taking effect
      on systems with QUIRK_ALIENWARE, even though such systems were
      supposedly not affected.
      
      It may be that this piece of initialization should be done for all
      systems, but that's not a call that I can make.
      
      Fixes: e93ac30a
      
       ("ALSA: HDA/ca0132: add extra init functions for r3di + sbz")
      Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      365c7f25
    • Alastair Bridgewater's avatar
      ALSA: hda/ca0132: Delete redundant UNSOL event requests · a3d90d67
      Alastair Bridgewater authored
      
      
      During ca0132_init(), ca0132_init_unsol() is run before the
      spec->spec_init_verbs are written.  ca0132_init_unsol() calls
      snd_hda_jack_detect_enable_callback(), which requests UNSOL events
      for three or four nodes, two of which were also (redundantly)
      requested by spec_init_verbs.
      
      Kill the redundant AC_VERB_SET_UNSOLICITED_ENABLE verbs.
      
      Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      a3d90d67
    • Alastair Bridgewater's avatar
      ALSA: hda/ca0132: Delete pointless assignments to struct auto_pin_cfg fields · 7919cd82
      Alastair Bridgewater authored
      
      
      ca0132_config() was setting some values in the auto_pin_cfg for
      the codec... but it is called prior to snd_hda_parse_pin_defcfg(),
      which does a memset() to clear the entire structure as one of its
      first actions, making the entire exercise pointless.
      
      Kill all use of struct auto_pin_cfg from ca0132_config().
      
      Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      7919cd82
    • Takashi Iwai's avatar
      ALSA: hda/realtek - Fix pop noise on Lenovo P50 & co · d5a6cabf
      Takashi Iwai authored
      
      
      Some Lenovo laptops, e.g. Lenovo P50, showed the pop noise at resume
      or runtime resume.  It turned out to be reduced by applying
      alc_no_shutup() just like TPT440 quirk does.
      
      Since there are many Lenovo models showing the same behavior, put this
      workaround in ALC269_FIXUP_THINKPAD_ACPI entry so that it's applied
      commonly to all such Lenovo machines.
      
      Reported-by: default avatarHans de Goede <hdegoede@redhat.com>
      Tested-by: default avatarBenjamin Berg <bberg@redhat.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      d5a6cabf
    • Linus Torvalds's avatar
      Linux 4.18-rc1 · ce397d21
      Linus Torvalds authored
      v4.18-rc1
      ce397d21
    • Linus Torvalds's avatar
      Merge tag 'for-linus-20180616' of git://git.kernel.dk/linux-block · 265c5596
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
       "A collection of fixes that should go into -rc1. This contains:
      
         - bsg_open vs bsg_unregister race fix (Anatoliy)
      
         - NVMe pull request from Christoph, with fixes for regressions in
           this window, FC connect/reconnect path code unification, and a
           trace point addition.
      
         - timeout fix (Christoph)
      
         - remove a few unused functions (Christoph)
      
         - blk-mq tag_set reinit fix (Roman)"
      
      * tag 'for-linus-20180616' of git://git.kernel.dk/linux-block:
        bsg: fix race of bsg_open and bsg_unregister
        block: remov blk_queue_invalidate_tags
        nvme-fabrics: fix and refine state checks in __nvmf_check_ready
        nvme-fabrics: handle the admin-only case properly in nvmf_check_ready
        nvme-fabrics: refactor queue ready check
        blk-mq: remove blk_mq_tagset_iter
        nvme: remove nvme_reinit_tagset
        nvme-fc: fix nulling of queue data on reconnect
        nvme-fc: remove reinit_request routine
        blk-mq: don't time out requests again that are in the timeout handler
        nvme-fc: change controllers first connect to use reconnect path
        nvme: don't rely on the changed namespace list log
        nvmet: free smart-log buffer after use
        nvme-rdma: fix error flow during mapping request data
        nvme: add bio remapping tracepoint
        nvme: fix NULL pointer dereference in nvme_init_subsystem
        blk-mq: reinit q->tag_set_list entry only after grace period
      265c5596
    • Linus Torvalds's avatar
      Merge tag 'docs-broken-links' of git://linuxtv.org/mchehab/experimental · 5e7b9212
      Linus Torvalds authored
      Pull documentation fixes from Mauro Carvalho Chehab:
       "This solves a series of broken links for files under Documentation,
        and improves a script meant to detect such broken links (see
        scripts/documentation-file-ref-check).
      
        The changes on this series are:
      
         - can.rst: fix a footnote reference;
      
         - crypto_engine.rst: Fix two parsing warnings;
      
         - Fix a lot of broken references to Documentation/*;
      
         - improve the scripts/documentation-file-ref-check script, in order
           to help detecting/fixing broken references, preventing
           false-positives.
      
        After this patch series, only 33 broken references to doc files are
        detected by scripts/documentation-file-ref-check"
      
      * tag 'docs-broken-links' of git://linuxtv.org/mchehab/experimental: (26 commits)
        fix a series of Documentation/ broken file name references
        Documentation: rstFlatTable.py: fix a broken reference
        ABI: sysfs-devices-system-cpu: remove a broken reference
        devicetree: fix a series of wrong file references
        devicetree: fix name of pinctrl-bindings.txt
        devicetree: fix some bindings file names
        MAINTAINERS: fix location of DT npcm files
        MAINTAINERS: fix location of some display DT bindings
        kernel-parameters.txt: fix pointers to sound parameters
        bindings: nvmem/zii: Fix location of nvmem.txt
        docs: Fix more broken references
        scripts/documentation-file-ref-check: check tools/*/Documentation
        scripts/documentation-file-ref-check: get rid of false-positives
        scripts/documentation-file-ref-check: hint: dash or underline
        scripts/documentation-file-ref-check: add a fix logic for DT
        scripts/documentation-file-ref-check: accept more wildcards at filenames
        scripts/documentation-file-ref-check: fix help message
        media: max2175: fix location of driver's companion documentation
        media: v4l: fix broken video4linux docs locations
        media: dvb: point to the location of the old README.dvb-usb file
        ...
      5e7b9212
    • Linus Torvalds's avatar
      Merge tag 'fsnotify_for_v4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs · dbb2816f
      Linus Torvalds authored
      Pull fsnotify updates from Jan Kara:
       "fsnotify cleanups unifying handling of different watch types.
      
        This is the shortened fsnotify series from Amir with the last five
        patches pulled out. Amir has modified those patches to not change
        struct inode but obviously it's too late for those to go into this
        merge window"
      
      * tag 'fsnotify_for_v4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:
        fsnotify: add fsnotify_add_inode_mark() wrappers
        fanotify: generalize fanotify_should_send_event()
        fsnotify: generalize send_to_group()
        fsnotify: generalize iteration of marks by object type
        fsnotify: introduce marks iteration helpers
        fsnotify: remove redundant arguments to handle_event()
        fsnotify: use type id to identify connector object type
      dbb2816f
    • Linus Torvalds's avatar
      Merge tag 'fbdev-v4.18' of git://github.com/bzolnier/linux · 644f2639
      Linus Torvalds authored
      Pull fbdev updates from Bartlomiej Zolnierkiewicz:
       "There is nothing really major here, few small fixes, some cleanups and
        dead drivers removal:
      
         - mark omapfb drivers as orphans in MAINTAINERS file (Tomi Valkeinen)
      
         - add missing module license tags to omap/omapfb driver (Arnd
           Bergmann)
      
         - add missing GPIOLIB dependendy to omap2/omapfb driver (Arnd
           Bergmann)
      
         - convert savagefb, aty128fb & radeonfb drivers to use msleep & co.
           (Jia-Ju Bai)
      
         - allow COMPILE_TEST build for viafb driver (media part was reviewed
           by media subsystem Maintainer)
      
         - remove unused MERAM support from sh_mobile_lcdcfb and shmob-drm
           drivers (drm parts were acked by shmob-drm driver Maintainer)
      
         - remove unused auo_k190xfb drivers
      
         - misc cleanups (Souptick Joarder, Wolfram Sang, Markus Elfring, Andy
           Shevchenko, Colin Ian King)"
      
      * tag 'fbdev-v4.18' of git://github.com/bzolnier/linux: (26 commits)
        fb_omap2: add gpiolib dependency
        video/omap: add module license tags
        MAINTAINERS: make omapfb orphan
        video: fbdev: pxafb: match_string() conversion fixup
        video: fbdev: nvidia: fix spelling mistake: "scaleing" -> "scaling"
        video: fbdev: fix spelling mistake: "frambuffer" -> "framebuffer"
        video: fbdev: pxafb: Convert to use match_string() helper
        video: fbdev: via: allow COMPILE_TEST build
        video: fbdev: remove unused sh_mobile_meram driver
        drm: shmobile: remove unused MERAM support
        video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support
        video: fbdev: remove unused auo_k190xfb drivers
        video: omap: Improve a size determination in omapfb_do_probe()
        video: sm501fb: Improve a size determination in sm501fb_probe()
        video: fbdev-MMP: Improve a size determination in path_init()
        video: fbdev-MMP: Delete an error message for a failed memory allocation in two functions
        video: auo_k190x: Delete an error message for a failed memory allocation in auok190x_common_probe()
        video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two functions
        video: sh_mobile_meram: Delete an error message for a failed memory allocation in sh_mobile_meram_probe()
        video: fbdev: sh_mobile_meram: Drop SUPERH platform dependency
        ...
      644f2639
  3. Jun 16, 2018