- Sep 07, 2011
-
-
Haiyang Zhang authored
Because the number of available buffer slots doesn't decrease for failed sends, we should not call netvsc_xmit_completion(), which increase the count of available slots. In this failed case, just free the memory is enough. Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Haiyang Zhang authored
If the packet failed to be sent, we shouldn't count it as the number of outstanding sends. Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Haiyang Zhang authored
Re-order the code in netvsc_probe() to prevent a guest crash caused by packets possibly received from NetVSP before call to register_netdev(). Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Haiyang Zhang authored
netif_notify_peers() caused a kernel warning in netvsc_linkstatus_callback(), because netvsc_linkstatus_callback() is within IRQ context. So we move the first call to netif_notify_peers() into queued work as well, but with zero delay. In addition to "staging-next", this should also be back-ported to stable kernels 2.6.32 and later. Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Haiyang Zhang authored
Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Haiyang Zhang authored
Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Haiyang Zhang authored
hyperv.h is included by hyperv_net.h already, so no need to include it again in these C files. Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
K. Y. Srinivasan authored
A channel in Hyper-V is equivalent to a device. Thus, a channel is persistent once it is presented to the guest, even if the driver managing this device is unloaded. By checking and invoking the driver specific callback function under the protection of the channel inbound_lock, we can properly deal with racing driver unloads since an unloading driver sets the callback to NULL under the protection of this inbound_lock. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
K. Y. Srinivasan authored
The Windows team has informed us that on Windows guests on Hyper-V, they check for events before messages. They also recommended that we do the same. This patch addresses this. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
K. Y. Srinivasan authored
Fix a bug in error handling in vmbus_bus_init(). Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
K. Y. Srinivasan authored
Properly deal with vmbus_driver_register() failures. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Alexey Khoroshilov authored
If any memory allocation failed, goto alloc_status_switch leads to mutex_unlock(&context->ctx_lock) while context is NULL. The patch moves alloc_status_switch to handle error conditions in correct way. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Alexey Khoroshilov authored
If kzalloc failed for allocation of context, goto alloc_status_switch leads to unlock of unacquired driver_lock. The patch moves mutex_lock(&driver_lock) before allocation of context. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Randy Dunlap authored
drivers/staging/rtl8192e/rtllib.h:2329: error: field 'wx_sem' has incomplete type drivers/staging/rtl8192e/rtllib.h:2330: error: field 'scan_sem' has incomplete type drivers/staging/rtl8192e/rtllib.h:2331: error: field 'ips_sem' has incomplete type drivers/staging/rtl8192e/rtllib_wx.c:267: error: implicit declaration of function 'down' drivers/staging/rtl8192e/rtllib_wx.c:290: error: implicit declaration of function 'up' Signed-off-by:
Randy Dunlap <rdunlap@xenotime.net> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete one more disabled feature. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete already disabled code paths. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete already disabled code paths. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete another useless flag. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete already disabled code paths. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete redundant timing data tables. Replace as follows: EnlargeTap4Timing ==> xgifb_tap4_timing NoScaleTap4Timing ==> xgifb_tap4_timing NTSCTap4Timing ==> xgifb_ntsc_525_tap4_timing YPbPr525iTap4Timing ==> xgifb_ntsc_525_tap4_timing YPbPr525pTap4Timing ==> xgifb_ntsc_525_tap4_timing Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete redundant TV data tables. Replace as follows: XGI_EPLCHTVDataPtr ==> xgifb_chrontel_tv XGI_EPLCHTVRegPtr ==> xgifb_chrontel_tv Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
XGI_EPLLCDCRT1Ptr_H and XGI_EPLLCDCRT1Ptr_V tables are identical. Replace as follows: XGI_EPLLCDCRT1Ptr_H ==> xgifb_epllcd_crt1 XGI_EPLLCDCRT1Ptr_V ==> xgifb_epllcd_crt1 Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete duplicated LCD data tables. Replace as follows: XGI_ExtLCD1400x1050Data ==> xgifb_lcd_1400x1050 XGI_StLCD1400x1050Data ==> xgifb_lcd_1400x1050 XGI_ExtLCD1280x1024x75Data ==> xgifb_lcd_1280x1024x75 XGI_StLCD1280x1024x75Data ==> xgifb_lcd_1280x1024x75 XGI_ExtLCDDes1400x1050Data ==> xgifb_lcddes_1400x1050 XGI_StLCDDes1400x1050Data ==> xgifb_lcddes_1400x1050 XGI_ExtLCDDLDes1400x1050Data ==> xgifb_lcddldes_1400x1050 XGI_StLCDDLDes1400x1050Data ==> xgifb_lcddldes_1400x1050 XGI_ExtLCDDes1024x768x75Data ==> xgifb_lcddes_1024x768x75 XGI_StLCDDes1024x768x75Data ==> xgifb_lcddes_1024x768x75 XGI_ExtLCDDes1280x1024x75Data ==> xgifb_lcddes_1280x1024x75 XGI_StLCDDes1280x1024x75Data ==> xgifb_lcddes_1280x1024x75 XGI_ExtLCDDLDes1280x1024x75Data ==> xgifb_lcddldes_1280x1024x75 XGI_StLCDDLDes1280x1024x75Data ==> xgifb_lcddldes_1280x1024x75 Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
PAL-M and PAL-N "YFilter1" tables are identical. Replace as follows: PALMYFilter1 ==> xgifb_palmn_yfilter1 PALNYFilter1 ==> xgifb_palmn_yfilter1 Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
All four "YFilter2" tables are identical. Replace as follows: NTSCYFilter2 ==> xgifb_yfilter2; PALMYFilter2 ==> xgifb_yfilter2; PALNYFilter2 ==> xgifb_yfilter2; PALYFilter2 ==> xgifb_yfilter2; Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Remove redundant initializations. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Eliminate #define Tap4 and related checks. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete routines which have been commented out. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
The code is almost the same for XG21 and XG27, a single routine can cover both. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
The code is almost the same for XG21 and XG27, a single routine can cover both. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete redundant Chrontel TV data. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
IF_DEF_CH7007 is hard-coded to 0, so this is all just dead code that can be deleted. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
IF_DEF_CH7005 is hard-coded to 0, so this is all just dead code that can be deleted. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
IF_DEF_CH7017 is hard-coded to 0, so this is all just dead code that can be deleted. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete redundant function. Also eliminates the following sparse warning: drivers/staging/xgifb/vb_setmode.c:8033:6: warning: symbol 'XGI_OpenCRTC' was not declared. Should it be static? Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Use a common init function for module and built-in driver. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Remove incorrect/misleading text from parameter descriptions. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
Delete all references to mode "none". It should be handled like any other invalid mode. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
According to the comment, the default mode should be 800x600x8 while the index points actually to 800x600x16. Change the comment and move the definition instead of changing the current behaviour. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Aaro Koskinen authored
The default mode is the same regardless of the display type, except for XG21/LCD which is determined dynamically. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-