Commit 5fff13f2 authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

kbd-state: fix autorepeat handling 

When allowing multiple down-events in a row (key autorepeat) we can't
use change_bit() any more to update the state, because autorepeat events
don't change the key state.  We have to explicitly use set_bit() and
clear_bit() instead.

Cc: qemu-stable@nongnu.org
Fixes: 35921860 kbd-state: don't block auto-repeat events
Buglink: https://bugs.launchpad.net/qemu/+bug/1828272


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Message-id: 20190514042443.10735-1-kraxel@redhat.com
parent bfafa473

ui/kbd-state.c

+5 −1
Original line number Diff line number Diff line
@@ -59,7 +59,11 @@ void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode, bool down) 
    }



    /* update key and modifier state */

    change_bit(qcode, kbd->keys);

    if (down) {

        set_bit(qcode, kbd->keys);

    } else {

        clear_bit(qcode, kbd->keys);

    }

    switch (qcode) {

    case Q_KEY_CODE_SHIFT:

    case Q_KEY_CODE_SHIFT_R: