Commit 41f714b1 authored by Lukáš Doktor's avatar Lukáš Doktor Committed by Eduardo Habkost
Browse files

qemu.py: Simplify QMP key-conversion 



The QMP key conversion consist of '_'s to be replaced with '-'s, which
can easily be done by a single `str.replace` method which is faster and
does not require `string` module import.

Signed-off-by: default avatarLukáš Doktor <ldoktor@redhat.com>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170818142613.32394-5-ldoktor@redhat.com>
Reviewed-by: default avatarCleber Rosa <crosa@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 7f33ca78

scripts/qemu.py

+1 −4
Original line number Diff line number Diff line
@@ -13,7 +13,6 @@ 
#



import errno

import string

import os

import sys

import subprocess
@@ -195,14 +194,12 @@ class QEMUMachine(object): 
            self._load_io_log()

            self._post_shutdown()



    underscore_to_dash = string.maketrans('_', '-')



    def qmp(self, cmd, conv_keys=True, **args):

        '''Invoke a QMP command and return the response dict'''

        qmp_args = dict()

        for key, value in args.iteritems():

            if conv_keys:

                qmp_args[key.translate(self.underscore_to_dash)] = value

                qmp_args[key.replace('_', '-')] = value

            else:

                qmp_args[key] = value