Commit 7f33ca78 authored by Lukáš Doktor's avatar Lukáš Doktor Committed by Eduardo Habkost
Browse files

qemu.py: Use iteritems rather than keys() 



Let's avoid creating an in-memory list of keys and query for each value
and use `iteritems` which is an iterator of key-value pairs.

Signed-off-by: default avatarLukáš Doktor <ldoktor@redhat.com>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20170818142613.32394-4-ldoktor@redhat.com>
Reviewed-by: default avatarCleber Rosa <crosa@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 2782fc51

scripts/qemu.py

+3 −3
Original line number Diff line number Diff line
@@ -200,11 +200,11 @@ class QEMUMachine(object): 
    def qmp(self, cmd, conv_keys=True, **args):

        '''Invoke a QMP command and return the response dict'''

        qmp_args = dict()

        for key in args.keys():

        for key, value in args.iteritems():

            if conv_keys:

                qmp_args[key.translate(self.underscore_to_dash)] = args[key]

                qmp_args[key.translate(self.underscore_to_dash)] = value

            else:

                qmp_args[key] = args[key]

                qmp_args[key] = value



        return self._qmp.cmd(cmd, args=qmp_args)