- Jul 03, 2017
-
-
Vinod Koul authored
For driver debugfs, debugfs_remove_recursive() is called which is not needed as it is already done in ASoC core debugfs. And a device managed memory need not be freed explicitly as device core frees it up. So remove unnecessary skl_debugfs_exit(). Fixes: 5cdf6c09 ASoC: ("Intel: Skylake: Add debugfs support") Reported-by:
Julia Lawall <julia.lawall@lip6.fr> Reported-by:
kbuild test robot <fengguang.wu@intel.com> Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Guneshwor Singh <guneshwor.o.singh@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Vinod Koul authored
Commit bdd0384a ("ASoC: Intel: Skylake: Add support to read firmware registers") introduced firmware register read so added sst-dsp-priv.h but missed adding sst-dsp.h as that leads to below compiler warning: In file included from sound/soc/intel/skylake/skl-debug.c:23:0: >> sound/soc/intel/skylake/../common/sst-dsp-priv.h:63:42: warning: 'struct sst_pdata' declared inside parameter list [enabled by default] int (*init)(struct sst_dsp *sst, struct sst_pdata *pdata); ^ >> sound/soc/intel/skylake/../common/sst-dsp-priv.h:63:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] So add the missing header. Fixes: bdd0384a ("ASoC: Intel: Skylake: Add support to read firmware registers") Reported-by:
kbuild test robot <fengguang.wu@intel.com> Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Guneshwor Singh <guneshwor.o.singh@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- Jun 30, 2017
-
-
Vunny Sodhi authored
This patch adds debugfs support to read fw registers, mailbox offsets and sram address. Signed-off-by:
Mousumi Jana <mousumix.jana@intel.com> Signed-off-by:
Ramesh Babu <ramesh.babu@intel.com> Signed-off-by:
Jayachandran B <jayachandran.b@intel.com> Signed-off-by:
Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com> Signed-off-by:
Vunny Sodhi <vunnyx.sodhi@intel.com> Signed-off-by:
Guneshwor Singh <guneshwor.o.singh@intel.com> Acked-By:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Guneshwor Singh authored
SRAM address and memory window size differ for different platforms. So add members to sst_addr structure and initialize them in the respective dsp_init(). Signed-off-by:
Guneshwor Singh <guneshwor.o.singh@intel.com> Acked-By:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Vinod Koul authored
Driver modules have lot of information represented in struct skl_module_cfg. Knowing this is useful for debug, so enable debugfs for this structure. Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Vunny Sodhi <vunnyx.sodhi@intel.com> Signed-off-by:
Guneshwor Singh <guneshwor.o.singh@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Vinod Koul authored
For debug, the kernel debugfs mechanism is available. We can add various debug options for driver like module configuration read, firmware register read etc. This patch adds debugfs as a child to asoc plaform component and caller is added for skylake driver to do init and cleanup of debugfs. Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Vunny Sodhi <vunnyx.sodhi@intel.com> Signed-off-by:
Guneshwor Singh <guneshwor.o.singh@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Wu Fengguang authored
sound/soc/soc-core.c:1961:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 98faf436 ("ASoC: Drop invalid DMI fields when setting card long name from DMI info") CC: Mengdong Lin <mengdong.lin@linux.intel.com> Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- Jun 29, 2017
-
-
Pierre-Louis Bossart authored
jd mode 2 (3.3V) is required apparently Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=96691 Signed-off-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Pierre-Louis Bossart authored
Lenovo platforms use RT5670 with Baytrail, add the required MCLK control and configuration to 19.2MHz Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=96691 Signed-off-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Mengdong Lin authored
Sometimes DMI fields may be invalid and so can't give useful vendor, product or board info, such as "Type2 - Board Manufacturer" or "Type1 - TBD by OEM". Including such invalid DMI fileds may create silly card long name. So this patch creates a black list of invalid strings. And if a DMI field contains any string in this list, it will be excluded from the card long name. Signed-off-by:
Mengdong Lin <mengdong.lin@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- Jun 19, 2017
-
-
Subhransu S. Prusty authored
This patch adds the deepbuffer device which can be opened with a bigger buffer size. The application can disable interrupts and sleep for longer duration. Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Acked-By:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Ramesh Babu authored
DMA buffer size for gateway copier will be calculated based on: For host DMA copier: Input buffer size (ibs) for output direction (playback) Output buffer size (obs) for input direction (capture) For link DMA copier: IBS for input direction (capture) OBS for output direction (playback) Update the driver to use the above. Signed-off-by:
Ramesh Babu <ramesh.babu@intel.com> Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Acked-By:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Ramesh Babu authored
With this patch, the dma buffer size is fetched from topology binary. This buffer size is applicable for gateway copier modules. Now that we can configure DSP dma buffer size, the device can support deep buffer playback. DSP fetches large buffer and can result fewer wakes, which helps in power reduction. Signed-off-by:
Ramesh Babu <ramesh.babu@intel.com> Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Acked-By:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- Jun 17, 2017
-
-
Andy Shevchenko authored
Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify error path and fix potentially wrong assignment if ->probe() fails. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Mark Brown authored
Merge branch 'topic/rt5677' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into asoc-intel
-
Andy Shevchenko authored
GPIO ACPI mapping table is defined on platform basis. Codec driver shouldn't have known what platform is using it. Make codec driver more generic by moving platform code to where it belongs. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Andy Shevchenko authored
I2C devices are enumerated by IDs, and not by instances. Make it clear by using proper module device table for ACPI case. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- Jun 16, 2017
-
-
Takashi Iwai authored
Intel SST driver allocates lots of pages at suspend for saving the firmware states, and this may occasionally lead to the allocation error due to the high order, ending up with the suspend failure. Use kvzalloc() so that it can fall back to vmalloc() gracefully. Signed-off-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- Jun 15, 2017
-
-
Harsha Priya N authored
This patch adds Kabylake I2S machine driver which uses codecs MAX98927 as speakers and RT5514 as dmic on ssp0 and RT5663 as headset on ssp1. Signed-off-by:
Harsha Priya <harshapriya.n@intel.com> Signed-off-by:
Naveen M <naveen.m@intel.com> Acked-By:
Vinod Koul <vinod.koul@intel.com>
-
Harsha Priya N authored
C99 style struct initialization helps in readability as well as initialization of variables not specified as NULL. This patch changes the struct data definitions in skl.c that were not in c99 style. Signed-off-by:
Harsha Priya <harshapriya.n@intel.com> Signed-off-by:
Naveen M <naveen.m@intel.com> Acked-By:
Vinod Koul <vinod.koul@intel.com>
-
Harsha Priya N authored
This patch adds Kabylake I2S machine driver which uses codecs MAX98927 as speakers and RT5514 as dmic on ssp0 and RT5663 as headset on ssp1. Signed-off-by:
Harsha Priya <harshapriya.n@intel.com> Signed-off-by:
Hsin-yu Chao <hychao@google.com> Signed-off-by:
Naveen M <naveen.m@intel.com> Acked-By:
Vinod Koul <vinod.koul@intel.com>
-
- Jun 14, 2017
-
-
Takashi Iwai authored
snd_pcm_hw_constraint_list(), *_ratnums() and *_ratdens() receive the const pointers. Constify the corresponding static objects for better hardening. Signed-off-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Andy Shevchenko authored
In order to make GPIO ACPI library stricter prepare users of gpiod_get_index() to correctly behave when there no mapping is provided by firmware. Here we add explicit mapping between _CRS GpioIo() resources and their names used in the driver. Reviewed-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com> Tested-by:
Nicolas Porcel <nicolasporcel06@gmail.com> Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Takashi Iwai authored
snd_pcm_hw_constraint_list(), *_ratnums() and *_ratdens() receive the const pointers. Constify the corresponding static objects for better hardening. Signed-off-by:
Takashi Iwai <tiwai@suse.de> Acked-By:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Takashi Iwai authored
snd_pcm_hw_constraint_list(), *_ratnums() and *_ratdens() receive the const pointers. Constify the corresponding static objects for better hardening. Signed-off-by:
Takashi Iwai <tiwai@suse.de> Acked-By:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Daniel Drake authored
Add new machine driver, tested with Weibu F3C MiniPC. Based heavily on code provided by David Yang @ Everest, and other machine drivers in the same directory. Signed-off-by:
David Yang <yangxiaohua@everest-semi.com> [drake@endlessm.com: cleanups and modernization] Signed-off-by:
Daniel Drake <drake@endlessm.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- Jun 07, 2017
-
-
Dharageswari R authored
This patch adds a 4-channel dmic fixup so that DMIC copier will receive 4 channel data and further selection will be done by mic-select module. Signed-off-by:
Dharageswari R <dharageswari.r@intel.com> Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Dharageswari R authored
User may prefer to select data from particular mics. A mic-select module in DSP allows this selection. Create possible enum controls to allow user to select a combination of mics to capture data from. Based on the user selection, parameters are generated and passed to mic-select module during init. Signed-off-by:
Dharageswari R <dharageswari.r@intel.com> Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Dharageswari R authored
mic-select module is a DSP module, which is used to select one or more input channels. This patch adds mic-select module type. Signed-off-by:
Dharageswari R <dharageswari.r@intel.com> Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Douglas Anderson authored
In commit 9a075265 ("ASoC: Intel: sst: Remove unused function sst_restore_shim64()"), we deleted the sst_restore_shim64() since it was never used. ...but a quick look at the code shows that we should also be able to remove the sst_save_shim64() function and the structure members we were storing data in. Once we delete sst_save_shim64() there are no longer any users of the 'sst_shim_regs64' structure. That means we can delete it completely and also avoid allocating memory for it. This saves a whopping 136 bytes of devm allocated memory. We also get the nice benefit of avoiding an error path in the init code. Note that the saving code that we're removing (and the comments talking about how important it is to do the save) has been around since commit 336cfbb0 ("ASoC: Intel: mrfld- add ACPI module"). Signed-off-by:
Douglas Anderson <dianders@chromium.org> Reviewed-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- May 25, 2017
-
-
Naveen M authored
Adds kbl_rt5663_max98927_i2s machine driver entry into machine table Signed-off-by:
Naveen M <naveen.m@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Naveen M authored
This patch adds Kabylake I2S machine driver which uses codecs MAX98927 as speakers and RT5663 as headset, configured to ssp0 & ssp1 respectively. Signed-off-by:
Naveen M <naveen.m@intel.com> Signed-off-by:
Harsha Priya <harshapriya.n@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Naveen M authored
Use quirk function to select the correct machine driver by checking all codecs instead of only one based on quirk data. Signed-off-by:
Naveen M <naveen.m@intel.com> Signed-off-by:
Harsha Priya <harshapriya.n@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Naveen M authored
sst_acpi_mach has a quirk field to handle board specific quirks. Patch moves quirk call to sst_acpi_find_machine() instead of calling it in respective driver Signed-off-by:
Naveen M <naveen.m@intel.com> Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Naveen M authored
Create a helper function to search for a matching machine based on HID. No functional change Signed-off-by:
Naveen M <naveen.m@intel.com> Signed-off-by:
Harsha Priya <harshapriya.n@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Naveen M authored
C99 style struct initialization helps in readability as well as initialization of variables not specified as NULL. Patch modifies all skl machine data. Suggested-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
Naveen M <naveen.m@intel.com> Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Naveen M authored
C99 style struct initialization helps in readability as well as initialization of variables not specified as NULL. Patch modifies all atom machine data. Suggested-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
Naveen M <naveen.m@intel.com> Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Shreyas NC authored
Module init params are additional data block in the module private data. Skylake driver doesn't yet have support to parse multiple data blocks if it appears in private data. Add support for parsing of multiple data blocks and module init params. Signed-off-by:
Shreyas NC <shreyas.nc@intel.com> Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Acked-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Matthias Kaehlcke authored
Looks like the function has never been used since it was added by commit b0d94acd ("ASoC: Intel: mrfld - add shim save restore"). Removing it fixes the following warning when building with clang: sound/soc/intel/atom/sst/sst.c:360:20: error: unused function 'sst_restore_shim64' [-Werror,-Wunused-function] Signed-off-by:
Matthias Kaehlcke <mka@chromium.org> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Matthias Kaehlcke authored
Looks like the function has never been used since it was added by commit 17119a46 ("ASoC: Intel: Add Cherrytrail & Braswell machine driver cht_bsw_max98090_ti"). Removing it fixes the following warning when building with clang: sound/soc/intel/boards/cht_bsw_max98090_ti.c:42:35: error: unused function 'cht_get_codec_dai' [-Werror,-Wunused-function] Signed-off-by:
Matthias Kaehlcke <mka@chromium.org> Signed-off-by:
Mark Brown <broonie@kernel.org>
-