Skip to content
  1. Nov 07, 2011
  2. Nov 06, 2011
    • Chris Mason's avatar
      Btrfs: fix race during transaction joins · d43317dc
      Chris Mason authored
      
      
      While we're allocating ram for a new transaction, we drop our spinlock.
      When we get the lock back, we do check to see if a transaction started
      while we slept, but we don't check to make sure it isn't blocked
      because a commit has already started.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      d43317dc
    • Ilya Dryomov's avatar
      Btrfs: fix a potential btrfs_bio leak on scrub fixups · 56d2a48f
      Ilya Dryomov authored
      
      
      In case we were able to map less than we wanted (length < PAGE_SIZE
      clause is true) btrfs_bio is still allocated and we have to free it.
      
      Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      56d2a48f
    • Ilya Dryomov's avatar
    • Ilya Dryomov's avatar
      9510dc4c
    • Chris Mason's avatar
      Btrfs: stop the readahead threads on failed mount · 306c8b68
      Chris Mason authored
      
      
      If we don't stop them, they linger around corrupting
      memory by using pointers to freed things.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      306c8b68
    • Chris Mason's avatar
      Btrfs: fix extent_buffer leak in the metadata IO error handling · c674e04e
      Chris Mason authored
      
      
      The scrub readahead branch brought in a new error handling hook,
      but it was leaking extent_buffer references.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      c674e04e
    • Chris Mason's avatar
      Btrfs: fix the new inspection ioctls for 32 bit compat · 740c3d22
      Chris Mason authored
      
      
      The new ioctls to follow backrefs are not clean for 32/64 bit
      compat.  This reworks them for u64s everywhere.  They are brand new, so
      there are no problems with changing the interface now.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      740c3d22
    • Chris Mason's avatar
      Merge git://git.jan-o-sch.net/btrfs-unstable into integration · 806468f8
      Chris Mason authored
      
      
      Conflicts:
      	fs/btrfs/Makefile
      	fs/btrfs/extent_io.c
      	fs/btrfs/extent_io.h
      	fs/btrfs/scrub.c
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      806468f8
    • Chris Mason's avatar
      Merge branch 'for-chris' of git://github.com/sensille/linux into integration · 531f4b1a
      Chris Mason authored
      
      
      Conflicts:
      	fs/btrfs/ctree.h
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      531f4b1a
    • Josef Bacik's avatar
      Btrfs: fix delayed insertion reservation · c06a0e12
      Josef Bacik authored
      
      
      We all keep getting those stupid warnings from use_block_rsv when running
      stress.sh, and it's because the delayed insertion stuff is being stupid.  It's
      not the delayed insertion stuffs fault, it's all just stupid.  When marking an
      inode dirty for oh say updating the time on it, we just do a
      btrfs_join_transaction, which doesn't reserve any space.  This is stupid because
      we're going to have to have space reserve to make this change, but we do it
      because it's fast because chances are we're going to call it over and over again
      and it doesn't matter.  Well thanks to the delayed insertion stuff this is
      mostly the case, so we do actually need to make this reservation.  So if
      trans->bytes_reserved is 0 then try to do a normal reservation.  If not return
      ENOSPC which will make the btrfs_dirty_inode start a proper transaction which
      will let it do the whole ENOSPC dance and reserve enough space for the delayed
      insertion to steal the reservation from the transaction.
      
      The other stupid thing we do is not reserve space for the inode when writing to
      the thing.  Usually this is ok since we have to update the time so we'd have
      already done all this work before we get to the endio stuff, so it doesn't
      matter.  But this is stupid because we could write the data after the
      transaction commits where we changed the mtime of the inode so we have to cow
      all the way down to the inode anyway.  This used to be masked by the delalloc
      reservation stuff, but because we delay the update it doesn't get masked in this
      case.  So again the delayed insertion stuff bites us in the ass.  So if our
      trans->block_rsv is delalloc, just steal the reservation from the delalloc
      reserve.  Hopefully this won't bite us in the ass, but I've said that before.
      
      With this patch stress.sh no longer spits out those stupid warnings (famous last
      words).  Thanks,
      
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      c06a0e12
    • Chris Mason's avatar
      Btrfs: ClearPageError during writepage and clean_tree_block · bf0da8c1
      Chris Mason authored
      
      
      Failure testing was tripping up over stale PageError bits in
      metadata pages.  If we have an io error on a block, and later on
      end up reusing it, nobody ever clears PageError on those pages.
      
      During commit, we'll find PageError and think we had trouble writing
      the block, which will lead to aborts and other problems.
      
      This changes clean_tree_block and the btrfs writepage code to
      clear the PageError bit.  In both cases we're either completely
      done with the page or the page has good stuff and the error bit
      is no longer valid.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      bf0da8c1
    • Josef Bacik's avatar
      Btrfs: be smarter about committing the transaction in reserve_metadata_bytes · 663350ac
      Josef Bacik authored
      
      
      Because of the overcommit stuff I had to make it so that we committed the
      transaction all the time in reserve_metadata_bytes in case we had overcommitted
      because of delayed items.  This was because previously we had no way of knowing
      how much space was reserved for delayed items.  Now that we have the
      delayed_block_rsv we can check it to see if committing the transaction would get
      us anywhere.  This patch breaks out the committing logic into a helper function
      that will check to see if committing the transaction would free enough space for
      us to get anything done.  With this patch xfstests 83 goes from taking 445
      seconds to taking 28 seconds on my box.  Thanks,
      
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      663350ac
    • Josef Bacik's avatar
      Btrfs: make a delayed_block_rsv for the delayed item insertion · 6d668dda
      Josef Bacik authored
      
      
      I've been hitting warnings in use_block_rsv when running the delayed insertion
      stuff.  It's because we will readjust global block rsv based on what is in use,
      which means we could end up discarding reservations that are for the delayed
      insertion stuff.  So instead create a seperate block rsv for the delayed
      insertion stuff.  This will also make it easier to debug problems with the
      delayed insertion reservations since we will know that only the delayed
      insertion code touches this block_rsv.  Thanks,
      
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      6d668dda
    • Chris Mason's avatar
      Btrfs: add a log of past tree roots · af31f5e5
      Chris Mason authored
      
      
      This takes some of the free space in the btrfs super block
      to record information about most of the roots in the last four
      commits.
      
      It also adds a -o recovery to use the root history log when
      we're not able to read the tree of tree roots, the extent
      tree root, the device tree root or the csum root.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      af31f5e5
    • David Sterba's avatar
      btrfs: separate superblock items out of fs_info · 6c41761f
      David Sterba authored
      
      
      fs_info has now ~9kb, more than fits into one page. This will cause
      mount failure when memory is too fragmented. Top space consumers are
      super block structures super_copy and super_for_commit, ~2.8kb each.
      Allocate them dynamically. fs_info will be ~3.5kb. (measured on x86_64)
      
      Add a wrapper for freeing fs_info and all of it's dynamically allocated
      members.
      
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.cz>
      6c41761f
    • Josef Bacik's avatar
      Btrfs: use the global reserve when truncating the free space cache inode · c8174313
      Josef Bacik authored
      
      
      We no longer use the orphan block rsv for holding the reservation for truncating
      the inode, so instead use the global block rsv and check to make sure it has
      enough space for us to truncate the space.  Thanks,
      
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      c8174313
    • Josef Bacik's avatar
      Btrfs: release metadata from global reserve if we have to fallback for unlink · 5a77d76c
      Josef Bacik authored
      
      
      I fixed a problem where we weren't reserving space for an orphan item when we
      had to fallback to using the global reserve for an unlink, but I introduced
      another problem.  I was migrating the bytes from the transaction reserve to the
      global reserve and then releasing from the global reserve in
      btrfs_end_transaction().  The problem with this is that a migrate will jack up
      the size for the destination, but leave the size alone for the source, with the
      idea that you can do a release normally on the source and it all washes out, and
      then you can do a release again on the destination and it works out right.  My
      way was skipping the release on the trans_block_rsv which still had the jacked
      up size from our original reservation.  So instead release manually from the
      global reserve if this transaction was using it, and then set the
      trans->block_rsv back to the trans_block_rsv so that btrfs_end_transaction
      cleans everything up properly.  With this patch xfstest 83 doesn't emit warnings
      about leaking space.  Thanks,
      
      Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      5a77d76c
    • Chris Mason's avatar
      Btrfs: make sure to flush queued bios if write_cache_pages waits · 01d658f2
      Chris Mason authored
      
      
      write_cache_pages tries to build up a large bio to stuff down the pipe.
      But if it needs to wait for a page lock, it needs to make sure and send
      down any pending writes so we don't deadlock with anyone who has the
      page lock and is waiting for writeback of things inside the bio.
      
      Dave Sterba triggered this as a deadlock between the autodefrag code and
      the extent write_cache_pages
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      01d658f2
    • Chris Mason's avatar
      Btrfs: fix extent pinning bugs in the tree log · e688b725
      Chris Mason authored
      
      
      The tree log had two important bugs that could cause corruptions after a
      crash.  Sometimes we were allowing tree log blocks to be reused after
      the tree log was committed but before the transaction commit was done.
      
      This allowed a future metadata write to overwrite the tree log data.  It
      is fixed by adding a new variant of freeing reserved extents that always
      pins them.  Credit goes to Stefan Behrens and Arne Jansen for many many
      hours spent tracking this bug down.
      
      During tree log replay, we do a pass through the tree log and pin all
      the extents we find.  This makes sure the replay code won't go in and
      use any of those blocks for new allocations during replay.  The problem
      is the free space cache isn't honoring these pinned extents.  So the
      allocator can end up handing them out, leading to all kinds of problems
      during replay.
      
      The fix here is to force any free space cache to load while we pin the
      extents, and then to make sure we remove the pinned extents from the
      free space rbtree.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      Reported-by: default avatarStefan Behrens <sbehrens@giantdisaster.de>
      e688b725
    • Chris Mason's avatar
      Btrfs: make sure btrfs_remove_free_space doesn't leak EAGAIN · 1eae31e9
      Chris Mason authored
      
      
      btrfs_remove_free_space needs to make sure to set ret back to a
      valid return value after setting it to EAGAIN, otherwise we return
      it to the callers.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      1eae31e9
    • Chris Mason's avatar
      Btrfs: don't wait as long for more batches during SSD log commit · cd354ad6
      Chris Mason authored
      
      
      When we're doing log commits, we try to wait for more writers to come in
      and make the commit bigger.  This helps improve performance on rotating
      disks, but on SSDs it adds latencies.
      
      Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
      cd354ad6
  3. Oct 24, 2011
  4. Oct 23, 2011
  5. Oct 22, 2011
  6. Oct 21, 2011