Skip to content
  1. Dec 13, 2018
  2. Dec 11, 2018
  3. Dec 10, 2018
  4. Dec 07, 2018
  5. Dec 06, 2018
    • Rob Herring's avatar
      ASoC: Use of_node_name_eq for node name comparisons · 1d52a74e
      Rob Herring authored
      
      
      Convert string compares of DT node names to use of_node_name_eq helper
      instead. This removes direct access to the node name pointer.
      
      For the FSL ASoC card, the full node names appear to be "ssi", "esai",
      and "sai", so there's not any reason to use strstr and of_node_name_eq
      can be used instead.
      
      Cc: Timur Tabi <timur@kernel.org>
      Cc: Nicolin Chen <nicoleotsuka@gmail.com>
      Cc: Xiubo Li <Xiubo.Lee@gmail.com>
      Cc: Fabio Estevam <fabio.estevam@nxp.com>
      Cc: Liam Girdwood <lgirdwood@gmail.com>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: Jaroslav Kysela <perex@perex.cz>
      Cc: Takashi Iwai <tiwai@suse.com>
      Cc: alsa-devel@alsa-project.org
      Cc: linuxppc-dev@lists.ozlabs.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      1d52a74e
    • Yu Zhao's avatar
      ASoC: use dma_ops of parent device for acp_audio_dma · 23aa128b
      Yu Zhao authored
      
      
      AMD platform device acp_audio_dma can only be created by parent PCI
      device driver (drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c). Pass struct
      device of the parent to snd_pcm_lib_preallocate_pages() so
      dma_alloc_coherent() can use correct dma_ops. Otherwise, it will
      use default dma_ops which is nommu_dma_ops on x86_64 even when
      IOMMU is enabled and set to non passthrough mode.
      
      Though platform device inherits some dma related fields during its
      creation in mfd_add_device(), we can't simply pass its struct device
      to snd_pcm_lib_preallocate_pages() because dma_ops is not among the
      inherited fields. Even it were, drivers/iommu/amd_iommu.c would
      ignore it because get_device_id() doesn't handle platform device.
      
      This change shouldn't give us any trouble even struct device of the
      parent becomes null or represents some non PCI device in the future,
      because get_dma_ops() correctly handles null struct device or uses
      the default dma_ops if struct device doesn't have it set.
      
      Signed-off-by: default avatarYu Zhao <yuzhao@google.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      23aa128b
    • Yu Zhao's avatar
      ASoC: use DMA addr rather than CPU pa for acp_audio_dma · d6d08273
      Yu Zhao authored
      
      
      We shouldn't assume CPU physical address we get from page_to_phys()
      is same as DMA address we get from dma_alloc_coherent(). On x86_64,
      we won't run into any problem with the assumption when dma_ops is
      nommu_dma_ops. However, DMA address is IOVA when IOMMU is enabled.
      And it's most likely different from CPU physical address when AMD
      IOMMU is not in passthrough mode.
      
      Signed-off-by: default avatarYu Zhao <yuzhao@google.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      d6d08273
  6. Dec 05, 2018
  7. Dec 04, 2018