Skip to content
  1. Nov 09, 2011
    • Christoph Hellwig's avatar
      xfs: constify xfs_item_ops · 272e42b2
      Christoph Hellwig authored
      
      
      The log item ops aren't nessecarily the biggest exploit vector, but marking
      them const is easy enough.  Also remove the unused xfs_item_ops_t typedef
      while we're at it.
      
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
      Reviewed-by: default avatarAlex Elder <aelder@sgi.com>
      272e42b2
    • Carlos Maiolino's avatar
      xfs: Fix possible memory corruption in xfs_readlink · b52a360b
      Carlos Maiolino authored
      
      
      Fixes a possible memory corruption when the link is larger than
      MAXPATHLEN and XFS_DEBUG is not enabled. This also remove the
      S_ISLNK assert, since the inode mode is checked previously in
      xfs_readlink_by_handle() and via VFS.
      
      Updated to address concerns raised by Ben Hutchings about the loose
      attention paid to 32- vs 64-bit values, and the lack of handling a
      potentially negative pathlen value:
       - Changed type of "pathlen" to be xfs_fsize_t, to match that of
         ip->i_d.di_size
       - Added checking for a negative pathlen to the too-long pathlen
         test, and generalized the message that gets reported in that case
         to reflect the change
      As a result, if a negative pathlen were encountered, this function
      would return EFSCORRUPTED (and would fail an assertion for a debug
      build)--just as would a too-long pathlen.
      
      Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
      Signed-off-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      b52a360b
  2. Nov 08, 2011
  3. Nov 07, 2011