Skip to content
  1. Nov 08, 2023
    • Uwe Kleine-König's avatar
      ata: pata_gayle: Convert to platform remove callback returning void · 99bce518
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new(), which already returns void. Eventually after all drivers
      are converted, .remove_new() will be renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
      Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      99bce518
    • Uwe Kleine-König's avatar
      ata: pata_falcon: Convert to platform remove callback returning void · 47d4708d
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new(), which already returns void. Eventually after all drivers
      are converted, .remove_new() will be renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
      Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      47d4708d
    • Uwe Kleine-König's avatar
      ata: pata_gayle: Stop using module_platform_driver_probe() · 0b2771dd
      Uwe Kleine-König authored
      
      
      On today's platforms the benefit of platform_driver_probe() isn't that
      relevant any more. It allows to drop some code after booting (or module
      loading) for .probe() and discard the .remove() function completely if
      the driver is built-in. This typically saves a few 100k.
      
      The downside of platform_driver_probe() is that the driver cannot be
      bound and unbound at runtime which is ancient and so slightly
      complicates testing. There are also thoughts to deprecate
      platform_driver_probe() because it adds some complexity in the driver
      core for little gain. Also many drivers don't use it correctly. This
      driver for example misses to mark the driver struct with __ref which is
      needed to suppress a (W=1) modpost warning.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
      Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      0b2771dd
    • Uwe Kleine-König's avatar
      ata: pata_falcon: Stop using module_platform_driver_probe() · 36f10a91
      Uwe Kleine-König authored
      
      
      On today's platforms the benefit of platform_driver_probe() isn't that
      relevant any more. It allows to drop some code after booting (or module
      loading) for .probe() and discard the .remove() function completely if
      the driver is built-in. This typically saves a few 100k.
      
      The downside of platform_driver_probe() is that the driver cannot be
      bound and unbound at runtime which is ancient and so slightly
      complicates testing. There are also thoughts to deprecate
      platform_driver_probe() because it adds some complexity in the driver
      core for little gain. Also many drivers don't use it correctly. This
      driver for example misses to mark the driver struct with __ref which is
      needed to suppress a (W=1) modpost warning.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
      Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      36f10a91
    • Damien Le Moal's avatar
      ata: libata-core: Fix ata_pci_shutdown_one() · fd3a6837
      Damien Le Moal authored
      This reverts commit 5b6fba54.
      
      Commit 5b6fba54 ("ata: libata-core: Detach a port devices on
      shutdown") modified the function ata_pci_shutdown_one() to stop
      (suspend) devices attached to the ports of a PCI AHCI adapter to ensure
      that drives are spun down before shutting down a system. However, this
      is done only for PCI adapters and not for other types of adapters. This
      limitation was addressed with commit 24eca2dc ("scsi: sd: Introduce
      manage_shutdown device flag"). With this, all ATA disks are spun down on
      system shutdown, which make the changes introduced with 5b6fba54
      
      
      useless.
      
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
      fd3a6837
    • Linus Torvalds's avatar
      Merge tag 'vfs-6.7.fsid' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs · 13d88ac5
      Linus Torvalds authored
      Pull vfs fanotify fsid updates from Christian Brauner:
       "This work is part of the plan to enable fanotify to serve as a drop-in
        replacement for inotify. While inotify is availabe on all filesystems,
        fanotify currently isn't.
      
        In order to support fanotify on all filesystems two things are needed:
      
         (1) all filesystems need to support AT_HANDLE_FID
      
         (2) all filesystems need to report a non-zero f_fsid
      
        This contains (1) and allows filesystems to encode non-decodable file
        handlers for fanotify without implementing any exportfs operations by
        encoding a file id of type FILEID_INO64_GEN from i_ino and
        i_generation.
      
        Filesystems that want to opt out of encoding non-decodable file ids
        for fanotify that don't support NFS export can do so by providing an
        empty export_operations struct.
      
        This also partially addresses (2) by generating f_fsid for simple
        filesystems as well as freevxfs. Remaining filesystems will be dealt
        with by separate patches.
      
        Finally, this contains the patch from the current exportfs maintainers
        which moves exportfs under vfs with Chuck, Jeff, and Amir as
        maintainers and vfs.git as tree"
      
      * tag 'vfs-6.7.fsid' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs:
        MAINTAINERS: create an entry for exportfs
        fs: fix build error with CONFIG_EXPORTFS=m or not defined
        freevxfs: derive f_fsid from bdev->bd_dev
        fs: report f_fsid from s_dev for "simple" filesystems
        exportfs: support encoding non-decodeable file handles by default
        exportfs: define FILEID_INO64_GEN* file handle types
        exportfs: make ->encode_fh() a mandatory method for NFS export
        exportfs: add helpers to check if filesystem can encode/decode file handles
      13d88ac5
    • Linus Torvalds's avatar
      Merge tag 'vfs-6.7.iomap' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs · 062cca89
      Linus Torvalds authored
      Pull iomap maintainership rotation from Christian Brauner:
       "As discussed on list last week this makes fs/iomap part of vfs.git
        with Darrick as main reviewer"
      
      * tag 'vfs-6.7.iomap' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs:
        iomap: rename iomap entry
        iomap: rotate maintainers
      062cca89
    • Linus Torvalds's avatar
      Merge tag 'gfs2-v6.6-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 · 1a0507d8
      Linus Torvalds authored
      Pull gfs2 updates from Andreas Gruenbacher:
      
       - Don't update inode timestamps for direct writes (performance
         regression fix)
      
       - Skip no-op quota records instead of panicing
      
       - Fix a RCU race in gfs2_permission()
      
       - Various other smaller fixes and cleanups all over the place
      
      * tag 'gfs2-v6.6-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2: (24 commits)
        gfs2: don't withdraw if init_threads() got interrupted
        gfs2: remove dead code in add_to_queue
        gfs2: Fix slab-use-after-free in gfs2_qd_dealloc
        gfs2: Silence "suspicious RCU usage in gfs2_permission" warning
        gfs2: fs: derive f_fsid from s_uuid
        gfs2: No longer use 'extern' in function declarations
        gfs2: Rename gfs2_lookup_{ simple => meta }
        gfs2: Convert gfs2_internal_read to folios
        gfs2: Convert stuffed_readpage to folios
        gfs2: Minor gfs2_write_jdata_batch PAGE_SIZE cleanup
        gfs2: Get rid of gfs2_alloc_blocks generation parameter
        gfs2: Add metapath_dibh helper
        gfs2: Clean up quota.c:print_message
        gfs2: Clean up gfs2_alloc_parms initializers
        gfs2: Two quota=account mode fixes
        gfs2: Stop using GFS2_BASIC_BLOCK and GFS2_BASIC_BLOCK_SHIFT
        gfs2: setattr_chown: Add missing initialization
        gfs2: fix an oops in gfs2_permission
        gfs2: ignore negated quota changes
        gfs2: Don't update inode timestamps for direct writes
        ...
      1a0507d8
    • Linus Torvalds's avatar
      Merge tag 'ovl-update-6.7' of git://git.kernel.org/pub/scm/linux/kernel/git/overlayfs/vfs · 7f851936
      Linus Torvalds authored
      Pull overlayfs updates from Amir Goldstein:
      
       - Overlayfs aio cleanups and fixes
      
         Cleanups and minor fixes in preparation for factoring out of
         read/write passthrough code.
      
       - Overlayfs lock ordering changes
      
         Hold mnt_writers only throughout copy up instead of a long lived
         elevated refcount.
      
       - Add support for nesting overlayfs private xattrs
      
         There are cases where you want to use an overlayfs mount as a
         lowerdir for another overlayfs mount. For example, if the system
         rootfs is on overlayfs due to composefs, or to make it volatile (via
         tmpfs), then you cannot currently store a lowerdir on the rootfs,
         because the inner overlayfs will eat all the whiteouts and overlay
         xattrs. This means you can't e.g. store on the rootfs a prepared
         container image for use with overlayfs.
      
         This adds support for nesting of overlayfs mounts by escaping the
         problematic features and unescaping them when exposing to the
         overlayfs user.
      
       - Add new mount options for appending lowerdirs
      
      * tag 'ovl-update-6.7' of git://git.kernel.org/pub/scm/linux/kernel/git/overlayfs/vfs:
        ovl: add support for appending lowerdirs one by one
        ovl: refactor layer parsing helpers
        ovl: store and show the user provided lowerdir mount option
        ovl: remove unused code in lowerdir param parsing
        ovl: Add documentation on nesting of overlayfs mounts
        ovl: Add an alternative type of whiteout
        ovl: Support escaped overlay.* xattrs
        ovl: Add OVL_XATTR_TRUSTED/USER_PREFIX_LEN macros
        ovl: Move xattr support to new xattrs.c file
        ovl: do not encode lower fh with upper sb_writers held
        ovl: do not open/llseek lower file with upper sb_writers held
        ovl: reorder ovl_want_write() after ovl_inode_lock()
        ovl: split ovl_want_write() into two helpers
        ovl: add helper ovl_file_modified()
        ovl: protect copying of realinode attributes to ovl inode
        ovl: punt write aio completion to workqueue
        ovl: propagate IOCB_APPEND flag on writes to realfile
        ovl: use simpler function to convert iocb to rw flags
      7f851936
    • Linus Torvalds's avatar
      Merge tag 'bcachefs-2023-11-5' of https://evilpiepirate.org/git/bcachefs · c9d01179
      Linus Torvalds authored
      Pull more bcachefs updates from Kent Overstreet:
       "Here's the second big bcachefs pull request. This brings your tree up
        to date with my master branch, which is what existing bcachefs users
        are currently running.
      
        New features:
         - rebalance_work btree (and metadata version 1.3): the rebalance
           thread no longer has to scan to find extents that need processing -
           big scalability improvement.
         - sb_errors superblock section: this adds counters for each fsck
           error type, since filesystem creation, along with the date of the
           most recent error. It'll get us better bug reports (since users do
           not typically report errors that fsck was able to fix), and I might
           add telemetry for this in the future.
      
        Fixes include:
         - multiple snapshot deletion fixes
         - members_v2 fixups
         - deleted_inodes btree fixes
         - copygc thread no longer spins when a device is full but has no
           fragmented buckets (i.e. rebalance needs to move data around
           instead)
         - a fix for a memory reclaim issue with the btree key cache: we're
           now careful not to hold the srcu read lock that blocks key cache
           reclaim for too long
         - an early allocator locking fix, from Brian
         - endianness fixes, from Brian
         - CONFIG_BCACHEFS_DEBUG_TRANSACTIONS no longer defaults to y, a big
           performance improvement on multithreaded workloads"
      
      * tag 'bcachefs-2023-11-5' of https://evilpiepirate.org/git/bcachefs: (70 commits)
        bcachefs: Improve stripe checksum error message
        bcachefs: Simplify, fix bch2_backpointer_get_key()
        bcachefs: kill thing_it_points_to arg to backpointer_not_found()
        bcachefs: bch2_ec_read_extent() now takes btree_trans
        bcachefs: bch2_stripe_to_text() now prints ptr gens
        bcachefs: Don't iterate over journal entries just for btree roots
        bcachefs: Break up bch2_journal_write()
        bcachefs: Replace ERANGE with private error codes
        bcachefs: bkey_copy() is no longer a macro
        bcachefs: x-macro-ify inode flags enum
        bcachefs: Convert bch2_fs_open() to darray
        bcachefs: Move __bch2_members_v2_get_mut to sb-members.h
        bcachefs: bch2_prt_datetime()
        bcachefs: CONFIG_BCACHEFS_DEBUG_TRANSACTIONS no longer defaults to y
        bcachefs: Add a comment for BTREE_INSERT_NOJOURNAL usage
        bcachefs: rebalance_work btree is not a snapshots btree
        bcachefs: Add missing printk newlines
        bcachefs: Fix recovery when forced to use JSET_NO_FLUSH journal entry
        bcachefs: .get_parent() should return an error pointer
        bcachefs: Fix bch2_delete_dead_inodes()
        ...
      c9d01179
  2. Nov 07, 2023
    • Amir Goldstein's avatar
      MAINTAINERS: create an entry for exportfs · 4ad714df
      Amir Goldstein authored
      
      
      Split the exportfs entry from the nfsd entry and add myself as reviewer.
      
      Suggested-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Acked-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Acked-by: default avatarJeff Layton <jlayton@redhat.com>
      Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
      Link: https://lore.kernel.org/r/20231026205553.143556-1-amir73il@gmail.com
      
      
      Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
      4ad714df
    • Christian Brauner's avatar
      iomap: rename iomap entry · 64bc7eee
      Christian Brauner authored
      
      
      Since this is now part of the vfs trees rename it accordingly and remove
      the old tree referencing xfs.
      
      Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
      64bc7eee
    • Linus Torvalds's avatar
      Merge tag 'media/v6.7-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media · be3ca57c
      Linus Torvalds authored
      Pull media updates from Mauro Carvalho Chehab:
      
       - the old V4L2 core videobuf kAPI was finally removed. All media
         drivers should now be using VB2 kAPI
      
       - new automotive driver: mgb4
      
       - new platform video driver: npcm-video
      
       - new sensor driver: mt9m114
      
       - new TI driver used in conjunction with Cadence CSI2RX IP to bridge
         TI-specific parts
      
       - ir-rx51 was removed and the N900 DT binding was moved to the
         pwm-ir-tx generic driver
      
       - drop atomisp-specific ov5693, using the upstream driver instead
      
       - the camss driver has gained RDI3 support for VFE 17x
      
       - the atomisp driver now detects ISP2400 or ISP2401 at run time. No
         need to set it up at build time anymore
      
       - lots of driver fixes, cleanups and improvements
      
      * tag 'media/v6.7-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (377 commits)
        media: nuvoton: VIDEO_NPCM_VCD_ECE should depend on ARCH_NPCM
        media: venus: Fix firmware path for resources
        media: venus: hfi_cmds: Replace one-element array with flex-array member and use __counted_by
        media: venus: hfi_parser: Add check to keep the number of codecs within range
        media: venus: hfi: add checks to handle capabilities from firmware
        media: venus: hfi: fix the check to handle session buffer requirement
        media: venus: hfi: add checks to perform sanity on queue pointers
        media: platform: cadence: select MIPI_DPHY dependency
        media: MAINTAINERS: Fix path for J721E CSI2RX bindings
        media: cec: meson: always include meson sub-directory in Makefile
        media: videobuf2: Fix IS_ERR checking in vb2_dc_put_userptr()
        media: platform: mtk-mdp3: fix uninitialized variable in mdp_path_config()
        media: mediatek: vcodec: using encoder device to alloc/free encoder memory
        media: imx-jpeg: notify source chagne event when the first picture parsed
        media: cx231xx: Use EP5_BUF_SIZE macro
        media: siano: Drop unnecessary error check for debugfs_create_dir/file()
        media: mediatek: vcodec: Handle invalid encoder vsi
        media: aspeed: Drop unnecessary error check for debugfs_create_file()
        Documentation: media: buffer.rst: fix V4L2_BUF_FLAG_PREPARED
        Documentation: media: gen-errors.rst: fix confusing ENOTTY description
        ...
      be3ca57c
  3. Nov 06, 2023