Skip to content
Commit 2bdfd282 authored by Waiman Long's avatar Waiman Long Committed by Tejun Heo
Browse files

cgroup/cpuset: Fix "suspicious RCU usage" lockdep warning

It was found that a "suspicious RCU usage" lockdep warning was issued
with the rcu_read_lock() call in update_sibling_cpumasks().  It is
because the update_cpumasks_hier() function may sleep. So we have
to release the RCU lock, call update_cpumasks_hier() and reacquire
it afterward.

Also add a percpu_rwsem_assert_held() in update_sibling_cpumasks()
instead of stating that in the comment.

Fixes: 4716909c

 ("cpuset: Track cpusets that use parent's effective_cpus")
Signed-off-by: default avatarWaiman Long <longman@redhat.com>
Tested-by: default avatarPhil Auld <pauld@redhat.com>
Reviewed-by: default avatarPhil Auld <pauld@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 24f60085
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment