Skip to content
Commit 99f2486c authored by Kartar Singh's avatar Kartar Singh Committed by Chromium LUCI CQ
Browse files

Revert "Add modules from libunwindstack directly to module_cache"

This reverts commit b1f445bb.

Reason for revert: Some native modules in traces will be missing build ids as a result. Since we are creating NonElfModule objects for all the associated maps. And the GetId() for NonElfModule objects is a trivial implementation returning empty string.

Original change's description:
> Add modules from libunwindstack directly to module_cache
>
> libunwindstack's Unwinder object populates vector of frames
> which already have pointer to associated MapInfo object.
> As per the current implementation we were querying Maps
> object again to get the associated MapInfo object for creating a
> Module object. With this CL we avoid doing the redundant
> query(maps_->Find()) on the Maps object.
> This would also solve the issue of "missing" module info
> for interpreted java frames.
>
> Bug: 1370988, b/246509988
> Change-Id: Ida7c7d97f7d0afc675a6bb08a4d6b070345f079d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3981354


> Reviewed-by: default avatarTushar Agarwal <agarwaltushar@google.com>
> Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
> Commit-Queue: Kartar Singh <kartarsingh@google.com>
> Cr-Commit-Position: refs/heads/main@{#1064538}

Bug: 1370988, b/246509988
Change-Id: If25a9fa9309d3d5ea6dcd8378eff9e2fdc6b58ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3990407


Reviewed-by: default avatarTushar Agarwal <agarwaltushar@google.com>
Reviewed-by: default avatarKartar Singh <kartarsingh@google.com>
Commit-Queue: Kartar Singh <kartarsingh@google.com>
Cr-Commit-Position: refs/heads/main@{#1064793}
parent 7f498d42
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment