Skip to content
Commit b1f445bb authored by Kartar Singh's avatar Kartar Singh Committed by Chromium LUCI CQ
Browse files

Add modules from libunwindstack directly to module_cache

libunwindstack's Unwinder object populates vector of frames
which already have pointer to associated MapInfo object.
As per the current implementation we were querying Maps
object again to get the associated MapInfo object for creating a
Module object. With this CL we avoid doing the redundant
query(maps_->Find()) on the Maps object.
This would also solve the issue of "missing" module info
for interpreted java frames.

Bug: 1370988, b/246509988
Change-Id: Ida7c7d97f7d0afc675a6bb08a4d6b070345f079d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3981354


Reviewed-by: default avatarTushar Agarwal <agarwaltushar@google.com>
Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
Commit-Queue: Kartar Singh <kartarsingh@google.com>
Cr-Commit-Position: refs/heads/main@{#1064538}
parent c8643ea9
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment