Skip to content
Commit 34347e76 authored by Francois Pierre Doray's avatar Francois Pierre Doray Committed by Chromium LUCI CQ
Browse files

Revert "Refactor how Chrome Root Store is enabled in builds where it is optional"

This reverts commit e1f06cd9.

Reason for revert: Suspect for crbug.com/1432297

Original change's description:
> Refactor how Chrome Root Store is enabled in builds where it is optional
>
> Previously the choice to use CRS is locked in by
> cert_verifier_configuration.cc on the first time it is initialized.
> However this would be problematic for enterprise policies especially on
> chromeos where the profile policies won't be loaded during the login
> screen, so the wrong value could get locked in. Make the policy support
> dynamic_refresh, so that it would be applied once the profile policy
> loads. Making it support dynamic_refresh also makes the policy more
> user-friendly in other scenarios too.
>
> To do this the CRS boolean is added as another parameter to the
> CertVerifierWithUpdatableProc factory, so that the factory can create a
> new verifier with or without CRS when the parameter changes. The
> parameter is saved by the CertVerifierServiceFactory so that all
> verifiers created by the factory will use the same setting, and any
> existing verifiers created by the factory will be updated to use the new
> setting if it changes.
>
> Bug: 1340420, 1352171
> Change-Id: I4a6ad6abffb1036ab47db1795ed81c7adfaac7a5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4390596


> Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: default avatarIgor <igorcov@chromium.org>
> Reviewed-by: default avatarMatthew Denton <mpdenton@chromium.org>
> Reviewed-by: default avatarRakina Zata Amni <rakina@chromium.org>
> Reviewed-by: default avatarSorin Jianu <sorin@chromium.org>
> Commit-Queue: Matt Mueller <mattm@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1128702}

Bug: 1340420, 1352171, 1432297
Change-Id: Ice5dcd0ab4f8c6dda49a07099268c9664dceed98
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416236
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
Auto-Submit: Francois Pierre Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128848}
parent cac961c0
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment