Skip to content
  1. May 13, 2021
    • Greg Kroah-Hartman's avatar
      Revert "niu: fix missing checks of niu_pci_eeprom_read" · 7930742d
      Greg Kroah-Hartman authored
      This reverts commit 26fd962b.
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It will be fixed up "correctly" in a
      later kernel change.
      
      The change here was incorrect.  While it is nice to check if
      niu_pci_eeprom_read() succeeded or not when using the data, any error
      that might have happened was not propagated upwards properly, causing
      the kernel to assume that these reads were successful, which results in
      invalid data in the buffer that was to contain the successfully read
      data.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Cc: Shannon Nelson <shannon.lee.nelson@gmail.com>
      Cc: David S. Miller <davem@davemloft.net>
      Fixes: 26fd962b
      
       ("niu: fix missing checks of niu_pci_eeprom_read")
      Cc: stable <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20210503115736.2104747-23-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7930742d
    • Anirudh Rayabharam's avatar
      net: stmicro: handle clk_prepare() failure during init · 0c32a96d
      Anirudh Rayabharam authored
      
      
      In case clk_prepare() fails, capture and propagate the error code up the
      stack. If regulator_enable() was called earlier, properly unwind it by
      calling regulator_disable().
      
      Signed-off-by: default avatarAnirudh Rayabharam <mail@anirudhrb.com>
      Cc: David S. Miller <davem@davemloft.net>
      Cc: stable <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20210503115736.2104747-22-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      0c32a96d
    • Greg Kroah-Hartman's avatar
      Revert "net: stmicro: fix a missing check of clk_prepare" · bee1b051
      Greg Kroah-Hartman authored
      This reverts commit f86a3b83.
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It will be fixed up "correctly" in a
      later kernel change.
      
      The original commit causes a memory leak when it is trying to claim it
      is properly handling errors.  Revert this change and fix it up properly
      in a follow-on commit.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Cc: David S. Miller <davem@davemloft.net>
      Fixes: f86a3b83
      
       ("net: stmicro: fix a missing check of clk_prepare")
      Cc: stable <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20210503115736.2104747-21-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      bee1b051
    • Du Cheng's avatar
      net: caif: remove BUG_ON(dev == NULL) in caif_xmit · 65a67792
      Du Cheng authored
      
      
      The condition of dev == NULL is impossible in caif_xmit(), hence it is
      for the removal.
      
      Explanation:
      The static caif_xmit() is only called upon via a function pointer
      `ndo_start_xmit` defined in include/linux/netdevice.h:
      ```
      struct net_device_ops {
          ...
          netdev_tx_t     (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev);
          ...
      }
      ```
      
      The exhausive list of call points are:
      ```
      drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
          dev->netdev_ops->ndo_start_xmit(skb, dev);
          ^                                    ^
      
      drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c
          struct opa_vnic_adapter *adapter = opa_vnic_priv(netdev);
      			     ^                       ^
          return adapter->rn_ops->ndo_start_xmit(skb, netdev); // adapter would crash first
      	   ^                                    ^
      
      drivers/usb/gadget/function/f_ncm.c
          ncm->netdev->netdev_ops->ndo_start_xmit(NULL, ncm->netdev);
      	      ^                                   ^
      
      include/linux/netdevice.h
      static inline netdev_tx_t __netdev_start_xmit(...
      {
          return ops->ndo_start_xmit(skb, dev);
      				    ^
      }
      
          const struct net_device_ops *ops = dev->netdev_ops;
      				       ^
          rc = __netdev_start_xmit(ops, skb, dev, more);
      				       ^
      ```
      
      In each of the enumerated scenarios, it is impossible for the NULL-valued dev to
      reach the caif_xmit() without crashing the kernel earlier, therefore `BUG_ON(dev ==
      NULL)` is rather useless, hence the removal.
      
      Cc: David S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarDu Cheng <ducheng2@gmail.com>
      Link: https://lore.kernel.org/r/20210503115736.2104747-20-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      65a67792
    • Greg Kroah-Hartman's avatar
      Revert "net: caif: replace BUG_ON with recovery code" · 4df07045
      Greg Kroah-Hartman authored
      This reverts commit c5dea815
      
      .
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It will be fixed up "correctly" in a
      later kernel change.
      
      The original change here was pointless as dev can never be NULL in this
      function so the claim in the changelog that this "fixes" anything is
      incorrect (also the developer forgot about panic_on_warn).  A follow-up
      change will resolve this issue properly.
      
      Cc: Aditya Pakki <pakki001@umn.edu>
      Cc: David S. Miller <davem@davemloft.net>
      Link: https://lore.kernel.org/r/20210503115736.2104747-19-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4df07045
    • Anirudh Rayabharam's avatar
      net/smc: properly handle workqueue allocation failure · bbeb18f2
      Anirudh Rayabharam authored
      
      
      In smcd_alloc_dev(), if alloc_ordered_workqueue() fails, properly catch
      it, clean up and return NULL to let the caller know there was a failure.
      Move the call to alloc_ordered_workqueue higher in the function in order
      to abort earlier without needing to unwind the call to device_initialize().
      
      Cc: Ursula Braun <ubraun@linux.ibm.com>
      Cc: David S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarAnirudh Rayabharam <mail@anirudhrb.com>
      Link: https://lore.kernel.org/r/20210503115736.2104747-18-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      bbeb18f2
    • Greg Kroah-Hartman's avatar
      Revert "net/smc: fix a NULL pointer dereference" · 5369ead8
      Greg Kroah-Hartman authored
      This reverts commit e183d4e4
      
      .
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It will be fixed up "correctly" in a
      later kernel change.
      
      The original commit causes a memory leak and does not properly fix the
      issue it claims to fix.  I will send a follow-on patch to resolve this
      properly.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Cc: Ursula Braun <ubraun@linux.ibm.com>
      Cc: David S. Miller <davem@davemloft.net>
      Link: https://lore.kernel.org/r/20210503115736.2104747-17-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5369ead8
    • Anirudh Rayabharam's avatar
      net: fujitsu: fix potential null-ptr-deref · 52202be1
      Anirudh Rayabharam authored
      
      
      In fmvj18x_get_hwinfo(), if ioremap fails there will be NULL pointer
      deref. To fix this, check the return value of ioremap and return -1
      to the caller in case of failure.
      
      Cc: "David S. Miller" <davem@davemloft.net>
      Acked-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      Signed-off-by: default avatarAnirudh Rayabharam <mail@anirudhrb.com>
      Link: https://lore.kernel.org/r/20210503115736.2104747-16-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      52202be1
    • Greg Kroah-Hartman's avatar
      Revert "net: fujitsu: fix a potential NULL pointer dereference" · 5f94eaa4
      Greg Kroah-Hartman authored
      This reverts commit 9f4d6358
      
      .
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It will be fixed up "correctly" in a
      later kernel change.
      
      The original change does not change any behavior as the caller of this
      function onlyu checks for "== -1" as an error condition so this error is
      not handled properly.  Remove this change and it will be fixed up
      properly in a later commit.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Cc: David S. Miller <davem@davemloft.net>
      Reviewed-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      Link: https://lore.kernel.org/r/20210503115736.2104747-15-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5f94eaa4
    • Greg Kroah-Hartman's avatar
      net: rtlwifi: properly check for alloc_workqueue() failure · 30b0e0ee
      Greg Kroah-Hartman authored
      
      
      If alloc_workqueue() fails, properly catch this and propagate the error
      to the calling functions, so that the devuce initialization will
      properly error out.
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: Bryan Brattlof <hello@bryanbrattlof.com>
      Cc: stable <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20210503115736.2104747-14-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      30b0e0ee
    • Greg Kroah-Hartman's avatar
      Revert "rtlwifi: fix a potential NULL pointer dereference" · 68c5634c
      Greg Kroah-Hartman authored
      This reverts commit 76597628.
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It will be fixed up "correctly" in a
      later kernel change.
      
      This commit is not correct, it should not have used unlikely() and is
      not propagating the error properly to the calling function, so it should
      be reverted at this point in time.  Also, if the check failed, the
      work queue was still assumed to be allocated, so further accesses would
      have continued to fail, meaning this patch does nothing to solve the
      root issues at all.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: Bryan Brattlof <hello@bryanbrattlof.com>
      Fixes: 76597628
      
       ("rtlwifi: fix a potential NULL pointer dereference")
      Cc: stable <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20210503115736.2104747-13-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      68c5634c
    • Atul Gopinathan's avatar
      serial: max310x: unregister uart driver in case of failure and abort · 3890e3de
      Atul Gopinathan authored
      
      
      The macro "spi_register_driver" invokes the function
      "__spi_register_driver()" which has a return type of int and can fail,
      returning a negative value in such a case. This is currently ignored and
      the init() function yields success even if the spi driver failed to
      register.
      
      Fix this by collecting the return value of "__spi_register_driver()" and
      also unregister the uart driver in case of failure.
      
      Cc: Jiri Slaby <jirislaby@kernel.org>
      Signed-off-by: default avatarAtul Gopinathan <atulgopinathan@gmail.com>
      Link: https://lore.kernel.org/r/20210503115736.2104747-12-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      3890e3de
    • Greg Kroah-Hartman's avatar
      Revert "serial: max310x: pass return value of spi_register_driver" · b0a85abb
      Greg Kroah-Hartman authored
      This reverts commit 51f689cc
      
      .
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It will be fixed up "correctly" in a
      later kernel change.
      
      This change did not properly unwind from the error condition, so it was
      not correct.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Acked-by: default avatarJiri Slaby <jirislaby@kernel.org>
      Link: https://lore.kernel.org/r/20210503115736.2104747-11-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b0a85abb
    • Phillip Potter's avatar
      leds: lp5523: check return value of lp5xx_read and jump to cleanup code · 6647f7a0
      Phillip Potter authored
      Check return value of lp5xx_read and if non-zero, jump to code at end of
      the function, causing lp5523_stop_all_engines to be executed before
      returning the error value up the call chain. This fixes the original
      commit (248b5701
      
      ) which was reverted due to the University of Minnesota
      problems.
      
      Cc: stable <stable@vger.kernel.org>
      Acked-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
      Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
      Link: https://lore.kernel.org/r/20210503115736.2104747-10-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6647f7a0
    • Greg Kroah-Hartman's avatar
      Revert "leds: lp5523: fix a missing check of return value of lp55xx_read" · 8d1beda5
      Greg Kroah-Hartman authored
      This reverts commit 248b5701.
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It will be fixed up "correctly" in a
      later kernel change.
      
      The original commit does not properly unwind if there is an error
      condition so it needs to be reverted at this point in time.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
      Cc: stable <stable@vger.kernel.org>
      Fixes: 248b5701
      
       ("leds: lp5523: fix a missing check of return value of lp55xx_read")
      Link: https://lore.kernel.org/r/20210503115736.2104747-9-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8d1beda5
    • Greg Kroah-Hartman's avatar
      Revert "ALSA: sb: fix a missing check of snd_ctl_add" · 4b059ce1
      Greg Kroah-Hartman authored
      This reverts commit beae7717
      
      .
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be incorrect for the reasons
      below, so it must be reverted.  It is safe to ignore this error as the
      mixer element is optional, and the driver is very legacy.
      
      Cc: Aditya Pakki <pakki001@umn.edu>
      Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
      Link: https://lore.kernel.org/r/20210503115736.2104747-8-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4b059ce1
    • Greg Kroah-Hartman's avatar
      Revert "media: usb: gspca: add a missed check for goto_low_power" · fd013265
      Greg Kroah-Hartman authored
      This reverts commit 5b711870
      
      .
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to do does nothing useful as a user
      can do nothing with this information and if an error did happen, the
      code would continue on as before.  Because of this, just revert it.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
      Link: https://lore.kernel.org/r/20210503115736.2104747-7-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      fd013265
    • Greg Kroah-Hartman's avatar
      Revert "serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference" · 754f3915
      Greg Kroah-Hartman authored
      This reverts commit 32f47179.
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, this commit was found to be not be needed at all as the
      change was useless because this function can only be called when
      of_match_device matched on something.  So it should be reverted.
      
      Cc: Aditya Pakki <pakki001@umn.edu>
      Cc: stable <stable@vger.kernel.org>
      Fixes: 32f47179
      
       ("serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference")
      Acked-by: default avatarJiri Slaby <jirislaby@kernel.org>
      Link: https://lore.kernel.org/r/20210503115736.2104747-6-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      754f3915
    • Greg Kroah-Hartman's avatar
      Revert "hwmon: (lm80) fix a missing check of bus read in lm80 probe" · 99ae3417
      Greg Kroah-Hartman authored
      This reverts commit 9aa3aa15.
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, it was determined that this commit is not needed at all so
      just revert it.  Also, the call to lm80_init_client() was not properly
      handled, so if error handling is needed in the lm80_probe() function,
      then it should be done properly, not half-baked like the commit being
      reverted here did.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Fixes: 9aa3aa15
      
       ("hwmon: (lm80) fix a missing check of bus read in lm80 probe")
      Cc: stable <stable@vger.kernel.org>
      Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Link: https://lore.kernel.org/r/20210503115736.2104747-5-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      99ae3417
    • Greg Kroah-Hartman's avatar
      Revert "media: rcar_drif: fix a memory disclosure" · 3e465fc3
      Greg Kroah-Hartman authored
      This reverts commit d3908323.
      
      Because of recent interactions with developers from @umn.edu, all
      commits from them have been recently re-reviewed to ensure if they were
      correct or not.
      
      Upon review, it was determined that this commit is not needed at all as
      the media core already prevents memory disclosure on this codepath, so
      just drop the extra memset happening here.
      
      Cc: Kangjie Lu <kjlu@umn.edu>
      Cc: Geert Uytterhoeven <geert+renesas@glider.be>
      Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
      Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
      Fixes: d3908323
      
       ("media: rcar_drif: fix a memory disclosure")
      Cc: stable <stable@vger.kernel.org>
      Reviewed-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      Reviewed-by: default avatarFabrizio Castro <fabrizio.castro.jz@renesas.com>
      Link: https://lore.kernel.org/r/20210503115736.2104747-4-gregkh@linuxfoundation.org
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      3e465fc3
    • Greg Kroah-Hartman's avatar
      Revert "crypto: cavium/nitrox - add an error message to explain the failure of... · 6a3239a7
      Greg Kroah-Hartman authored
      Revert "crypto: cavium/nitrox - add an error message to explain the failure of pci_request_mem_regions"
      
      This reverts commit 9fcddaf2
      
       as it was
      submitted under a fake name and we can not knowingly accept anonymous
      contributions to the repository.
      
      This commit was part of a submission "test" to the Linux kernel
      community by some "researchers" at umn.edu.  As outlined at:
      	https://www-users.cs.umn.edu/%7Ekjlu/papers/full-disclosure.pdf
      it was done so as an attempt to submit a known-buggy patch to see if it
      could get by our review.  However, the submission turned out to actually
      be correct, and not have a bug in it as the author did not understand
      how the PCI driver model works at all, and so the submission was
      accepted.
      
      As this change is of useless consequence, there is no loss of
      functionality in reverting it.
      
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
      Cc: linux-crypto@vger.kernel.org
      Acked-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Email: Herbert Xu <herbert@gondor.apana.org.au>
      Link: https://lore.kernel.org/r/YIkTi9a3nnL50wMq@kroah.com
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6a3239a7
    • Darrick J. Wong's avatar
      ics932s401: fix broken handling of errors when word reading fails · a73b6a3b
      Darrick J. Wong authored
      In commit b05ae01f, someone tried to make the driver handle i2c read
      errors by simply zeroing out the register contents, but for some reason
      left unaltered the code that sets the cached register value the function
      call return value.
      
      The original patch was authored by a member of the Underhanded
      Mangle-happy Nerds, I'm not terribly surprised.  I don't have the
      hardware anymore so I can't test this, but it seems like a pretty
      obvious API usage fix to me...
      
      Fixes: b05ae01f
      
       ("misc/ics932s401: Add a missing check to i2c_smbus_read_word_data")
      Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
      Link: https://lore.kernel.org/r/20210428222534.GJ3122264@magnolia
      Cc: stable <stable@vger.kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      a73b6a3b
  2. May 10, 2021
    • Greg Kroah-Hartman's avatar
      Merge tag 'misc-habanalabs-fixes-2021-05-08' of... · ba2b062f
      Greg Kroah-Hartman authored
      Merge tag 'misc-habanalabs-fixes-2021-05-08' of https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux into char-misc-linus
      
      Oded writes:
      
      This tag contains the following fixes for 5.13-rc2:
      
      - Expose PLL information per ASIC. This also fixes some casting warnings.
      - Skip reading further firmware errors in case PCI link is down.
      - Security firmware error should be handled as error and not warning.
      - Allow user to ignore firmware errors.
      - Fix bug in timeout calculation when waiting for interrupt of CS.
      - Fix bug of potential use-after-free.
      
      * tag 'misc-habanalabs-fixes-2021-05-08' of https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux:
        habanalabs/gaudi: Fix a potential use after free in gaudi_memset_device_memory
        habanalabs: wait for interrupt wrong timeout calculation
        habanalabs: ignore f/w status error
        habanalabs: change error level of security not ready
        habanalabs: skip reading f/w errors on bad status
        habanalabs: expose ASIC specific PLL index
      ba2b062f
    • Linus Torvalds's avatar
      Linux 5.13-rc1 · 6efb943b
      Linus Torvalds authored
      v5.13-rc1
      6efb943b
    • Linus Torvalds's avatar
      fbmem: fix horribly incorrect placement of __maybe_unused · 6dae40ae
      Linus Torvalds authored
      Commit b9d79e4c
      
       ("fbmem: Mark proc_fb_seq_ops as __maybe_unused")
      places the '__maybe_unused' in an entirely incorrect location between
      the "struct" keyword and the structure name.
      
      It's a wonder that gcc accepts that silently, but clang quite reasonably
      warns about it:
      
          drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute declaration must precede definition [-Wignored-attributes]
          static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
                              ^
      
      Fix it.
      
      Cc: Guenter Roeck <linux@roeck-us.net>
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      6dae40ae
    • Linus Torvalds's avatar
      Merge tag 'drm-next-2021-05-10' of git://anongit.freedesktop.org/drm/drm · efc58a96
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Bit later than usual, I queued them all up on Friday then promptly
        forgot to write the pull request email. This is mainly amdgpu fixes,
        with some radeon/msm/fbdev and one i915 gvt fix thrown in.
      
        amdgpu:
         - MPO hang workaround
         - Fix for concurrent VM flushes on vega/navi
         - dcefclk is not adjustable on navi1x and newer
         - MST HPD debugfs fix
         - Suspend/resumes fixes
         - Register VGA clients late in case driver fails to load
         - Fix GEM leak in user framebuffer create
         - Add support for polaris12 with 32 bit memory interface
         - Fix duplicate cursor issue when using overlay
         - Fix corruption with tiled surfaces on VCN3
         - Add BO size and stride check to fix BO size verification
      
        radeon:
         - Fix off-by-one in power state parsing
         - Fix possible memory leak in power state parsing
      
        msm:
         - NULL ptr dereference fix
      
        fbdev:
         - procfs disabled warning fix
      
        i915:
         - gvt: Fix a possible division by zero in vgpu display rate
           calculation"
      
      * tag 'drm-next-2021-05-10' of git://anongit.freedesktop.org/drm/drm:
        drm/amdgpu: Use device specific BO size & stride check.
        drm/amdgpu: Init GFX10_ADDR_CONFIG for VCN v3 in DPG mode.
        drm/amd/pm: initialize variable
        drm/radeon: Avoid power table parsing memory leaks
        drm/radeon: Fix off-by-one power_state index heap overwrite
        drm/amd/display: Fix two cursor duplication when using overlay
        drm/amdgpu: add new MC firmware for Polaris12 32bit ASIC
        fbmem: Mark proc_fb_seq_ops as __maybe_unused
        drm/msm/dpu: Delete bonkers code
        drm/i915/gvt: Prevent divided by zero when calculating refresh rate
        amdgpu: fix GEM obj leak in amdgpu_display_user_framebuffer_create
        drm/amdgpu: Register VGA clients after init can no longer fail
        drm/amdgpu: Handling of amdgpu_device_resume return value for graceful teardown
        drm/amdgpu: fix r initial values
        drm/amd/display: fix wrong statement in mst hpd debugfs
        amdgpu/pm: set pp_dpm_dcefclk to readonly on NAVI10 and newer gpus
        amdgpu/pm: Prevent force of DCEFCLK on NAVI10 and SIENNA_CICHLID
        drm/amdgpu: fix concurrent VM flushes on Vega/Navi v2
        drm/amd/display: Reject non-zero src_y and src_x for video planes
      efc58a96
    • Linus Torvalds's avatar
      Merge tag 'block-5.13-2021-05-09' of git://git.kernel.dk/linux-block · 506c3079
      Linus Torvalds authored
      Pull block fix from Jens Axboe:
       "Turns out the bio max size change still has issues, so let's get it
        reverted for 5.13-rc1. We'll shake out the issues there and defer it
        to 5.14 instead"
      
      * tag 'block-5.13-2021-05-09' of git://git.kernel.dk/linux-block:
        Revert "bio: limit bio max size"
      506c3079
    • Linus Torvalds's avatar
      Merge tag '5.13-rc-smb3-part3' of git://git.samba.org/sfrench/cifs-2.6 · 0a55a1fb
      Linus Torvalds authored
      Pull cifs fixes from Steve French:
       "Three small SMB3 chmultichannel related changesets (also for stable)
        from the SMB3 test event this week.
      
        The other fixes are still in review/testing"
      
      * tag '5.13-rc-smb3-part3' of git://git.samba.org/sfrench/cifs-2.6:
        smb3: if max_channels set to more than one channel request multichannel
        smb3: do not attempt multichannel to server which does not support it
        smb3: when mounting with multichannel include it in requested capabilities
      0a55a1fb
    • Linus Torvalds's avatar
      Merge tag 'sched-urgent-2021-05-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 9819f682
      Linus Torvalds authored
      Pull scheduler fixes from Thomas Gleixner:
       "A set of scheduler updates:
      
         - Prevent PSI state corruption when schedule() races with cgroup
           move.
      
           A recent commit combined two PSI callbacks to reduce the number of
           cgroup tree updates, but missed that schedule() can drop rq::lock
           for load balancing, which opens the race window for
           cgroup_move_task() which then observes half updated state.
      
           The fix is to solely use task::ps_flags instead of looking at the
           potentially mismatching scheduler state
      
         - Prevent an out-of-bounds access in uclamp caused bu a rounding
           division which can lead to an off-by-one error exceeding the
           buckets array size.
      
         - Prevent unfairness caused by missing load decay when a task is
           attached to a cfs runqueue.
      
           The old load of the task was attached to the runqueue and never
           removed. Fix it by enforcing the load update through the hierarchy
           for unthrottled run queue instances.
      
         - A documentation fix fot the 'sched_verbose' command line option"
      
      * tag 'sched-urgent-2021-05-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        sched/fair: Fix unfairness caused by missing load decay
        sched: Fix out-of-bound access in uclamp
        psi: Fix psi state corruption when schedule() races with cgroup move
        sched,doc: sched_debug_verbose cmdline should be sched_verbose
      9819f682
    • Linus Torvalds's avatar
      Merge tag 'locking-urgent-2021-05-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 732a27a0
      Linus Torvalds authored
      Pull locking fixes from Thomas Gleixner:
       "A set of locking related fixes and updates:
      
         - Two fixes for the futex syscall related to the timeout handling.
      
           FUTEX_LOCK_PI does not support the FUTEX_CLOCK_REALTIME bit and
           because it's not set the time namespace adjustment for clock
           MONOTONIC is applied wrongly.
      
           FUTEX_WAIT cannot support the FUTEX_CLOCK_REALTIME bit because its
           always a relative timeout.
      
         - Cleanups in the futex syscall entry points which became obvious
           when the two timeout handling bugs were fixed.
      
         - Cleanup of queued_write_lock_slowpath() as suggested by Linus
      
         - Fixup of the smp_call_function_single_async() prototype"
      
      * tag 'locking-urgent-2021-05-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        futex: Make syscall entry points less convoluted
        futex: Get rid of the val2 conditional dance
        futex: Do not apply time namespace adjustment on FUTEX_LOCK_PI
        Revert 337f1304 ("futex: Allow FUTEX_CLOCK_REALTIME with FUTEX_WAIT op")
        locking/qrwlock: Cleanup queued_write_lock_slowpath()
        smp: Fix smp_call_function_single_async prototype
      732a27a0
    • Linus Torvalds's avatar
      Merge tag 'perf_urgent_for_v5.13_rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 85bbba1c
      Linus Torvalds authored
      Pull x86 perf fix from Borislav Petkov:
       "Handle power-gating of AMD IOMMU perf counters properly when they are
        used"
      
      * tag 'perf_urgent_for_v5.13_rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86/events/amd/iommu: Fix invalid Perf result due to IOMMU PMC power-gating
      85bbba1c
    • Linus Torvalds's avatar
      Merge tag 'x86_urgent_for_v5.13_rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · dd3e4012
      Linus Torvalds authored
      Pull x86 fixes from Borislav Petkov:
       "A bunch of things accumulated for x86 in the last two weeks:
      
         - Fix guest vtime accounting so that ticks happening while the guest
           is running can also be accounted to it. Along with a consolidation
           to the guest-specific context tracking helpers.
      
         - Provide for the host NMI handler running after a VMX VMEXIT to be
           able to run on the kernel stack correctly.
      
         - Initialize MSR_TSC_AUX when RDPID is supported and not RDTSCP (virt
           relevant - real hw supports both)
      
         - A code generation improvement to TASK_SIZE_MAX through the use of
           alternatives
      
         - The usual misc and related cleanups and improvements"
      
      * tag 'x86_urgent_for_v5.13_rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        KVM: x86: Consolidate guest enter/exit logic to common helpers
        context_tracking: KVM: Move guest enter/exit wrappers to KVM's domain
        context_tracking: Consolidate guest enter/exit wrappers
        sched/vtime: Move guest enter/exit vtime accounting to vtime.h
        sched/vtime: Move vtime accounting external declarations above inlines
        KVM: x86: Defer vtime accounting 'til after IRQ handling
        context_tracking: Move guest exit vtime accounting to separate helpers
        context_tracking: Move guest exit context tracking to separate helpers
        KVM/VMX: Invoke NMI non-IST entry instead of IST entry
        x86/cpu: Remove write_tsc() and write_rdtscp_aux() wrappers
        x86/cpu: Initialize MSR_TSC_AUX if RDTSCP *or* RDPID is supported
        x86/resctrl: Fix init const confusion
        x86: Delete UD0, UD1 traces
        x86/smpboot: Remove duplicate includes
        x86/cpu: Use alternative to generate the TASK_SIZE_MAX constant
      dd3e4012
  3. May 09, 2021
    • Jens Axboe's avatar
      Revert "bio: limit bio max size" · 35c820e7
      Jens Axboe authored
      This reverts commit cd2c7545
      
      .
      
      Alex reports that the commit causes corruption with LUKS on ext4. Revert
      it for now so that this can be investigated properly.
      
      Link: https://lore.kernel.org/linux-block/1620493841.bxdq8r5haw.none@localhost/
      Reported-by: default avatarAlex Xu (Hello71) <alex_y_xu@yahoo.ca>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      35c820e7
    • Linus Torvalds's avatar
      Merge tag 'riscv-for-linus-5.13-mw1' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux · b7415964
      Linus Torvalds authored
      Pull RISC-V fixes from Palmer Dabbelt:
      
       - A fix to avoid over-allocating the kernel's mapping on !MMU systems,
         which could lead to up to 2MiB of lost memory
      
       - The SiFive address extension errata only manifest on rv64, they are
         now disabled on rv32 where they are unnecessary
      
       - A pair of late-landing cleanups
      
      * tag 'riscv-for-linus-5.13-mw1' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux:
        riscv: remove unused handle_exception symbol
        riscv: Consistify protect_kernel_linear_mapping_text_rodata() use
        riscv: enable SiFive errata CIP-453 and CIP-1200 Kconfig only if CONFIG_64BIT=y
        riscv: Only extend kernel reservation if mapped read-only
      b7415964
    • Linus Torvalds's avatar
      drm/i915/display: fix compiler warning about array overrun · fec4d427
      Linus Torvalds authored
      
      
      intel_dp_check_mst_status() uses a 14-byte array to read the DPRX Event
      Status Indicator data, but then passes that buffer at offset 10 off as
      an argument to drm_dp_channel_eq_ok().
      
      End result: there are only 4 bytes remaining of the buffer, yet
      drm_dp_channel_eq_ok() wants a 6-byte buffer.  gcc-11 correctly warns
      about this case:
      
        drivers/gpu/drm/i915/display/intel_dp.c: In function ‘intel_dp_check_mst_status’:
        drivers/gpu/drm/i915/display/intel_dp.c:3491:22: warning: ‘drm_dp_channel_eq_ok’ reading 6 bytes from a region of size 4 [-Wstringop-overread]
         3491 |                     !drm_dp_channel_eq_ok(&esi[10], intel_dp->lane_count)) {
              |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        drivers/gpu/drm/i915/display/intel_dp.c:3491:22: note: referencing argument 1 of type ‘const u8 *’ {aka ‘const unsigned char *’}
        In file included from drivers/gpu/drm/i915/display/intel_dp.c:38:
        include/drm/drm_dp_helper.h:1466:6: note: in a call to function ‘drm_dp_channel_eq_ok’
         1466 | bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE],
              |      ^~~~~~~~~~~~~~~~~~~~
             6:14 elapsed
      
      This commit just extends the original array by 2 zero-initialized bytes,
      avoiding the warning.
      
      There may be some underlying bug in here that caused this confusion, but
      this is at least no worse than the existing situation that could use
      random data off the stack.
      
      Cc: Jani Nikula <jani.nikula@intel.com>
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
      Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Cc: Dave Airlie <airlied@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      fec4d427
    • Linus Torvalds's avatar
      Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 07db0563
      Linus Torvalds authored
      Pull more SCSI updates from James Bottomley:
       "This is a set of minor fixes in various drivers (qla2xxx, ufs,
        scsi_debug, lpfc) one doc fix and a fairly large update to the fnic
        driver to remove the open coded iteration functions in favour of the
        scsi provided ones"
      
      * tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: fnic: Use scsi_host_busy_iter() to traverse commands
        scsi: fnic: Kill 'exclude_id' argument to fnic_cleanup_io()
        scsi: scsi_debug: Fix cmd_per_lun, set to max_queue
        scsi: ufs: core: Narrow down fast path in system suspend path
        scsi: ufs: core: Cancel rpm_dev_flush_recheck_work during system suspend
        scsi: ufs: core: Do not put UFS power into LPM if link is broken
        scsi: qla2xxx: Prevent PRLI in target mode
        scsi: qla2xxx: Add marginal path handling support
        scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found
        scsi: ufs: core: Fix a typo in ufs-sysfs.c
        scsi: lpfc: Fix bad memory access during VPD DUMP mailbox command
        scsi: lpfc: Fix DMA virtual address ptr assignment in bsg
        scsi: lpfc: Fix illegal memory access on Abort IOCBs
        scsi: blk-mq: Fix build warning when making htmldocs
      07db0563
    • Linus Torvalds's avatar
      Merge tag 'kbuild-v5.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild · 0f979d81
      Linus Torvalds authored
      Pull more Kbuild updates from Masahiro Yamada:
      
       - Convert sh and sparc to use generic shell scripts to generate the
         syscall headers
      
       - refactor .gitignore files
      
       - Update kernel/config_data.gz only when the content of the .config
         is really changed, which avoids the unneeded re-link of vmlinux
      
       - move "remove stale files" workarounds to scripts/remove-stale-files
      
       - suppress unused-but-set-variable warnings by default for Clang
         as well
      
       - fix locale setting LANG=C to LC_ALL=C
      
       - improve 'make distclean'
      
       - always keep intermediate objects from scripts/link-vmlinux.sh
      
       - move IF_ENABLED out of <linux/kconfig.h> to make it self-contained
      
       - misc cleanups
      
      * tag 'kbuild-v5.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild: (25 commits)
        linux/kconfig.h: replace IF_ENABLED() with PTR_IF() in <linux/kernel.h>
        kbuild: Don't remove link-vmlinux temporary files on exit/signal
        kbuild: remove the unneeded comments for external module builds
        kbuild: make distclean remove tag files in sub-directories
        kbuild: make distclean work against $(objtree) instead of $(srctree)
        kbuild: refactor modname-multi by using suffix-search
        kbuild: refactor fdtoverlay rule
        kbuild: parameterize the .o part of suffix-search
        arch: use cross_compiling to check whether it is a cross build or not
        kbuild: remove ARCH=sh64 support from top Makefile
        .gitignore: prefix local generated files with a slash
        kbuild: replace LANG=C with LC_ALL=C
        Makefile: Move -Wno-unused-but-set-variable out of GCC only block
        kbuild: add a script to remove stale generated files
        kbuild: update config_data.gz only when the content of .config is changed
        .gitignore: ignore only top-level modules.builtin
        .gitignore: move tags and TAGS close to other tag files
        kernel/.gitgnore: remove stale timeconst.h and hz.bc
        usr/include: refactor .gitignore
        genksyms: fix stale comment
        ...
      0f979d81
  4. May 08, 2021
    • Steve French's avatar
      smb3: if max_channels set to more than one channel request multichannel · c1f8a398
      Steve French authored
      
      
      Mounting with "multichannel" is obviously implied if user requested
      more than one channel on mount (ie mount parm max_channels>1).
      Currently both have to be specified. Fix that so that if max_channels
      is greater than 1 on mount, enable multichannel rather than silently
      falling back to non-multichannel.
      
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      Reviewed-By: default avatarTom Talpey <tom@talpey.com>
      Cc: <stable@vger.kernel.org> # v5.11+
      Reviewed-by: default avatarShyam Prasad N <sprasad@microsoft.com>
      c1f8a398
    • Steve French's avatar
      smb3: do not attempt multichannel to server which does not support it · 9c2dc11d
      Steve French authored
      
      
      We were ignoring CAP_MULTI_CHANNEL in the server response - if the
      server doesn't support multichannel we should not be attempting it.
      
      See MS-SMB2 section 3.2.5.2
      
      Reviewed-by: default avatarShyam Prasad N <sprasad@microsoft.com>
      Reviewed-By: default avatarTom Talpey <tom@talpey.com>
      Cc: <stable@vger.kernel.org> # v5.8+
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      9c2dc11d
    • Linus Torvalds's avatar
      Merge tag 'powerpc-5.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux · ab159ac5
      Linus Torvalds authored
      Pull powerpc updates and fixes from Michael Ellerman:
       "A bit of a mixture of things, tying up some loose ends.
      
        There's the removal of the nvlink code, which dependend on a commit in
        the vfio tree. Then the enablement of huge vmalloc which was in next
        for a few weeks but got dropped due to conflicts. And there's also a
        few fixes.
      
        Summary:
      
         - Remove the nvlink support now that it's only user has been removed.
      
         - Enable huge vmalloc mappings for Radix MMU (P9).
      
         - Fix KVM conversion to gfn-based MMU notifier callbacks.
      
         - Fix a kexec/kdump crash with hot plugged CPUs.
      
         - Fix boot failure on 32-bit with CONFIG_STACKPROTECTOR.
      
         - Restore alphabetic order of the selects under CONFIG_PPC.
      
        Thanks to: Christophe Leroy, Christoph Hellwig, Nicholas Piggin,
        Sandipan Das, and Sourabh Jain"
      
      * tag 'powerpc-5.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
        KVM: PPC: Book3S HV: Fix conversion to gfn-based MMU notifier callbacks
        powerpc/kconfig: Restore alphabetic order of the selects under CONFIG_PPC
        powerpc/32: Fix boot failure with CONFIG_STACKPROTECTOR
        powerpc/powernv/memtrace: Fix dcache flushing
        powerpc/kexec_file: Use current CPU info while setting up FDT
        powerpc/64s/radix: Enable huge vmalloc mappings
        powerpc/powernv: remove the nvlink support
      ab159ac5