Skip to content
  1. Jan 28, 2021
  2. Jan 27, 2021
  3. Jan 24, 2021
    • Simon Ser's avatar
      drm/doc: document the type plane property · 97ecfff4
      Simon Ser authored
      
      
      Add a new entry for "type" in the section for standard plane properties.
      
      v3: improve paragraph about mixing legacy IOCTLs with explicit usage,
      note that a driver may support cursors without cursor planes (Daniel)
      
      v4: fixing rebase gone wrong
      
      v5:
      - Fix typo (Daniel)
      - Mention CAP_ATOMIC instead of CAP_UNIVERSAL_PLANES when referring to
        atomic test-only commits (Daniel)
      - Add newlines at end of sections (Daniel)
      
      Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
      Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Reviewed-by: default avatarPekka Paalanen <pekka.paalanen@collabora.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115110626.12233-2-contact@emersion.fr
      97ecfff4
    • Simon Ser's avatar
      drm/doc: fix drm_plane_type docs · 7e5d1e12
      Simon Ser authored
      
      
      The docs for enum drm_plane_type mention legacy IOCTLs, however the
      plane type is not tied to legacy IOCTLs, the drm_cursor.primary and
      cursor fields are. Add a small paragraph to reference these.
      
      Instead, document expectations for primary and cursor planes for
      non-legacy userspace. Note that these docs are for driver developers,
      not userspace developers, so internal kernel APIs are mentionned.
      
      Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
      Reviewed-by: default avatarDaniel Vetter <daniel@ffwll.ch>
      Acked-by: default avatarPekka Paalanen <pekka.paalanen@collabora.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115110626.12233-1-contact@emersion.fr
      7e5d1e12
  4. Jan 22, 2021
    • Marek Vasut's avatar
      dt-bindings: display: mxsfb: Add compatible for i.MX8MM · 25e524bf
      Marek Vasut authored
      
      
      NXP's i.MX8MM has an LCDIF as well.
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115222304.5427-4-laurent.pinchart@ideasonboard.com
      25e524bf
    • Laurent Pinchart's avatar
      dt-bindings: display: mxsfb: Add and fix compatible strings · 5d16e40d
      Laurent Pinchart authored
      
      
      Additional compatible strings have been added in DT source for the
      i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings.
      Most of the upstream DT sources use the fsl,imx28-lcdif compatible
      string, which mostly predates the realization that the LCDIF in the
      i.MX6 and newer SoCs have extra features compared to the i.MX28.
      
      Update the bindings to add the missing compatible strings, with the
      correct fallback values. This fails to validate some of the upstream DT
      sources. Instead of adding the incorrect compatible fallback to the
      binding, the sources should be updated separately.
      
      Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Reviewed-by: default avatarRob Herring <robh@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115222304.5427-3-laurent.pinchart@ideasonboard.com
      5d16e40d
    • Laurent Pinchart's avatar
      dt-bindings: display: mxsfb: Convert binding to YAML · 3b1b42fd
      Laurent Pinchart authored
      
      
      Convert the mxsfb binding to YAML. The deprecated binding is dropped, as
      neither the DT sources nor the driver support it anymore. The converted
      binding is named fsl,lcdif.yaml to match the usual bindings naming
      scheme.
      
      The compatible strings are messy, and DT sources use different kinds of
      combination of documented and undocumented values. Keep it simple for
      now, and update the example to make it valid. Aligning the binding with
      the existing DT sources will be performed separately.
      
      Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Reviewed-by: default avatarRob Herring <robh@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115222304.5427-2-laurent.pinchart@ideasonboard.com
      3b1b42fd
    • Lukasz Luba's avatar
      drm/panfrost: Add governor data with pre-defined thresholds · 1f8644d5
      Lukasz Luba authored
      
      
      The simple_ondemand devfreq governor uses two thresholds to decide about
      the frequency change: upthreshold, downdifferential. These two tunable
      change the behavior of the governor decision, e.g. how fast to increase
      the frequency or how rapidly limit the frequency. This patch adds needed
      governor data with thresholds values gathered experimentally in different
      workloads.
      
      Signed-off-by: default avatarLukasz Luba <lukasz.luba@arm.com>
      Reviewed-by: default avatarSteven Price <steven.price@arm.com>
      Signed-off-by: default avatarSteven Price <steven.price@arm.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210121170445.19761-1-lukasz.luba@arm.com
      1f8644d5
    • Veera Sundaram Sankaran's avatar
      drm/drm_vblank: set the dma-fence timestamp during send_vblank_event · a78e7a51
      Veera Sundaram Sankaran authored
      
      
      The explicit out-fences in crtc are signaled as part of vblank event,
      indicating all framebuffers present on the Atomic Commit request are
      scanned out on the screen. Though the fence signal and the vblank event
      notification happens at the same time, triggered by the same hardware
      vsync event, the timestamp set in both are different. With drivers
      supporting precise vblank timestamp the difference between the two
      timestamps would be even higher. This might have an impact on use-mode
      frameworks using these fence timestamps for purposes other than simple
      buffer usage. For instance, the Android framework [1] uses the
      retire-fences as an alternative to vblank when frame-updates are in
      progress. Set the fence timestamp during send vblank event using a new
      drm_send_event_timestamp_locked variant to avoid discrepancies.
      
      [1] https://android.googlesource.com/platform/frameworks/native/+/master/
      services/surfaceflinger/Scheduler/Scheduler.cpp#397
      
      Changes in v2:
      - Use drm_send_event_timestamp_locked to update fence timestamp
      - add more information to commit text
      
      Changes in v3:
      - use same backend helper function for variants of drm_send_event to
      avoid code duplications
      
      Changes in v4:
      - remove WARN_ON from drm_send_event_timestamp_locked
      
      Signed-off-by: default avatarVeera Sundaram Sankaran <veeras@codeaurora.org>
      Reviewed-by: default avatarJohn Stultz <john.stultz@linaro.org>
      Signed-off-by: default avatarSumit Semwal <sumit.semwal@linaro.org>
        [sumits: minor parenthesis alignment correction]
      Link: https://patchwork.freedesktop.org/patch/msgid/1610757107-11892-2-git-send-email-veeras@codeaurora.org
      a78e7a51
    • Veera Sundaram Sankaran's avatar
      dma-fence: allow signaling drivers to set fence timestamp · 5a164ac4
      Veera Sundaram Sankaran authored
      
      
      Some drivers have hardware capability to get the precise HW timestamp
      of certain events based on which the fences are triggered. The delta
      between the event HW timestamp & current HW reference timestamp can
      be used to calculate the timestamp in kernel's CLOCK_MONOTONIC time
      domain. This allows it to set accurate timestamp factoring out any
      software and IRQ latencies. Add a timestamp variant of fence signal
      function, dma_fence_signal_timestamp to allow drivers to update the
      precise timestamp for fences.
      
      Changes in v2:
      - Add a new fence signal variant instead of modifying fence struct
      
      Changes in v3:
      - Add timestamp domain information to commit-text and
      dma_fence_signal_timestamp documentation
      
      Signed-off-by: default avatarVeera Sundaram Sankaran <veeras@codeaurora.org>
      Reviewed-by: default avatarJohn Stultz <john.stultz@linaro.org>
      Signed-off-by: default avatarSumit Semwal <sumit.semwal@linaro.org>
       [sumits: minor parenthesis alignment]
      Link: https://patchwork.freedesktop.org/patch/msgid/1610757107-11892-1-git-send-email-veeras@codeaurora.org
      5a164ac4
    • John Stultz's avatar
      dma-buf: heaps: Rework heap allocation hooks to return struct dma_buf instead of fd · c7f59e3d
      John Stultz authored
      
      
      Every heap needs to create a dmabuf and then export it to a fd
      via dma_buf_fd(), so to consolidate things a bit, have the heaps
      just return a struct dmabuf * and let the top level
      dma_heap_buffer_alloc() call handle creating the fd via
      dma_buf_fd().
      
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: Liam Mark <lmark@codeaurora.org>
      Cc: Laura Abbott <labbott@kernel.org>
      Cc: Brian Starkey <Brian.Starkey@arm.com>
      Cc: Hridya Valsaraju <hridya@google.com>
      Cc: Suren Baghdasaryan <surenb@google.com>
      Cc: Sandeep Patil <sspatil@google.com>
      Cc: Daniel Mentz <danielmentz@google.com>
      Cc: Chris Goldsworthy <cgoldswo@codeaurora.org>
      Cc: Ørjan Eide <orjan.eide@arm.com>
      Cc: Robin Murphy <robin.murphy@arm.com>
      Cc: Ezequiel Garcia <ezequiel@collabora.com>
      Cc: Simon Ser <contact@emersion.fr>
      Cc: James Jones <jajones@nvidia.com>
      Cc: linux-media@vger.kernel.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
      Signed-off-by: default avatarSumit Semwal <sumit.semwal@linaro.org>
       [sumits: minor reword of commit message]
      
      Link: https://patchwork.freedesktop.org/patch/msgid/20210119204508.9256-3-john.stultz@linaro.org
      c7f59e3d
    • John Stultz's avatar
      dma-buf: system_heap: Make sure to return an error if we abort · 14a11725
      John Stultz authored
      
      
      If we abort from the allocation due to a fatal_signal_pending(),
      be sure we report an error so any return code paths don't trip
      over the fact that the allocation didn't succeed.
      
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: Liam Mark <lmark@codeaurora.org>
      Cc: Laura Abbott <labbott@kernel.org>
      Cc: Brian Starkey <Brian.Starkey@arm.com>
      Cc: Hridya Valsaraju <hridya@google.com>
      Cc: Suren Baghdasaryan <surenb@google.com>
      Cc: Sandeep Patil <sspatil@google.com>
      Cc: Daniel Mentz <danielmentz@google.com>
      Cc: Chris Goldsworthy <cgoldswo@codeaurora.org>
      Cc: Ørjan Eide <orjan.eide@arm.com>
      Cc: Robin Murphy <robin.murphy@arm.com>
      Cc: Ezequiel Garcia <ezequiel@collabora.com>
      Cc: Simon Ser <contact@emersion.fr>
      Cc: James Jones <jajones@nvidia.com>
      Cc: linux-media@vger.kernel.org
      Cc: dri-devel@lists.freedesktop.org
      Suggested-by: default avatarSuren Baghdasaryan <surenb@google.com>
      Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
      Signed-off-by: default avatarSumit Semwal <sumit.semwal@linaro.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210119204508.9256-1-john.stultz@linaro.org
      14a11725
  5. Jan 21, 2021
  6. Jan 20, 2021
    • Christian König's avatar
      drm/syncobj: make lockdep complain on WAIT_FOR_SUBMIT v3 · 7621350c
      Christian König authored
      
      
      DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT can't be used when we hold locks
      since we are basically waiting for userspace to do something.
      
      Holding a lock while doing so can trivial deadlock with page faults
      etc...
      
      So make lockdep complain when a driver tries to do this.
      
      v2: Add lockdep_assert_none_held() macro.
      v3: Add might_sleep() and also use lockdep_assert_none_held() in the
          IOCTL path.
      
      Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
      Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
      Link: https://patchwork.freedesktop.org/patch/414944/
      7621350c
    • Christian König's avatar
      drm/ttm: optimize ttm pool shrinker a bit · f987c9e0
      Christian König authored
      
      
      Only initialize the DMA coherent pools if they are used.
      
      Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
      Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: https://patchwork.freedesktop.org/patch/414957/
      f987c9e0
    • Christian König's avatar
      drm/ttm: add debugfs entry to test pool shrinker v2 · 56851768
      Christian König authored
      
      
      Useful for testing.
      
      v2: add fs_reclaim_acquire()/_release()
      
      Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
      Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: https://patchwork.freedesktop.org/patch/414955/
      56851768
    • Christian König's avatar
      drm/ttm: add a debugfs file for the global page pools · ba051901
      Christian König authored
      
      
      Instead of printing this on the per device pool.
      
      Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
      Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: https://patchwork.freedesktop.org/patch/414956/
      ba051901
    • Christian König's avatar
      drm/ttm: add debugfs directory v2 · 3763d635
      Christian König authored
      
      
      As far as I can tell the buffer_count was never used by an
      userspace application.
      
      The number of BOs in the system is far better suited in
      debugfs than sysfs and we now should be able to add other
      information here as well.
      
      v2: add that additionally to sysfs
      
      Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
      Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: https://patchwork.freedesktop.org/patch/414954/
      3763d635
    • Lauri Kasanen's avatar
      video: fbdev: simplefb: Add "r5g5b5a1" mode · e1827807
      Lauri Kasanen authored
      
      
      Add "r5g5b5a1" which is used on the N64.
      
      Signed-off-by: default avatarLauri Kasanen <cand@gmx.com>
      Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115160102.cf4c85db9f815758716f086f@gmx.com
      e1827807
    • Peter Robinson's avatar
      video: fbdev: simplefb: Fix info message during probe · 5269a618
      Peter Robinson authored
      
      
      The info message was showing the mapped address for the framebuffer. To avoid
      security problems, all virtual addresses are converted to __ptrval__, so
      the message has pointless information:
      
      simple-framebuffer 3ea9b000.framebuffer: framebuffer at 0x3ea9b000, 0x12c000 bytes, mapped to 0x(____ptrval____)
      
      Drop the extraneous bits to clean up the message:
      
      simple-framebuffer 3ea9b000.framebuffer: framebuffer at 0x3ea9b000, 0x12c000 bytes
      
      Signed-off-by: default avatarPeter Robinson <pbrobinson@gmail.com>
      Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20201228183934.1117012-1-pbrobinson@gmail.com
      5269a618
    • Lee Jones's avatar
      drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct · d1441394
      Lee Jones authored
      
      
      Also add missing description for 'refcount'
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union!
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: Dave Airlie <airlied@redhat.com>
      Cc: Rob Clark <rob.clark@linaro.org>
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-media@vger.kernel.org
      Cc: linaro-mm-sig@lists.linaro.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-30-lee.jones@linaro.org
      d1441394
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member 'manager' · 0283c74d
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_thp.c:21: warning: Function parameter or member 'manager' not described in 'vmw_thp_manager'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-11-lee.jones@linaro.org
      0283c74d
    • Lee Jones's avatar
      drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another · f322f32a
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union!
       drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'mem_glob' not described in 'ttm_object_device'
       drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'ops' not described in 'ttm_object_device'
       drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'dmabuf_release' not described in 'ttm_object_device'
       drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'dma_buf_size' not described in 'ttm_object_device'
       drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'idr' not described in 'ttm_object_device'
       drivers/gpu/drm/vmwgfx/ttm_object.c:128: warning: Function parameter or member 'rcu_head' not described in 'ttm_ref_object'
       drivers/gpu/drm/vmwgfx/ttm_object.c:128: warning: Function parameter or member 'tfile' not described in 'ttm_ref_object'
       drivers/gpu/drm/vmwgfx/ttm_object.c:582: warning: Function parameter or member 'dmabuf' not described in 'get_dma_buf_unless_doomed'
       drivers/gpu/drm/vmwgfx/ttm_object.c:582: warning: Excess function parameter 'dma_buf' description in 'get_dma_buf_unless_doomed'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: Sumit Semwal <sumit.semwal@linaro.org>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: Dave Airlie <airlied@redhat.com>
      Cc: Rob Clark <rob.clark@linaro.org>
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-media@vger.kernel.org
      Cc: linaro-mm-sig@lists.linaro.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-10-lee.jones@linaro.org
      f322f32a
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions · dc03b634
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty' not described in 'vmw_validation_res_node'
       drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty_set' not described in 'vmw_validation_res_node'
       drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Function parameter or member 'res' not described in 'vmw_validation_find_res_dup'
       drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Excess function parameter 'vbo' description in 'vmw_validation_find_res_dup'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-9-lee.jones@linaro.org
      dc03b634
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff' param · 9983a31d
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:452: warning: Function parameter or member 'diff' not described in 'vmw_bo_cpu_blit'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-8-lee.jones@linaro.org
      9983a31d
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg' · 7db8a4eb
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:261: warning: Function parameter or member 'msg' not described in 'vmw_send_msg'
       drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:261: warning: Excess function parameter 'logmsg' description in 'vmw_send_msg'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-6-lee.jones@linaro.org
      7db8a4eb
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and remove others · e8fb41ac
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'shader_slot' not described in 'vmw_binding_add'
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'slot' not described in 'vmw_binding_add'
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:376: warning: Function parameter or member 'from' not described in 'vmw_binding_transfer'
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Function parameter or member 'to' not described in 'vmw_binding_state_commit'
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Excess function parameter 'ctx' description in 'vmw_binding_state_commit'
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Excess function parameter 'scrubbed' description in 'vmw_binding_state_commit'
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:520: warning: Function parameter or member 'cbs' not described in 'vmw_binding_rebind_all'
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:520: warning: Excess function parameter 'ctx' description in 'vmw_binding_rebind_all'
       drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:795: warning: Function parameter or member 'shader_slot' not described in 'vmw_emit_set_sr'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-5-lee.jones@linaro.org
      e8fb41ac
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member · a5434770
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_so.c:73: warning: Function parameter or member 'rcu' not described in 'vmw_view'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-4-lee.jones@linaro.org
      a5434770
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems · 3894709e
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:72: warning: Function parameter or member 'unbind_func' not described in 'vmw_cotable_info'
       drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:308: warning: Function parameter or member 'val_buf' not described in 'vmw_cotable_unbind'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-3-lee.jones@linaro.org
      3894709e
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural · 94dda6ad
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:137: warning: Function parameter or member 'headers' not described in 'vmw_cmdbuf_man'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-2-lee.jones@linaro.org
      94dda6ad
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions · 1856a916
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:77: warning: Function parameter or member 'pitch' not described in 'vmw_stdu_dirty'
       drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'content_fb_type' not described in 'vmw_screen_target_display_unit'
       drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'display_width' not described in 'vmw_screen_target_display_unit'
       drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'display_height' not described in 'vmw_screen_target_display_unit'
       drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'cpp' not described in 'vmw_screen_target_display_unit'
       drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:682: warning: Function parameter or member 'user_fence_rep' not described in 'vmw_kms_stdu_dma'
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-41-lee.jones@linaro.org
      1856a916
    • Lee Jones's avatar
      drm/vmwgfx/vmwgfx_cmdbuf_res: Remove unused variable 'ret' · 43ebfe61
      Lee Jones authored
      
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c: In function ‘vmw_cmdbuf_res_revert’:
       drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:162:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
      
      Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
      Cc: Roland Scheidegger <sroland@vmware.com>
      Cc: Zack Rusin <zackr@vmware.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-40-lee.jones@linaro.org
      43ebfe61