Skip to content
  1. Jun 17, 2023
    • Namjae Jeon's avatar
      ksmbd: add mnt_want_write to ksmbd vfs functions · 40b268d3
      Namjae Jeon authored
      
      
      ksmbd is doing write access using vfs helpers. There are the cases that
      mnt_want_write() is not called in vfs helper. This patch add missing
      mnt_want_write() to ksmbd vfs functions.
      
      Cc: stable@vger.kernel.org
      Cc: Amir Goldstein <amir73il@gmail.com>
      Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      40b268d3
    • Namjae Jeon's avatar
      ksmbd: validate command payload size · 2b9b8f3b
      Namjae Jeon authored
      
      
      ->StructureSize2 indicates command payload size. ksmbd should validate
      this size with rfc1002 length before accessing it.
      This patch remove unneeded check and add the validation for this.
      
      [    8.912583] BUG: KASAN: slab-out-of-bounds in ksmbd_smb2_check_message+0x12a/0xc50
      [    8.913051] Read of size 2 at addr ffff88800ac7d92c by task kworker/0:0/7
      ...
      [    8.914967] Call Trace:
      [    8.915126]  <TASK>
      [    8.915267]  dump_stack_lvl+0x33/0x50
      [    8.915506]  print_report+0xcc/0x620
      [    8.916558]  kasan_report+0xae/0xe0
      [    8.917080]  kasan_check_range+0x35/0x1b0
      [    8.917334]  ksmbd_smb2_check_message+0x12a/0xc50
      [    8.917935]  ksmbd_verify_smb_message+0xae/0xd0
      [    8.918223]  handle_ksmbd_work+0x192/0x820
      [    8.918478]  process_one_work+0x419/0x760
      [    8.918727]  worker_thread+0x2a2/0x6f0
      [    8.919222]  kthread+0x187/0x1d0
      [    8.919723]  ret_from_fork+0x1f/0x30
      [    8.919954]  </TASK>
      
      Cc: stable@vger.kernel.org
      Reported-by: default avatarChih-Yen Chang <cc85nod@gmail.com>
      Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      2b9b8f3b
  2. Jun 12, 2023
  3. Jun 11, 2023
    • Linus Torvalds's avatar
      Merge tag 'i2c-for-6.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · 022ce886
      Linus Torvalds authored
      Pull i2c fixes from Wolfram Sang:
       "Biggest news is that Andi Shyti steps in for maintaining the
        controller drivers. Thank you very much!
      
        Other than that, one new driver maintainer and the rest is usual
        driver bugfixes. at24 has a Kconfig dependecy fix"
      
      * tag 'i2c-for-6.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
        MAINTAINERS: Add entries for Renesas RZ/V2M I2C driver
        eeprom: at24: also select REGMAP
        i2c: sprd: Delete i2c adapter in .remove's error path
        i2c: mv64xxx: Fix reading invalid status value in atomic mode
        i2c: designware: fix idx_write_cnt in read loop
        i2c: mchp-pci1xxxx: Avoid cast to incompatible function type
        i2c: img-scb: Fix spelling mistake "innacurate" -> "inaccurate"
        MAINTAINERS: Add myself as I2C host drivers maintainer
      022ce886
    • Linus Torvalds's avatar
      Merge tag 'soundwire-6.4-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire · 6be5e47b
      Linus Torvalds authored
      Pull soundwire fixes from Vinod Koul:
       "Core fix for missing flag clear, error patch handling in qcom driver
        and BIOS quirk for HP Spectre x360:
      
         - HP Spectre x360 soundwire DMI quirk
      
         - Error path handling for qcom driver
      
         - Core fix for missing clear of alloc_slave_rt"
      
      * tag 'soundwire-6.4-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire:
        soundwire: stream: Add missing clear of alloc_slave_rt
        soundwire: qcom: add proper error paths in qcom_swrm_startup()
        soundwire: dmi-quirks: add new mapping for HP Spectre x360
      6be5e47b
    • Linus Torvalds's avatar
      Merge tag 'arm-fixes-6.4-2' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc · 859c7459
      Linus Torvalds authored
      Pull ARM SoC fixes from Arnd Bergmann:
       "Most of the changes this time are for the Qualcomm Snapdragon
        platforms.
      
        There are bug fixes for error handling in Qualcomm icc-bwmon,
        rpmh-rsc, ramp_controller and rmtfs driver as well as the AMD tee
        firmware driver and a missing initialization in the Arm ff-a firmware
        driver. The Qualcomm RPMh and EDAC drivers need some rework to work
        correctly on all supported chips.
      
        The DT fixes include:
      
         - i.MX8 fixes for gpio, pinmux and clock settings
      
         - ADS touchscreen gpio polarity settings in several machines
      
         - Address dtb warnings for caches, panel and input-enable properties
           on Qualcomm platforms
      
         - Incorrect data on qualcomm platforms fir SA8155P power domains,
           SM8550 LLCC, SC7180-lite SDRAM frequencies and SM8550 soundwire
      
         - Remoteproc firmware paths are corrected for Sony Xperia 10 IV"
      
      * tag 'arm-fixes-6.4-2' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc: (36 commits)
        firmware: arm_ffa: Set handle field to zero in memory descriptor
        ARM: dts: Fix erroneous ADS touchscreen polarities
        arm64: dts: imx8mn-beacon: Fix SPI CS pinmux
        arm64: dts: imx8-ss-dma: assign default clock rate for lpuarts
        arm64: dts: imx8qm-mek: correct GPIOs for USDHC2 CD and WP signals
        EDAC/qcom: Get rid of hardcoded register offsets
        EDAC/qcom: Remove superfluous return variable assignment in qcom_llcc_core_setup()
        arm64: dts: qcom: sm8550: Use the correct LLCC register scheme
        dt-bindings: cache: qcom,llcc: Fix SM8550 description
        arm64: dts: qcom: sc7180-lite: Fix SDRAM freq for misidentified sc7180-lite boards
        arm64: dts: qcom: sm8550: use uint16 for Soundwire interval
        soc: qcom: rpmhpd: Add SA8155P power domains
        arm64: dts: qcom: Split out SA8155P and use correct RPMh power domains
        dt-bindings: power: qcom,rpmpd: Add SA8155P
        soc: qcom: Rename ice to qcom_ice to avoid module name conflict
        soc: qcom: rmtfs: Fix error code in probe()
        soc: qcom: ramp_controller: Fix an error handling path in qcom_ramp_controller_probe()
        ARM: dts: at91: sama7g5ek: fix debounce delay property for shdwc
        ARM: at91: pm: fix imbalanced reference counter for ethernet devices
        arm64: dts: qcom: sm6375-pdx225: Fix remoteproc firmware paths
        ...
      859c7459
  4. Jun 10, 2023
  5. Jun 09, 2023
    • Linus Torvalds's avatar
      Merge tag 'sound-6.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · 697fa9b5
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "Lots of small fixes, and almost all are device-specific.
      
        A few of them are the fixes for the old regressions by the fast kctl
        lookups (introduced around 5.19). Others are ASoC simple-card fixes,
        selftest compile warning fixes, ASoC AMD quirks, various ASoC codec
        fixes as well as usual HD-audio quirks"
      
      * tag 'sound-6.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (26 commits)
        ALSA: hda/realtek: Enable 4 amplifiers instead of 2 on a HP platform
        ALSA: hda: Fix kctl->id initialization
        ALSA: gus: Fix kctl->id initialization
        ALSA: cmipci: Fix kctl->id initialization
        ALSA: ymfpci: Fix kctl->id initialization
        ALSA: ice1712,ice1724: fix the kcontrol->id initialization
        ALSA: hda/realtek: Add quirk for Clevo NS50AU
        ALSA: hda/realtek: Add quirks for Asus ROG 2024 laptops using CS35L41
        ALSA: hda/realtek: Add "Intel Reference board" and "NUC 13" SSID in the ALC256
        ALSA: hda/realtek: Add Lenovo P3 Tower platform
        ALSA: hda/realtek: Add a quirk for HP Slim Desktop S01
        selftests: alsa: pcm-test: Fix compiler warnings about the format
        ASoC: fsl_sai: Enable BCI bit if SAI works on synchronous mode with BYP asserted
        ASoC: simple-card-utils: fix PCM constraint error check
        ASoC: cs35l56: Remove NULL check from cs35l56_sdw_dai_set_stream()
        ASoC: max98363: limit the number of channel to 1
        ASoC: max98363: Removed 32bit support
        ASoC: mediatek: mt8195: fix use-after-free in driver remove path
        ASoC: mediatek: mt8188: fix use-after-free in driver remove path
        ASoC: amd: yc: Add Thinkpad Neo14 to quirks list for acp6x
        ...
      697fa9b5
    • Linus Torvalds's avatar
      Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 · 8fc1c596
      Linus Torvalds authored
      Pull ext4 fix from Ted Ts'o:
       "Fix an ext4 regression which breaks remounting r/w file systems that
        have the quota feature enabled"
      
      * tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4:
        ext4: only check dquot_initialize_needed() when debugging
        Revert "ext4: don't clear SB_RDONLY when remounting r/w until quota is re-enabled"
      8fc1c596
    • Wolfram Sang's avatar
      Merge tag 'at24-fixes-for-v6.4-rc6' of... · 33f36147
      Wolfram Sang authored
      Merge tag 'at24-fixes-for-v6.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux into i2c/for-current
      
      at24 fixes for v6.4-rc6
      
      - fix a Kconfig issue (we need to select REGMAP, not only REGMAP_I2C)
      33f36147
    • Arnd Bergmann's avatar
      Merge tag 'imx-fixes-6.4-2' of... · 5cdd5ec1
      Arnd Bergmann authored
      Merge tag 'imx-fixes-6.4-2' of git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux into arm/fixes
      
      i.MX fixes for 6.4, round 2:
      
      - Fix SPI CS pinmux for the final production version of imx8mn-beacon
        board.
      - Fix GPIOs for USDHC2 CD and WP signals on imx8qm-mek board.
      - Assign default clock rate for i.MX8 LPUARTs to fix UART failure.
      
      * tag 'imx-fixes-6.4-2' of git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux:
        arm64: dts: imx8mn-beacon: Fix SPI CS pinmux
        arm64: dts: imx8-ss-dma: assign default clock rate for lpuarts
        arm64: dts: imx8qm-mek: correct GPIOs for USDHC2 CD and WP signals
      
      Link: https://lore.kernel.org/r/20230607141312.GU4199@dragon
      
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      5cdd5ec1
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2023-06-09' of git://anongit.freedesktop.org/drm/drm · 33f2b578
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Bit busier and a bit more scattered than usual. amdgpu is the main
        one, with ivpu and msm having a few fixes, then i915, exynos, ast,
        lima, radeon with some misc bits, but overall nothing standing out.
      
        fb-helper:
         - Fill in fb-helper vars more correctly
      
        amdgpu:
         - S0ix fixes
         - GPU reset fixes
         - SMU13 fixes
         - SMU11 fixes
         - Misc Display fixes
         - Revert RV/RV2/PCO clock counter changes
         - Fix Stoney xclk value
         - Fix reserved vram debug info
      
        radeon:
         - Fix a potential use after free
      
        i915:
         - CDCLK voltage fix for ADL-P
         - eDP wake sync pulse fix
         - Two error handling fixes to selftests
      
        exynos:
         - Fix wrong return in Exynos vidi driver
         - Fix use-after-free issue to Exynos g2d driver
      
        ast:
         - resume and modeset fixes for ast
      
        ivpu:
         - Assorted ivpu fixes
      
        lima:
         - lima context destroy fix
      
        msm:
         - Fix max segment size to address splat on newer a6xx
         - Disable PSR by default w/ modparam to re-enable, since there still
           seems to be a lingering issue
         - Fix HPD issue
         - Fix issue with unitialized GMU mutex"
      
      * tag 'drm-fixes-2023-06-09' of git://anongit.freedesktop.org/drm/drm: (32 commits)
        drm/msm/a6xx: initialize GMU mutex earlier
        drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable
        accel/ivpu: Fix sporadic VPU boot failure
        accel/ivpu: Do not use mutex_lock_interruptible
        accel/ivpu: Do not trigger extra VPU reset if the VPU is idle
        drm/amd/display: Reduce sdp bw after urgent to 90%
        drm/amdgpu: change reserved vram info print
        drm/amdgpu: fix xclk freq on CHIP_STONEY
        drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl
        Revert "drm/amdgpu: switch to golden tsc registers for raven/raven2"
        Revert "drm/amdgpu: Differentiate between Raven2 and Raven/Picasso according to revision id"
        Revert "drm/amdgpu: change the reference clock for raven/raven2"
        drm/amd/display: add ODM case when looking for first split pipe
        drm/amd: Make lack of `ACPI_FADT_LOW_POWER_S0` or `CONFIG_AMD_PMC` louder during suspend path
        drm/amd/pm: conditionally disable pcie lane switching for some sienna_cichlid SKUs
        drm/amd/pm: Fix power context allocation in SMU13
        drm/amdgpu: fix Null pointer dereference error in amdgpu_device_recover_vram
        drm/amd: Disallow s0ix without BIOS support again
        drm/i915/selftests: Add some missing error propagation
        drm/exynos: fix race condition UAF in exynos_g2d_exec_ioctl
        ...
      33f2b578
    • Linus Torvalds's avatar
      Merge tag 'cgroup-for-6.4-rc5-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup · 9cd6357f
      Linus Torvalds authored
      Pull cgroup fixes from Tejun Heo:
      
       - Fix css_set reference leaks on fork failures
      
       - Fix CPU hotplug locking in cgroup_transfer_tasks() which is used by
         cgroup1 cpuset
      
       - Doc update
      
      * tag 'cgroup-for-6.4-rc5-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup:
        cgroup: Documentation: Clarify usage of memory limits
        cgroup: always put cset in cgroup_css_set_put_fork
        cgroup: fix missing cpus_read_{lock,unlock}() in cgroup_transfer_tasks()
      9cd6357f
    • Dave Airlie's avatar
      Merge tag 'drm-msm-fixes-2023-06-08' of https://gitlab.freedesktop.org/drm/msm into drm-fixes · 986c34b4
      Dave Airlie authored
      
      
      A few more late fixes for v6.4-rc6
      
      + Fix max segment size to address splat on newer a6xx
      + Disable PSR by default w/ modparam to re-enable, since there
        still seems to be a lingering issue
      + Fix HPD issue
      + Fix issue with unitialized GMU mutex
      
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      From: Rob Clark <robdclark@gmail.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/CAF6AEGufjVZRNT6YfQ7YUXFC7Cz95wdLF7QHAYkiGfp+3Xc3DQ@mail.gmail.com
      986c34b4
    • Dmitry Baryshkov's avatar
      drm/msm/a6xx: initialize GMU mutex earlier · 12abd735
      Dmitry Baryshkov authored
      Move GMU mutex initialization earlier to make sure that it is always
      initialized. a6xx_destroy can be called from ther failure path before
      GMU initialization.
      
      This fixes the following backtrace:
      
      ------------[ cut here ]------------
      DEBUG_LOCKS_WARN_ON(lock->magic != lock)
      WARNING: CPU: 0 PID: 58 at kernel/locking/mutex.c:582 __mutex_lock+0x1ec/0x3d0
      Modules linked in:
      CPU: 0 PID: 58 Comm: kworker/u16:1 Not tainted 6.3.0-rc5-00155-g187c06436519 #565
      Hardware name: Qualcomm Technologies, Inc. SM8350 HDK (DT)
      Workqueue: events_unbound deferred_probe_work_func
      pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
      pc : __mutex_lock+0x1ec/0x3d0
      lr : __mutex_lock+0x1ec/0x3d0
      sp : ffff800008993620
      x29: ffff800008993620 x28: 0000000000000002 x27: ffff47b253c52800
      x26: 0000000001000606 x25: ffff47b240bb2810 x24: fffffffffffffff4
      x23: 0000000000000000 x22: ffffc38bba15ac14 x21: 0000000000000002
      x20: ffff800008993690 x19: ffff47b2430cc668 x18: fffffffffffe98f0
      x17: 6f74616c75676572 x16: 20796d6d75642067 x15: 0000000000000038
      x14: 0000000000000000 x13: ffffc38bbba050b8 x12: 0000000000000666
      x11: 0000000000000222 x10: ffffc38bbba603e8 x9 : ffffc38bbba050b8
      x8 : 00000000ffffefff x7 : ffffc38bbba5d0b8 x6 : 0000000000000222
      x5 : 000000000000bff4 x4 : 40000000fffff222 x3 : 0000000000000000
      x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff47b240cb1880
      Call trace:
       __mutex_lock+0x1ec/0x3d0
       mutex_lock_nested+0x2c/0x38
       a6xx_destroy+0xa0/0x138
       a6xx_gpu_init+0x41c/0x618
       adreno_bind+0x188/0x290
       component_bind_all+0x118/0x248
       msm_drm_bind+0x1c0/0x670
       try_to_bring_up_aggregate_device+0x164/0x1d0
       __component_add+0xa8/0x16c
       component_add+0x14/0x20
       dsi_dev_attach+0x20/0x2c
       dsi_host_attach+0x9c/0x144
       devm_mipi_dsi_attach+0x34/0xac
       lt9611uxc_attach_dsi.isra.0+0x84/0xfc
       lt9611uxc_probe+0x5b8/0x67c
       i2c_device_probe+0x1ac/0x358
       really_probe+0x148/0x2ac
       __driver_probe_device+0x78/0xe0
       driver_probe_device+0x3c/0x160
       __device_attach_driver+0xb8/0x138
       bus_for_each_drv+0x84/0xe0
       __device_attach+0x9c/0x188
       device_initial_probe+0x14/0x20
       bus_probe_device+0xac/0xb0
       deferred_probe_work_func+0x8c/0xc8
       process_one_work+0x2bc/0x594
       worker_thread+0x228/0x438
       kthread+0x108/0x10c
       ret_from_fork+0x10/0x20
      irq event stamp: 299345
      hardirqs last  enabled at (299345): [<ffffc38bb9ba61e4>] put_cpu_partial+0x1c8/0x22c
      hardirqs last disabled at (299344): [<ffffc38bb9ba61dc>] put_cpu_partial+0x1c0/0x22c
      softirqs last  enabled at (296752): [<ffffc38bb9890434>] _stext+0x434/0x4e8
      softirqs last disabled at (296741): [<ffffc38bb989669c>] ____do_softirq+0x10/0x1c
      ---[ end trace 0000000000000000 ]---
      
      Fixes: 4cd15a3e
      
       ("drm/msm/a6xx: Make GPU destroy a bit safer")
      Cc: Douglas Anderson <dianders@chromium.org>
      Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
      Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
      Patchwork: https://patchwork.freedesktop.org/patch/531540/
      
      
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      12abd735
    • Kuogee Hsieh's avatar
      drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable · a8e981ac
      Kuogee Hsieh authored
      The internal_hpd flag is set to true by dp_bridge_hpd_enable() and set to
      false by dp_bridge_hpd_disable() to handle GPIO pinmuxed into DP controller
      case. HDP related interrupts can not be enabled until internal_hpd is set
      to true. At current implementation dp_display_config_hpd() will initialize
      DP host controller first followed by enabling HDP related interrupts if
      internal_hpd was true at that time. Enable HDP related interrupts depends on
      internal_hpd status may leave system with DP driver host is in running state
      but without HDP related interrupts being enabled. This will prevent external
      display from being detected. Eliminated this dependency by moving HDP related
      interrupts enable/disable be done at dp_bridge_hpd_enable/disable() directly
      regardless of internal_hpd status.
      
      Changes in V3:
      -- dp_catalog_ctrl_hpd_enable() and dp_catalog_ctrl_hpd_disable()
      -- rewording ocmmit text
      
      Changes in V4:
      -- replace dp_display_config_hpd() with dp_display_host_start()
      -- move enable_irq() at dp_display_host_start();
      
      Changes in V5:
      -- replace dp_display_host_start() with dp_display_host_init()
      
      Changes in V6:
      -- squash remove enable_irq() and disable_irq()
      
      Fixes: cd198cad
      
       ("drm/msm/dp: Rely on hpd_enable/disable callbacks")
      Signed-off-by: default avatarKuogee Hsieh <quic_khsieh@quicinc.com>
      Tested-by: Leonard Lausen <leonard@lausen.nl> # on sc7180 lazor
      Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
      Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
      Tested-by: default avatarBjorn Andersson <andersson@kernel.org>
      Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
      Link: https://lore.kernel.org/r/1684878756-17830-1-git-send-email-quic_khsieh@quicinc.com
      
      
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      a8e981ac
    • Dave Airlie's avatar
      Merge tag 'drm-misc-fixes-2023-06-08' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes · bcd84301
      Dave Airlie authored
      
      
      drm-misc-fixes for v6.4-rc6:
      - resume and modeset fixes for ast.
      - Fill in fb-helper vars more correctly.
      - Assorted ivpu fixes.
      - lima context destroy fix.
      
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/ea6b88ec-b653-3781-0b68-cd0275c27923@linux.intel.com
      bcd84301
    • Dave Airlie's avatar
      Merge tag 'exynos-drm-fixes-for-v6.4-rc6' of... · 02b8f0b7
      Dave Airlie authored
      Merge tag 'exynos-drm-fixes-for-v6.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos
      
       into drm-fixes
      
      Two fixups
      - Fix wrong return in Exynos vidi driver.
      - Fix use-after-free issue to Exynos g2d driver.
      
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      
      From: Inki Dae <inki.dae@samsung.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20230607043148.43303-1-inki.dae@samsung.com
      02b8f0b7
    • Dave Airlie's avatar
      Merge tag 'drm-intel-fixes-2023-06-08' of... · d6d4f0a1
      Dave Airlie authored
      Merge tag 'drm-intel-fixes-2023-06-08' of git://anongit.freedesktop.org/drm/drm-intel
      
       into drm-fixes
      
      CDCLK voltage fix for ADL-P and eDP wake sync pulse fix.
      Two error handling fixes to selftests (to appease static checkers)
      
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/ZIGUHBz7+LsqN2nm@jlahtine-mobl.ger.corp.intel.com
      d6d4f0a1
    • Dave Airlie's avatar
      Merge tag 'amd-drm-fixes-6.4-2023-06-07' of... · b1913ff4
      Dave Airlie authored
      Merge tag 'amd-drm-fixes-6.4-2023-06-07' of https://gitlab.freedesktop.org/agd5f/linux
      
       into drm-fixes
      
      amd-drm-fixes-6.4-2023-06-07:
      
      amdgpu:
      - S0ix fixes
      - GPU reset fixes
      - SMU13 fixes
      - SMU11 fixes
      - Misc Display fixes
      - Revert RV/RV2/PCO clock counter changes
      - Fix Stoney xclk value
      - Fix reserved vram debug info
      
      radeon:
      - Fix a potential use after free
      
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      From: Alex Deucher <alexander.deucher@amd.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20230607213740.7723-1-alexander.deucher@amd.com
      b1913ff4
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 8d15d5e1
      Linus Torvalds authored
      Pull arm64 fixes from Will Deacon:
       "Two tiny arm64 fixes for -rc6.
      
        One fixes a build breakage when MAX_ORDER can be nonsensical if
        CONFIG_EXPERT=y and the other fixes the address masking for perf's
        page fault software events so that it is consistent amongst them:
      
         - Fix build breakage due to bogus MAX_ORDER definitions on !4k pages
      
         - Avoid masking fault address for perf software events"
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: mm: pass original fault address to handle_mm_fault() in PER_VMA_LOCK block
        arm64: Remove the ARCH_FORCE_MAX_ORDER config input prompt
      8d15d5e1
    • Mike Christie's avatar
      vhost: Fix worker hangs due to missed wake up calls · 4b13cbef
      Mike Christie authored
      We can race where we have added work to the work_list, but
      vhost_task_fn has passed that check but not yet set us into
      TASK_INTERRUPTIBLE. wake_up_process will see us in TASK_RUNNING and
      just return.
      
      This bug was intoduced in commit f9010dbd ("fork, vhost: Use
      CLONE_THREAD to fix freezer/ps regression") when I moved the setting
      of TASK_INTERRUPTIBLE to simplfy the code and avoid get_signal from
      logging warnings about being in the wrong state. This moves the setting
      of TASK_INTERRUPTIBLE back to before we test if we need to stop the
      task to avoid a possible race there as well. We then have vhost_worker
      set TASK_RUNNING if it finds work similar to before.
      
      Fixes: f9010dbd
      
       ("fork, vhost: Use CLONE_THREAD to fix freezer/ps regression")
      Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
      Message-Id: <20230607192338.6041-3-michael.christie@oracle.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      4b13cbef
    • Mike Christie's avatar
      vhost: Fix crash during early vhost_transport_send_pkt calls · a284f09e
      Mike Christie authored
      If userspace does VHOST_VSOCK_SET_GUEST_CID before VHOST_SET_OWNER we
      can race where:
      1. thread0 calls vhost_transport_send_pkt -> vhost_work_queue
      2. thread1 does VHOST_SET_OWNER which calls vhost_worker_create.
      3. vhost_worker_create will set the dev->worker pointer before setting
      the worker->vtsk pointer.
      4. thread0's vhost_work_queue will see the dev->worker pointer is
      set and try to call vhost_task_wake using not yet set worker->vtsk
      pointer.
      5. We then crash since vtsk is NULL.
      
      Before commit 6e890c5d ("vhost: use vhost_tasks for worker
      threads"), we only had the worker pointer so we could just check it to
      see if VHOST_SET_OWNER has been done. After that commit we have the
      vhost_worker and vhost_task pointer, so we can now hit the bug above.
      
      This patch embeds the vhost_worker in the vhost_dev and moves the work
      list initialization back to vhost_dev_init, so we can just check the
      worker.vtsk pointer to check if VHOST_SET_OWNER has been done like
      before.
      
      Fixes: 6e890c5d
      
       ("vhost: use vhost_tasks for worker threads")
      Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
      Message-Id: <20230607192338.6041-2-michael.christie@oracle.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reported-by: default avatar <syzbot+d0d442c22fa8db45ff0e@syzkaller.appspotmail.com>
      Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
      a284f09e
    • Andrey Smetanin's avatar
      vhost_net: revert upend_idx only on retriable error · 1f5d2e3b
      Andrey Smetanin authored
      
      
      Fix possible virtqueue used buffers leak and corresponding stuck
      in case of temporary -EIO from sendmsg() which is produced by
      tun driver while backend device is not up.
      
      In case of no-retriable error and zcopy do not revert upend_idx
      to pass packet data (that is update used_idx in corresponding
      vhost_zerocopy_signal_used()) as if packet data has been
      transferred successfully.
      
      v2: set vq->heads[ubuf->desc].len equal to VHOST_DMA_DONE_LEN
      in case of fake successful transmit.
      
      Signed-off-by: default avatarAndrey Smetanin <asmetanin@yandex-team.ru>
      Message-Id: <20230424204411.24888-1-asmetanin@yandex-team.ru>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarAndrey Smetanin <asmetanin@yandex-team.ru>
      Acked-by: default avatarJason Wang <jasowang@redhat.com>
      1f5d2e3b
    • Shannon Nelson's avatar
      vhost_vdpa: tell vqs about the negotiated · 376daf31
      Shannon Nelson authored
      
      
      As is done in the net, iscsi, and vsock vhost support, let the vdpa vqs
      know about the features that have been negotiated.  This allows vhost
      to more safely make decisions based on the features, such as when using
      PACKED vs split queues.
      
      Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
      Acked-by: default avatarJason Wang <jasowang@redhat.com>
      Message-Id: <20230424225031.18947-2-shannon.nelson@amd.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      376daf31
    • Dragos Tatulea's avatar
      vdpa/mlx5: Fix hang when cvq commands are triggered during device unregister · 73790bdf
      Dragos Tatulea authored
      Currently the vdpa device is unregistered after the workqueue that
      processes vq commands is disabled. However, the device unregister
      process can still send commands to the cvq (a vlan delete for example)
      which leads to a hang because the handing workqueue has been disabled
      and the command never finishes:
      
       [ 2263.095764] rcu: INFO: rcu_sched self-detected stall on CPU
       [ 2263.096307] rcu:        9-....: (5250 ticks this GP) idle=dac4/1/0x4000000000000000 softirq=111009/111009 fqs=2544
       [ 2263.097154] rcu:        (t=5251 jiffies g=393549 q=347 ncpus=10)
       [ 2263.097648] CPU: 9 PID: 94300 Comm: kworker/u20:2 Not tainted 6.3.0-rc6_for_upstream_min_debug_2023_04_14_00_02 #1
       [ 2263.098535] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014
       [ 2263.099481] Workqueue: mlx5_events mlx5_vhca_state_work_handler [mlx5_core]
       [ 2263.100143] RIP: 0010:virtnet_send_command+0x109/0x170
       [ 2263.100621] Code: 1d df f5 ff 85 c0 78 5c 48 8b 7b 08 e8 d0 c5 f5 ff 84 c0 75 11 eb 22 48 8b 7b 08 e8 01 b7 f5 ff 84 c0 75 15 f3 90 48 8b 7b 08 <48> 8d 74 24 04 e8 8d c5 f5 ff 48 85 c0 74 de 48 8b 83 f8 00 00 00
       [ 2263.102148] RSP: 0018:ffff888139cf36e8 EFLAGS: 00000246
       [ 2263.102624] RAX: 0000000000000000 RBX: ffff888166bea940 RCX: 0000000000000001
       [ 2263.103244] RDX: 0000000000000000 RSI: ffff888139cf36ec RDI: ffff888146763800
       [ 2263.103864] RBP: ffff888139cf3710 R08: ffff88810d201000 R09: 0000000000000000
       [ 2263.104473] R10: 0000000000000002 R11: 0000000000000003 R12: 0000000000000002
       [ 2263.105082] R13: 0000000000000002 R14: ffff888114528400 R15: ffff888166bea000
       [ 2263.105689] FS:  0000000000000000(0000) GS:ffff88852cc80000(0000) knlGS:0000000000000000
       [ 2263.106404] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
       [ 2263.106925] CR2: 00007f31f394b000 CR3: 000000010615b006 CR4: 0000000000370ea0
       [ 2263.107542] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
       [ 2263.108163] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
       [ 2263.108769] Call Trace:
       [ 2263.109059]  <TASK>
       [ 2263.109320]  ? check_preempt_wakeup+0x11f/0x230
       [ 2263.109750]  virtnet_vlan_rx_kill_vid+0x5a/0xa0
       [ 2263.110180]  vlan_vid_del+0x9c/0x170
       [ 2263.110546]  vlan_device_event+0x351/0x760 [8021q]
       [ 2263.111004]  raw_notifier_call_chain+0x41/0x60
       [ 2263.111426]  dev_close_many+0xcb/0x120
       [ 2263.111808]  unregister_netdevice_many_notify+0x130/0x770
       [ 2263.112297]  ? wq_worker_running+0xa/0x30
       [ 2263.112688]  unregister_netdevice_queue+0x89/0xc0
       [ 2263.113128]  unregister_netdev+0x18/0x20
       [ 2263.113512]  virtnet_remove+0x4f/0x230
       [ 2263.113885]  virtio_dev_remove+0x31/0x70
       [ 2263.114273]  device_release_driver_internal+0x18f/0x1f0
       [ 2263.114746]  bus_remove_device+0xc6/0x130
       [ 2263.115146]  device_del+0x173/0x3c0
       [ 2263.115502]  ? kernfs_find_ns+0x35/0xd0
       [ 2263.115895]  device_unregister+0x1a/0x60
       [ 2263.116279]  unregister_virtio_device+0x11/0x20
       [ 2263.116706]  device_release_driver_internal+0x18f/0x1f0
       [ 2263.117182]  bus_remove_device+0xc6/0x130
       [ 2263.117576]  device_del+0x173/0x3c0
       [ 2263.117929]  ? vdpa_dev_remove+0x20/0x20 [vdpa]
       [ 2263.118364]  device_unregister+0x1a/0x60
       [ 2263.118752]  mlx5_vdpa_dev_del+0x4c/0x80 [mlx5_vdpa]
       [ 2263.119232]  vdpa_match_remove+0x21/0x30 [vdpa]
       [ 2263.119663]  bus_for_each_dev+0x71/0xc0
       [ 2263.120054]  vdpa_mgmtdev_unregister+0x57/0x70 [vdpa]
       [ 2263.120520]  mlx5v_remove+0x12/0x20 [mlx5_vdpa]
       [ 2263.120953]  auxiliary_bus_remove+0x18/0x30
       [ 2263.121356]  device_release_driver_internal+0x18f/0x1f0
       [ 2263.121830]  bus_remove_device+0xc6/0x130
       [ 2263.122223]  device_del+0x173/0x3c0
       [ 2263.122581]  ? devl_param_driverinit_value_get+0x29/0x90
       [ 2263.123070]  mlx5_rescan_drivers_locked+0xc4/0x2d0 [mlx5_core]
       [ 2263.123633]  mlx5_unregister_device+0x54/0x80 [mlx5_core]
       [ 2263.124169]  mlx5_uninit_one+0x54/0x150 [mlx5_core]
       [ 2263.124656]  mlx5_sf_dev_remove+0x45/0x90 [mlx5_core]
       [ 2263.125153]  auxiliary_bus_remove+0x18/0x30
       [ 2263.125560]  device_release_driver_internal+0x18f/0x1f0
       [ 2263.126052]  bus_remove_device+0xc6/0x130
       [ 2263.126451]  device_del+0x173/0x3c0
       [ 2263.126815]  mlx5_sf_dev_remove+0x39/0xf0 [mlx5_core]
       [ 2263.127318]  mlx5_sf_dev_state_change_handler+0x178/0x270 [mlx5_core]
       [ 2263.127920]  blocking_notifier_call_chain+0x5a/0x80
       [ 2263.128379]  mlx5_vhca_state_work_handler+0x151/0x200 [mlx5_core]
       [ 2263.128951]  process_one_work+0x1bb/0x3c0
       [ 2263.129355]  ? process_one_work+0x3c0/0x3c0
       [ 2263.129766]  worker_thread+0x4d/0x3c0
       [ 2263.130140]  ? process_one_work+0x3c0/0x3c0
       [ 2263.130548]  kthread+0xb9/0xe0
       [ 2263.130895]  ? kthread_complete_and_exit+0x20/0x20
       [ 2263.131349]  ret_from_fork+0x1f/0x30
       [ 2263.131717]  </TASK>
      
      The fix is to disable and destroy the workqueue after the device
      unregister. It is expected that vhost will not trigger kicks after
      the unregister. But even if it would, the wq is disabled already by
      setting the pointer to NULL (done so in the referenced commit).
      
      Fixes: ad6dc1da
      
       ("vdpa/mlx5: Avoid processing works if workqueue was destroyed")
      Signed-off-by: default avatarDragos Tatulea <dtatulea@nvidia.com>
      Message-Id: <20230516095800.3549932-1-dtatulea@nvidia.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
      Acked-by: default avatarJason Wang <jasowang@redhat.com>
      73790bdf
    • Rong Tao's avatar
      tools/virtio: Add .gitignore for ringtest · c66dbc39
      Rong Tao authored
      
      
      Ignore executables for ringtest.
      
      Signed-off-by: default avatarRong Tao <rongtao@cestc.cn>
      Message-Id: <tencent_C121802C93CB4095C6D7D95113442E830A07@qq.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      c66dbc39
    • Rong Tao's avatar
      tools/virtio: Fix arm64 ringtest compilation error · 57380fd1
      Rong Tao authored
      
      
      Add cpu_relax() for arm64 instead of directly assert(), and add assert.h
      header file. Also, add smp_wmb and smp_mb for arm64.
      
      Compilation error as follows, avoid __always_inline undefined.
      
          $ make
          cc -Wall -pthread -O2 -ggdb -flto -fwhole-program -c -o ring.o ring.c
          In file included from ring.c:10:
          main.h: In function ‘busy_wait’:
          main.h:99:21: warning: implicit declaration of function ‘assert’
          [-Wimplicit-function-declaration]
          99 | #define cpu_relax() assert(0)
              |                     ^~~~~~
          main.h:107:17: note: in expansion of macro ‘cpu_relax’
          107 |                 cpu_relax();
              |                 ^~~~~~~~~
          main.h:12:1: note: ‘assert’ is defined in header ‘<assert.h>’; did you
          forget to ‘#include <assert.h>’?
          11 | #include <stdbool.h>
          +++ |+#include <assert.h>
          12 |
          main.h: At top level:
          main.h:143:23: error: expected ‘;’ before ‘void’
          143 | static __always_inline
              |                       ^
              |                       ;
          144 | void __read_once_size(const volatile void *p, void *res, int
          size)
              | ~~~~
          main.h:158:23: error: expected ‘;’ before ‘void’
          158 | static __always_inline void __write_once_size(volatile void *p,
          void *res, int size)
              |                       ^~~~~
              |                       ;
          make: *** [<builtin>: ring.o] Error 1
      
      Signed-off-by: default avatarRong Tao <rongtao@cestc.cn>
      Message-Id: <tencent_F53E159DD7925174445D830DA19FACF44B07@qq.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      57380fd1