- Jan 21, 2015
-
-
Wu Fengguang authored
drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Vincent Yang <vincent.yang.fujitsu@gmail.com> Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Nicholas Mc Guire authored
Signed-off-by:
Nicholas Mc Guire <der.herr@hofr.at> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Asaf Vertz authored
Fixed the following warning (reported by cppcheck): [drivers/mmc/card/block.c:2149]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. Signed-off-by:
Asaf Vertz <asaf.vertz@tandemg.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
- Jan 20, 2015
-
-
Ulf Hansson authored
-
Kuninori Morimoto authored
tmio_mmc_host has .enable_dma callback now. We don't need TMIO_MMC_HAVE_CTL_DMA_REG anymore. Let's remove it Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Now, sh_mobile_sdhi can use 32bit DMA access in R-Cer Gen2. Let's use it. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
tmio_mmc_dma has .enable_dma callback now. let's use it. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
getting struct sh_mobile_sdhi from struct mmc_host needs to use complex container_of(). This patch adds new host_to_priv macro to get it easily. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Latest SDHI on Renesas has expand register mapping. update mmc_data->bus_shift for it. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
No one is using .init/.cleanup callback function. Let's remove these. sdhi_ops and .cd_wakeup are also removed Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Renesas SDHI which is based on TMIO driver has 2 type SoC. 1st one is used as SH-Mobile series, and 2nd is R-Car series. R-Car series SoC has DMA buswidth setting register which enables 32bit access. This patch adds .dma_buswidth and enables it. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Some controllers need DMA special register/setting. This patch adds new .enable_dma callback for it. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current .dma_rx_offset is implemented under tmio_mmc_dma. It goes to tmio_mmc_data by this patch. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current .alignment_shift is implemented under tmio_mmc_dma. It goes to tmio_mmc_data by this patch. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current .bus_shift is implemented under tmio_mmc_data. It goes to tmio_mmc_host by this patch. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current .multi_io_quirk is implemented under tmio_mmc_data. It goes to tmio_mmc_host by this patch. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current .clk_disable is implemented under tmio_mmc_data. It goes to tmio_mmc_host by this patch. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current .clk_enable is implemented under tmio_mmc_data. It goes to tmio_mmc_host by this patch. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current .write16_hook is implemented under tmio_mmc_data. It goes to tmio_mmc_host by this patch. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current .dma is implemented under tmio_mmc_data. It goes to tmio_mmc_host by this patch. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Kuninori Morimoto authored
Current tmio_mmc driver is using tmio_mmc_data for driver/platform specific data/callback, and it is needed for tmio_mmc_host_probe() function. Because of this style, include/linux/mfd/tmio.h header has tmio driver/framework specific data which is not needed from platform. This patch adds new tmio_mmc_host_alloc/free() as cleanup preparation. tmio driver specific data/callback will be implemented in tmio_mmc_host, and platform specific data/callback will be implemented in tmio_mmc_data in this cleanup. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Vincent Yang authored
This patch adds new host controller driver for Fujitsu SDHCI controller f_sdh30. Signed-off-by:
Vincent Yang <Vincent.Yang@tw.fujitsu.com> Signed-off-by:
Andy Green <andy.green@linaro.org> Signed-off-by:
Tetsuya Takinishi <t.takinishi@jp.fujitsu.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Vincent Yang authored
This patch defines a quirk to disable the block count for single block transactions. It is a preparation and will be used by Fujitsu SDHCI controller f_sdh30 driver. Signed-off-by:
Vincent Yang <Vincent.Yang@tw.fujitsu.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Vincent Yang authored
This patch defines a quirk for tuning work around for some sdhci host controller. It sets both SDHCI_CTRL_EXEC_TUNING and SDHCI_CTRL_TUNED_CLK for tuning. It is a preparation and will be used by Fujitsu SDHCI controller f_sdh30 driver. Signed-off-by:
Vincent Yang <Vincent.Yang@tw.fujitsu.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Vincent Yang authored
This patch adds a callback function to do controller-specific actions when switching voltages. It is a preparation and will be used by Fujitsu SDHCI controller f_sdh30 driver. Signed-off-by:
Vincent Yang <Vincent.Yang@tw.fujitsu.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
- Jan 19, 2015
-
-
Doug Anderson authored
If we power up vqmmc in MMC_POWER_ON then we end up turning it on before mmc_power_up() sets the signal voltage. That's not so great since we might be powering it up at the wrong voltage. Note that this is how Yuvaraj originally coded things up in <https://patchwork.kernel.org/patch/4401231/> but he changed it on my suggestion. Apparently I was wrong. Reported-by:
Alexandru M Stan <amstan@chromium.org> Signed-off-by:
Doug Anderson <dianders@chromium.org> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Mohammad Jamal authored
This patch solves the coding style issue by adding a space before ( Signed-off-by:
Mohammad Jamal <md.jamalmohiuddin@gmail.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Jisheng Zhang authored
This patch calls pm_runtime_put_noidle() to restore the device's usage counter in the ->remove() implementation. Signed-off-by:
Jisheng Zhang <jszhang@marvell.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Jisheng Zhang authored
Commit 0dcaa249 ("sdhci-pxav3: Fix runtime PM initialization") tries to fix one hang issue caused by calling sdhci_add_host() on a suspended device. The fix enables the clock twice, once by clk_prepare_enable() and another by pm_runtime_get_sync(), meaning that the clock will never be gated at runtime PM suspend. I observed the power consumption regression on Marvell BG2Q SoCs. In fact, the fix is not correct. There still be a very small window during which a runtime suspend might somehow occur after pm_runtime_enable() but before pm_runtime_get_sync(). This patch fixes all of the two problems by just incrementing the usage counter before pm_runtime_enable(). It also adjust the order of disabling runtime pm and storing the usage count in the error path to handle clock gating properly. Signed-off-by:
Jisheng Zhang <jszhang@marvell.com> Cc: <stable@vger.kernel.org> # v3.11+ Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Adrian Hunter authored
There is no point making the initialization of buf_ready_int conditional on host version. Simplify by just doing it always. Note that the other conditional initializations will be removed when the new way of doing re-tuning is taken into use. Signed-off-by:
Adrian Hunter <adrian.hunter@intel.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Adrian Hunter authored
Both callers of mmc_start_request() call mmc_card_removed() so move that call into mmc_start_request(). This patch is preparation for adding re-tuning support. Signed-off-by:
Adrian Hunter <adrian.hunter@intel.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Adrian Hunter authored
For each MMC, SD and SDIO there is code that holds the clock, calls ops->execute_tuning, and releases the clock. Simplify the code a bit by providing a separate function to do that. Signed-off-by:
Adrian Hunter <adrian.hunter@intel.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
NeilBrown authored
This ensures that all standard options are available to hsmmc, In particular, I need cap-power-off-card. Signed-off-by:
NeilBrown <neilb@suse.de> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
NeilBrown authored
Using the common code removes some code duplication, and makes it easier to switch to using mmc_of_parse() which will remove more duplication. This uses the new mmc_gpio_request_cd_isr to provide a non-standard interrupt service routine for card-detect interrupts. Signed-off-by:
NeilBrown <neilb@suse.de> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
NeilBrown authored
One of the reasons omap_hsmmc doesn't use the slot-gpio library is that it has some non-standard functionality in the card-detect interrupt service routine. To make it possible for omap_hsmmc (and maybe others) to be converted to use slot-gpio, add 'mmc_gpio_request_cd_isr' which provide an alternate isr to be register by the slot-gpio code. Signed-off-by:
NeilBrown <neilb@suse.de> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Andy Shevchenko authored
Just fix the comments, no functional changes. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Johan Rudholm authored
Enable power cycle and re-initialization of SD cards via the reset bus_ops. Power cycling a buggy SD card sometimes helps it get back on track. Signed-off-by:
Johan Rudholm <johanru@axis.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Johan Rudholm authored
Move the (e)MMC specific hw_reset code from core.c into mmc.c. Call the code from the new bus_ops member "reset". This also allows for adding a SD card specific reset procedure. Signed-off-by:
Johan Rudholm <johanru@axis.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Johan Rudholm authored
Always check if the card is alive after a successful reset. This allows us to remove mmc_hw_reset_check(), leaving mmc_hw_reset() as the only card reset interface. Signed-off-by:
Johan Rudholm <johanru@axis.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-
Sascha Hauer authored
This adds SDIO devicetree subnode parsing to the mmc core. While SDIO devices are runtime probable they sometimes need nonprobable additional information on embedded systems, like an additional gpio interrupt or a clock. This patch makes it possible to supply this information from the devicetree. SDIO drivers will find a pointer to the devicenode in their devices of_node pointer. Signed-off-by:
Sascha Hauer <s.hauer@pengutronix.de> [hdegoede@redhat.com: Misc. cleanups] Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Ulf Hansson <ulf.hansson@linaro.org>
-