Skip to content
  1. Jan 10, 2013
    • Takashi Iwai's avatar
      ALSA: hda/realtek - Make path->idx[] and path->multi[] consistent · 95e960ce
      Takashi Iwai authored 
      

So far, idx[i] and multi[i] indicate the attribute of the widget
path[i - 1].  This was just for simplifying the code in
__parse_output_path(), but this is rather confusing for later use.
It's more natural if both idx[i] and multi[i] point to the same widget
of path[i].  This patch changes to that way.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      95e960ce
    • Takashi Iwai's avatar
      ALSA: hda/realtek - Simplify the output volume initialization · 78e635c9
      Takashi Iwai authored 
      

Simplify the output path initialization using the existing path
information instead of assuming the topology specific to Realtek
codecs.  This is also implicitly a fix for some amp values on output
pins where the old parser missed (e.g. ALC260 output pins).

The same function alc_auto_set_output_and_unmute() can be used now for
the multi-io activation, since the output selection means nothing but
activating the given output path.

And, finally at this stage, we can get rid of alc_go_down_to_selector()
and other functions that are codec really specifically to Realtek
codecs.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      78e635c9
    • Takashi Iwai's avatar
      ALSA: hda/realtek - Reduce vol/mute ctl lookups at parsing codec · 792cf2fa
      Takashi Iwai authored 
      

So far, Realtek codec driver evaluates the NIDs for volume and mute
controls twice, once while parsing the DACs and evaluating the
assignment, and another while creating the mixer elements.  This is
utterly redundant and even fragile, as it's assuming that the ctl
element evaluation is identical between both parsing DACs and creating
mixer elements.

This patch simplifies the code flow by doing the volume / mute
controls evaluation only once while parsing the DACs.  The patch ended
up in larger changes than expected because of some cleanups became
mandatory.

As a gratis bonus, this patch also fixes some cases where the stereo
channels are used wrongly for mono amps.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      792cf2fa
    • Takashi Iwai's avatar
      ALSA: hda - Fix mono amp values in proc output · 2f179721
      Takashi Iwai authored 
      

The mono widget is always connected to the left channel, thus the left
channel amp value also should be referred for mono widgets instead of
the right channel.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      2f179721
    • Takashi Iwai's avatar
      ALSA: hda/realtek - Manage mixer controls in out_path list · ba811127
      Takashi Iwai authored 
      

As we parse the output paths more precisely now, we can use this path
list for parsing the widgets for volume and mute mixer controls.
The spec->vol_ctls[] and sw_ctls[] bitmasks are replaced with the
ctls[] in each output path instance.

Interestingly, this move alone automagically fixes some bugs that the
conflicting volume or mute NIDs weren't properly detected.
Also, by parsing the whole path, there are more chances to get a free
widget for volume/mute controls.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      ba811127
    • Takashi Iwai's avatar
      ALSA: hda/realtek - Add output path parser · 30dcd3b4
      Takashi Iwai authored 
      

Add the output path parser to Realtek codec driver as we already have
in patch_via.c.  The nid_path struct represents the complete output
path from a DAC to a pin.  The alc_spec contains an array of these
paths, and a new path is added at each time when a new DAC is
assigned.

So far, this path list is used only in limited codes: namely in this
patch, only alc_is_dac_already_used() checks the list instead of dac
arrays in all possible outputs.  In the later development, the path
list will be referred from more places, such as the mixer control
assignment / check, the mute/unmute of active routes, etc.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      30dcd3b4
    • Takashi Iwai's avatar
      ALSA: hda/realtek - List up all available DACs · 463419de
      Takashi Iwai authored 
      

In the probing phase, create a list of all available DACs in the codec
and use it for checking the single DAC connections.
This list will be used in more other places in the later commits, too.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      463419de
    • Takashi Iwai's avatar
      ALSA: hda/realtek - Simplify alc_auto_is_dac_reachable() · 6a84c305
      Takashi Iwai authored 
      

Use the helper function snd_hda_get_conn_index() instead of open
codes.  This also improves the detection of some routes to DAC on
ALC260 (although the difference doesn't influence on the end
results of the mapping).

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      6a84c305
    • Kailang Yang's avatar
      ALSA: hda - Add support of new codec ALC284 · 065380f0
      Kailang Yang authored 
      

Added the support for a new codec ALC284, which is compatible with
ALC269.  Also add more codec variants to handle the SSID check
properly.

Signed-off-by: default avatarKailang Yang <kailang@realtek.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      065380f0
    • Sachin Kamat's avatar
      ALSA: usb-audio: Make ebox44_table static · e8e7da23
      Sachin Kamat authored 
      

Fixes the following sparse warning:
sound/usb/mixer_quirks.c:1209:23: warning:
symbol 'ebox44_table' was not declared. Should it be static?

Signed-off-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      e8e7da23
  3. Jan 09, 2013
  5. Jan 08, 2013
  7. Jan 07, 2013
  9. Jan 04, 2013
  11. Jan 03, 2013
  13. Dec 22, 2012