Skip to content
Commit 942859d9 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Ard Biesheuvel
Browse files

efi: cper: fix snprintf() use in cper_dimm_err_location()



snprintf() should be given the full buffer size, not one less. And it
guarantees nul-termination, so doing it manually afterwards is
pointless.

It's even potentially harmful (though probably not in practice because
CPER_REC_LEN is 256), due to the "return how much would have been
written had the buffer been big enough" semantics. I.e., if the bank
and/or device strings are long enough that the "DIMM location ..."
output gets truncated, writing to msg[n] is a buffer overflow.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Fixes: 3760cd20

 ("CPER: Adjust code flow of some functions")
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent c4039b29
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment