Bluetooth: btusb: Fix memory leak in play_deferred
Currently we are calling usb_submit_urb directly to submit deferred tx urbs after unanchor them. So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb and cause memory leak: unreferenced object 0xffffffc0ce0fa400 (size 256): ... backtrace: [<ffffffc00034a9a8>] __save_stack_trace+0x48/0x6c [<ffffffc00034b088>] create_object+0x138/0x254 [<ffffffc0009d5504>] kmemleak_alloc+0x58/0x8c [<ffffffc000345f78>] __kmalloc+0x1d4/0x2a0 [<ffffffc0006765bc>] usb_alloc_urb+0x30/0x60 [<ffffffbffc128598>] alloc_ctrl_urb+0x38/0x120 [btusb] [<ffffffbffc129e7c>] btusb_send_frame+0x64/0xf8 [btusb] Put those urbs in tx_anchor to avoid the leak, and also fix the error handling. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> Reviewed-by: Oliver Neukum <oneukum@suse.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
parent
d98422cb
-
mentioned in commit 0eeec1a8
-
mentioned in commit 6616872c
-
mentioned in commit 6b4d8b44
-
mentioned in commit f21f9083
-
mentioned in commit 3e7c7df6
-
mentioned in commit 1eb0afec
-
mentioned in commit a4320615
-
mentioned in commit 71f100ce
-
mentioned in commit fa065e60
-
mentioned in commit 815381ae
-
mentioned in commit 75b276c0
-
mentioned in commit 3ea4a534
Please register or sign in to comment