Skip to content
Commit 0d7c1153 authored by Alviro Iskandar Setiawan's avatar Alviro Iskandar Setiawan Committed by Jens Axboe
Browse files

io_uring: Clean up a false-positive warning from GCC 9.3.0



In io_recv(), if import_single_range() fails, the @flags variable is
uninitialized, then it will goto out_free.

After the goto, the compiler doesn't know that (ret < min_ret) is
always true, so it thinks the "if ((flags & MSG_WAITALL) ..."  path
could be taken.

The complaint comes from gcc-9 (Debian 9.3.0-22) 9.3.0:
```
  fs/io_uring.c:5238 io_recvfrom() error: uninitialized symbol 'flags'
```
Fix this by bypassing the @ret and @flags check when
import_single_range() fails.

Reasons:
 1. import_single_range() only returns -EFAULT when it fails.
 2. At that point, @flags is uninitialized and shouldn't be read.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reported-by: default avatar"Chen, Rong A" <rong.a.chen@intel.com>
Link: https://lore.gnuweeb.org/timl/d33bb5a9-8173-f65b-f653-51fc0681c6d6@intel.com/


Cc: Pavel Begunkov <asml.silence@gmail.com>
Suggested-by: default avatarAmmar Faizi <ammarfaizi2@gnuweeb.org>
Fixes: 7297ce3d

 ("io_uring: improve send/recv error handling")
Signed-off-by: default avatarAlviro Iskandar Setiawan <alviro.iskandar@gmail.com>
Signed-off-by: default avatarAmmar Faizi <ammarfaizi2@gnuweeb.org>
Link: https://lore.kernel.org/r/20220207140533.565411-1-ammarfaizi2@gnuweeb.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent f6133fbd
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment