Skip to content
  1. Jun 02, 2018
    • Guenter Roeck's avatar
      ASoC: topology: Move skl-tplg-interface.h to uapi · 0c24fdc0
      Guenter Roeck authored
      
      
      skl-tplg-interface.h describes firmware format details for Skylake
      topology files. It is part of the ABI and should reside in the uapi
      directory.
      
      While moving the file, also replace the license boilerplate with
      the SPDX License Identifier.
      
      No functional change.
      
      Signed-off-by: default avatarGuenter Roeck <groeck@chromium.org>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      0c24fdc0
    • Guenter Roeck's avatar
      ASoC: topology: Move v4 manifest header data structures to uapi · 348f4822
      Guenter Roeck authored
      
      
      Topology manifest v4 is still part of the ABI. Move its data structures
      into the uapi header file.
      
      No functional change.
      
      Signed-off-by: default avatarGuenter Roeck <groeck@chromium.org>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      348f4822
    • Guenter Roeck's avatar
      ASoC: topology: Improve backwards compatibility with v4 topology files · ac9391da
      Guenter Roeck authored
      Commit dc31e741 ("ASoC: topology: ABI - Add the types for BE
      DAI") introduced sound topology files version 5. Initially, this
      change made the topology code incompatible with v4 topology files.
      Backwards compatibility with v4 configuration files was
      subsequently added with commit 288b8da7
      
       ("ASoC: topology:
      Support topology file of ABI v4").
      
      Unfortunately, backwards compatibility was never fully implemented.
      
      First, the manifest size in (Skylake) v4 configuration files is set
      to 0, which causes manifest_new_ver() to bail out with error messages
      similar to the following.
      
      snd_soc_skl 0000:00:1f.3: ASoC: invalid manifest size
      snd_soc_skl 0000:00:1f.3: tplg component load failed-22
      snd_soc_skl 0000:00:1f.3: Failed to init topology!
      snd_soc_skl 0000:00:1f.3: ASoC: failed to probe component -22
      skl_n88l25_m98357a skl_n88l25_m98357a: ASoC: failed to instantiate card -22
      skl_n88l25_m98357a: probe of skl_n88l25_m98357a failed with error -22
      
      After this problem is fixed, the following error message is seen instead.
      
      snd_soc_skl 0000:00:1f.3: ASoC: old version of manifest
      snd_soc_skl 0000:00:1f.3: Invalid descriptor token 1093938482
      snd_soc_skl 0000:00:1f.3: ASoC: failed to load widget media0_in cpr 0
      snd_soc_skl 0000:00:1f.3: tPlg component load failed-22
      
      This message is seen because backwards compatibility for loading widgets
      was never implemented.
      
      The lack of audio support when running the upstream kernel on recent
      Chromebooks has been reported in various forums, and can be traced back
      to this problem. Attempts to fix the problem, usually by providing v5
      configuration files, were only partially successful.
      
      Let's implement backward compatibility properly to solve the problem
      for good.
      
      Signed-off-by: default avatarGuenter Roeck <groeck@chromium.org>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      ac9391da
  2. Jun 01, 2018
  3. May 31, 2018
  4. May 30, 2018
  5. May 29, 2018
  6. May 26, 2018
  7. May 23, 2018
  8. May 22, 2018