Skip to content
Commit e78bfb07 authored by Stefano Brivio's avatar Stefano Brivio Committed by David S. Miller
Browse files

skbuff: Unconditionally copy pfmemalloc in __skb_clone()

Commit 8b700862

 ("net: Don't copy pfmemalloc flag in
__copy_skb_header()") introduced a different handling for the
pfmemalloc flag in copy and clone paths.

In __skb_clone(), now, the flag is set only if it was set in the
original skb, but not cleared if it wasn't. This is wrong and
might lead to socket buffers being flagged with pfmemalloc even
if the skb data wasn't allocated from pfmemalloc reserves. Copy
the flag instead of ORing it.

Reported-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Fixes: 8b700862

 ("net: Don't copy pfmemalloc flag in __copy_skb_header()")
Signed-off-by: default avatarStefano Brivio <sbrivio@redhat.com>
Tested-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8f19f12b
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment