Skip to content
Commit e2c631ba authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Thomas Gleixner
Browse files

clocksource: Revert "Remove kthread"

I turns out that the silly spawn kthread from worker was actually needed.

clocksource_watchdog_kthread() cannot be called directly from
clocksource_watchdog_work(), because clocksource_select() calls
timekeeping_notify() which uses stop_machine(). One cannot use
stop_machine() from a workqueue() due lock inversions wrt CPU hotplug.

Revert the patch but add a comment that explain why we jump through such
apparently silly hoops.

Fixes: 7197e77a

 ("clocksource: Remove kthread")
Reported-by: default avatarSiegfried Metz <frame@mailbox.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarNiklas Cassel <niklas.cassel@linaro.org>
Tested-by: default avatarKevin Shanahan <kevin@shanahan.id.au>
Tested-by: default avatar <viktor_jaegerskuepper@freenet.de>
Tested-by: default avatarSiegfried Metz <frame@mailbox.org>
Cc: rafael.j.wysocki@intel.com
Cc: len.brown@intel.com
Cc: diego.viola@gmail.com
Cc: rui.zhang@intel.com
Cc: bjorn.andersson@linaro.org
Link: https://lkml.kernel.org/r/20180905084158.GR24124@hirez.programming.kicks-ass.net
parent c43c5e9f
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment