Commit e07f1009 authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman
Browse files

firmware: google: memconsole: Drop __iomem on memremap memory 



memremap() doesn't return __iomem marked memory, so drop the marking
here. This makes static analysis tools like sparse happy again.

Cc: Wei-Ning Huang <wnhuang@chromium.org>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Samuel Holland <samuel@sholland.org>
Cc: Guenter Roeck <groeck@chromium.org>
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Reviewed-by: default avatarJulius Werner <jwerner@chromium.org>
Reviewed-by: default avatarSamuel Holland <samuel@sholland.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b0503584

drivers/firmware/google/memconsole-coreboot.c

+2 −2
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ struct cbmem_cons { 
#define CURSOR_MASK ((1 << 28) - 1)

#define OVERFLOW (1 << 31)



static struct cbmem_cons __iomem *cbmem_console;

static struct cbmem_cons *cbmem_console;

static u32 cbmem_console_size;



/*
@@ -75,7 +75,7 @@ static ssize_t memconsole_coreboot_read(char *buf, loff_t pos, size_t count) 


static int memconsole_probe(struct coreboot_device *dev)

{

	struct cbmem_cons __iomem *tmp_cbmc;

	struct cbmem_cons *tmp_cbmc;



	tmp_cbmc = memremap(dev->cbmem_ref.cbmem_addr,

			    sizeof(*tmp_cbmc), MEMREMAP_WB);