Skip to content
Commit cb2bf251 authored by Darren Hart's avatar Darren Hart
Browse files

platform/x86: thinkpad_acpi: Initialize local in_tablet_mode and type



linux-next reported in_tablet_mode and type may be used uninitialized
after:

b3180028 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function")

This turns out to be a false positive as the pr_info call cannot be
reached if tp_features.hotkey_tablet (global scope) is 0, and
in_tablet_mode and type are assigned in both places
tp_features.hotkey_tablet is assigned.

Regardless, to make it explicit and avoid further reports, initialize
in_tablet_mode to 0 and type to NULL.

Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
Acked-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Lyude <lyude@redhat.com>
parent 1d161d4c
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment