Skip to content
Commit b7b4839d authored by Dave Jones's avatar Dave Jones Committed by Ingo Molnar
Browse files

perf/x86: Fix leak in uncore_type_init failure paths



The error path of uncore_type_init() frees up any allocations
that were made along the way, but it relies upon type->pmus
being set, which only happens if the function succeeds. As
type->pmus remains null in this case, the call to
uncore_type_exit will do nothing.

Moving the assignment earlier will allow us to actually free
those allocations should something go awry.

Signed-off-by: default avatarDave Jones <davej@fedoraproject.org>
Acked-by: default avatarPeter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20140306172028.GA552@redhat.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent b8ad0f91
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment