Commit b4cdeb78 authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman
Browse files

firmware: google: memconsole: Drop global func pointer 



We can store this function pointer directly in the bin_attribute
structure's private field. Do this to save one global pointer.

Cc: Wei-Ning Huang <wnhuang@chromium.org>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Samuel Holland <samuel@sholland.org>
Cc: Guenter Roeck <groeck@chromium.org>
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Reviewed-by: default avatarJulius Werner <jwerner@chromium.org>
Reviewed-by: default avatarSamuel Holland <samuel@sholland.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e07f1009

drivers/firmware/google/memconsole.c

+5 −3
Original line number Diff line number Diff line
@@ -22,14 +22,16 @@ 


#include "memconsole.h"



static ssize_t (*memconsole_read_func)(char *, loff_t, size_t);



static ssize_t memconsole_read(struct file *filp, struct kobject *kobp,

			       struct bin_attribute *bin_attr, char *buf,

			       loff_t pos, size_t count)

{

	ssize_t (*memconsole_read_func)(char *, loff_t, size_t);



	memconsole_read_func = bin_attr->private;

	if (WARN_ON_ONCE(!memconsole_read_func))

		return -EIO;



	return memconsole_read_func(buf, pos, count);

}
@@ -40,7 +42,7 @@ static struct bin_attribute memconsole_bin_attr = { 


void memconsole_setup(ssize_t (*read_func)(char *, loff_t, size_t))

{

	memconsole_read_func = read_func;

	memconsole_bin_attr.private = read_func;

}

EXPORT_SYMBOL(memconsole_setup);