Skip to content
Commit 8ea7645c authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

libata: leave port thawed after reset failure

libata EH intentionally left a port frozen if it failed
ata_eh_reset().  The intention was avoiding continuous loop of resets
when the controller or attached device is flaky and reporting spurious
hotplug events.  Once port enters this state, it can be recovered with
manual rescan, which seemed reasonable.

However, outside of my convoluted test setup, there have been very few
reports justifying this choice while there have been more cases where
the automatic freezing of the port after hotplug attempt of a faulty
device caused confusion and led to unnecessary resets.

This patch changes the behavior so that the port is thawed after reset
failure.  This change doesn't necessarily solve but makes it easier
and more intuitive to work around hotplug related problems
(ie. re-pluggin or power cycling the device) as reported in the
followings.

  https://bugzilla.kernel.org/show_bug.cgi?id=34712
  http://thread.gmane.org/gmane.linux.kernel/1123265/focus=49548



Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Reported-by: default avatarReartes Guillermo <rtguille@gmail.com>
Reported-by: default avatarBruce Stenning <b.stenning@indigovision.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 5b933e63
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment