Commit 74328c7d authored by Eric Dumazet's avatar Eric Dumazet Committed by popcornmix
Browse files

When replacing del_timer() with del_timer_sync(), I introduced


a deadlock condition :

reqsk_queue_unlink() is called from inet_csk_reqsk_queue_drop()

inet_csk_reqsk_queue_drop() can be called from many contexts,
one being the timer handler itself (reqsk_timer_handler()).

In this case, del_timer_sync() loops forever.

Simple fix is to test if timer is pending.

Fixes: 2235f2ac ("inet: fix races with reqsk timers")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
parent 499958c6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment