Skip to content
Commit 7430768b authored by Masaki Ota's avatar Masaki Ota Committed by Greg Kroah-Hartman
Browse files

Input: ALPS - fix TrackStick detection on Thinkpad L570 and Latitude 7370

commit 567b9b54 upstream.

The primary interface for the touchpad device in Thinkpad L570 is SMBus,
so ALPS overlooked PS2 interface Firmware setting of TrackStick, and
shipped with TrackStick otp bit is disabled.

The address 0xD7 contains device number information, so we can identify
the device by checking this value, but to access it we need to enable
Command mode, and then re-enable the device. Devices shipped in Thinkpad
L570 report either 0x0C or 0x1D as device numbers, if we see them we assume
that the devices are DualPoints.

The same issue exists on Dell Latitude 7370.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196929


Fixes: 646580f793 ("Input: ALPS - fix multi-touch decoding on SS4 plus touchpads")
Signed-off-by: default avatarMasaki Ota <masaki.ota@jp.alps.com>
Tested-by: default avatarAaron Ma <aaron.ma@canonical.com>
Tested-by: default avatarJonathan Liu <net147@gmail.com>
Tested-by: default avatarJaak Ristioja <jaak@ristioja.ee>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c8a297b6
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment