Skip to content
Commit 71c6c837 authored by Xiaotian Feng's avatar Xiaotian Feng Committed by David S. Miller
Browse files

drivers/net: fix tasklet misuse issue

In commit 175c0dff

, drivers uses tasklet_kill to avoid put disabled tasklet
on the tasklet vec. But some of the drivers uses tasklet_init & tasklet_disable
in the driver init code, then tasklet_enable when it is opened. This makes
tasklet_enable on a killed tasklet and make ksoftirqd crazy then. Normally,
drivers should use tasklet_init/tasklet_kill on device open/remove, and use
tasklet_disable/tasklet_enable on device suspend/resume.

Reported-by: default avatarPeter Wu <lekensteyn@gmail.com>
Tested-by: default avatarPeter Wu <lekensteyn@gmail.com>
Signed-off-by: default avatarXiaotian Feng <dannyfeng@tencent.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b2942004
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment