Skip to content
Unverified Commit 28be5f15 authored by Linus Walleij's avatar Linus Walleij Committed by Mark Brown
Browse files

regulator: fixed: Default enable high on DT regulators

commit efdfeb07
("regulator: fixed: Convert to use GPIO descriptor only")
switched to use gpiod_get() to look up the regulator from the
gpiolib core whether that is device tree or boardfile.

This meant that we activate the code in
a603a2b8 ("gpio: of: Add special quirk to parse regulator flags")
which means the descriptors coming from the device tree already
have the right inversion and open drain semantics set up from
the gpiolib core.

As the fixed regulator was inspected again we got the
inverted inversion and things broke.

Fix it by ignoring the config in the device tree for now: the
later patches in the series will push all inversion handling
over to the gpiolib core and set it up properly in the
boardfiles for legacy devices, but I did not finish that
for this kernel cycle.

Fixes: commit efdfeb07

 ("regulator: fixed: Convert to use GPIO descriptor only")
Reported-by: default avatarLeonard Crestez <leonard.crestez@nxp.com>
Reported-by: default avatarFabio Estevam <festevam@gmail.com>
Reported-by: default avatarJohn Stultz <john.stultz@linaro.org>
Reported-by: default avatarAnders Roxell <anders.roxell@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Tested-by: default avatarJohn Stultz <john.stultz@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 54515214
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment