Skip to content
  1. Jul 19, 2010
    • Sebastian Ott's avatar
      [S390] cio: fix potential overflow in chpid descriptor · 878c4956
      Sebastian Ott authored
      
      
      The length filed in the chsc response block (if valid)
      has a value of n*(sizeof(chp_desc))+8 (for the response
      block header). When we memcopied from the response block
      to the actual descriptor we copied 8 bytes too much.
      The bug was not revealed since the descriptor is embedded
      in struct channel_path.
      Since we only write one descriptor at a time ignore the
      length value and use sizeof(*desc).
      
      Signed-off-by: default avatarSebastian Ott <sebott@linux.vnet.ibm.com>
      Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
      878c4956
    • Stefan Haberland's avatar
      [S390] add missing device put · 0abccf77
      Stefan Haberland authored
      
      
      The dasd_alias_show function does not return a device reference
      in case the device is an alias.
      
      Signed-off-by: default avatarStefan Haberland <stefan.haberland@de.ibm.com>
      Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
      0abccf77
    • Peter Oberparleiter's avatar
      [S390] dasd: use correct label location for diag fba disks · cffab6bc
      Peter Oberparleiter authored
      
      
      Partition boundary calculation fails for DASD FBA disks under the
      following conditions:
      - disk is formatted with CMS FORMAT with a blocksize of more than
        512 bytes
      - all of the disk is reserved to a single CMS file using CMS RESERVE
      - the disk is accessed using the DIAG mode of the DASD driver
      
      Under these circumstances, the partition detection code tries to
      read the CMS label block containing partition-relevant information
      from logical block offset 1, while it is in fact located at physical
      block offset 1.
      
      Fix this problem by using the correct CMS label block location
      depending on the device type as determined by the DASD SENSE ID
      information.
      
      Signed-off-by: default avatarPeter Oberparleiter <peter.oberparleiter@de.ibm.com>
      Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
      cffab6bc
    • Linus Torvalds's avatar
      Merge branch 'x86/kprobes' of git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland · a9f7f2e7
      Linus Torvalds authored
      * 'x86/kprobes' of git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland:
        x86: kprobes: fix swapped segment registers in kretprobe
      a9f7f2e7
    • Roland McGrath's avatar
      x86: kprobes: fix swapped segment registers in kretprobe · a1974798
      Roland McGrath authored
      In commit f007ea26
      
      , the order of the %es and %ds segment registers
      got accidentally swapped, so synthesized 'struct pt_regs' frames
      have the two values inverted.  It's almost sure that these values
      never matter, and that they also never differ.  But wrong is wrong.
      
      Signed-off-by: default avatarRoland McGrath <roland@redhat.com>
      a1974798
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6 · 2044f228
      Linus Torvalds authored
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6:
        PCI: fall back to original BIOS BAR addresses
      2044f228
    • Linus Torvalds's avatar
      Merge branch 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jlbec/ocfs2 · bea9a6d2
      Linus Torvalds authored
      * 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jlbec/ocfs2:
        ocfs2: Silence gcc warning in ocfs2_write_zero_page().
        jbd2/ocfs2: Fix block checksumming when a buffer is used in several transactions
        ocfs2/dlm: Remove BUG_ON from migration in the rare case of a down node
        ocfs2: Don't duplicate pages past i_size during CoW.
        ocfs2: tighten up strlen() checking
        ocfs2: Make xattr reflink work with new local alloc reservation.
        ocfs2: make xattr extension work with new local alloc reservation.
        ocfs2: Remove the redundant cpu_to_le64.
        ocfs2/dlm: don't access beyond bitmap size
        ocfs2: No need to zero pages past i_size.
        ocfs2: Zero the tail cluster when extending past i_size.
        ocfs2: When zero extending, do it by page.
        ocfs2: Limit default local alloc size within bitmap range.
        ocfs2: Move orphan scan work to ocfs2_wq.
        fs/ocfs2/dlm: Add missing spin_unlock
      bea9a6d2
    • Linus Torvalds's avatar
      drm/i915: add 'reclaimable' to i915 self-reclaimable page allocations · cd9f040d
      Linus Torvalds authored
      The hibernate issues that got fixed in commit 985b823b ("drm/i915:
      fix hibernation since i915 self-reclaim fixes") turn out to have been
      incomplete.  Vefa Bicakci tested lots of hibernate cycles, and without
      the __GFP_RECLAIMABLE flag the system eventually fails to resume.
      
      With the flag added, Vefa can apparently hibernate forever (or until he
      gets bored running his automated scripts, whichever comes first).
      
      The reclaimable flag was there originally, and was one of the flags that
      were dropped (unintentionally) by commit 4bdadb97 ("drm/i915:
      Selectively enable self-reclaim") that introduced all these problems,
      but I didn't want to just blindly add back all the flags in commit
      985b823b
      
      , and it looked like __GFP_RECLAIM wasn't necessary.  It
      clearly was.
      
      I still suspect that there is some subtle reason we're missing that
      causes the problems, but __GFP_RECLAIMABLE is certainly not wrong to use
      in this context, and is what the code historically used.  And we have no
      idea what the causes the corruption without it.
      
      Reported-and-tested-by: default avatarM. Vefa Bicakci <bicave@superonline.com>
      Cc: Dave Airlie <airlied@gmail.com>
      Cc: Chris Wilson <chris@chris-wilson.co.uk>
      Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
      Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>
      Cc: stable@kernel.org
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      cd9f040d
  2. Jul 17, 2010
    • Joel Becker's avatar
      ocfs2: Silence gcc warning in ocfs2_write_zero_page(). · 5453258d
      Joel Becker authored
      
      
      ocfs2_write_zero_page() has a loop that won't ever be skipped, but gcc
      doesn't know that.  Set ret=0 just to make gcc happy.
      
      Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
      5453258d
    • Bjorn Helgaas's avatar
      PCI: fall back to original BIOS BAR addresses · 58c84eda
      Bjorn Helgaas authored
      
      
      If we fail to assign resources to a PCI BAR, this patch makes us try the
      original address from BIOS rather than leaving it disabled.
      
      Linux tries to make sure all PCI device BARs are inside the upstream
      PCI host bridge or P2P bridge apertures, reassigning BARs if necessary.
      Windows does similar reassignment.
      
      Before this patch, if we could not move a BAR into an aperture, we left
      the resource unassigned, i.e., at address zero.  Windows leaves such BARs
      at the original BIOS addresses, and this patch makes Linux do the same.
      
      This is a bit ugly because we disable the resource long before we try to
      reassign it, so we have to keep track of the BIOS BAR address somewhere.
      For lack of a better place, I put it in the struct pci_dev.
      
      I think it would be cleaner to attempt the assignment immediately when the
      claim fails, so we could easily remember the original address.  But we
      currently claim motherboard resources in the middle, after attempting to
      claim PCI resources and before assigning new PCI resources, and changing
      that is a fairly big job.
      
      Addresses https://bugzilla.kernel.org/show_bug.cgi?id=16263
      
      Reported-by: default avatarAndrew <nitr0@seti.kr.ua>
      Tested-by: default avatarAndrew <nitr0@seti.kr.ua>
      Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
      58c84eda
    • Linus Torvalds's avatar
      Merge branch 'perf-fixes-for-linus' of... · f469461d
      Linus Torvalds authored
      Merge branch 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
      
      * 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
        tracing: Add alignment to syscall metadata declarations
        perf: Sync callchains with period based hits
        perf: Resurrect flat callchains
        perf: Version String fix, for fallback if not from git
        perf: Version String fix, using kernel version
      f469461d
  3. Jul 16, 2010
  4. Jul 15, 2010
    • Bob Peterson's avatar
      GFS2: rename causes kernel Oops · 728a756b
      Bob Peterson authored
      
      
      This patch fixes a kernel Oops in the GFS2 rename code.
      
      The problem was in the way the gfs2 directory code was trying
      to re-use sentinel directory entries.
      
      In the failing case, gfs2's rename function was renaming a
      file to another name that had the same non-trivial length.
      The file being renamed happened to be the first directory
      entry on the leaf block.
      
      First, the rename code (gfs2_rename in ops_inode.c) found the
      original directory entry and decided it could do its job by
      simply replacing the directory entry with another.  Therefore
      it determined correctly that no block allocations were needed.
      
      Next, the rename code deleted the old directory entry prior to
      replacing it with the new name.  Therefore, the soon-to-be
      replaced directory entry was temporarily made into a directory
      entry "sentinel" or a place holder at the start of a leaf block.
      
      Lastly, it went to re-add the replacement directory entry in
      that leaf block.  However, when gfs2_dirent_find_space was
      looking for space in the leaf block, it used the wrong value
      for the sentinel.  That threw off its calculations so later
      it decides it can't really re-use the sentinel and therefore
      must allocate a new leaf block.  But because it previously decided
      to re-use the directory entry, it didn't waste the time to
      grab a new block allocation for the inode.  Therefore, the
      inode's i_alloc pointer was still NULL and it crashes trying to
      reference it.
      
      In the case of sentinel directory entries, the entire dirent is
      reused, not just the "free space" portion of it, and therefore
      the function gfs2_dirent_find_space should use the value 0
      rather than GFS2_DIRENT_SIZE(0) for the actual dirent size.
      
      Fixing this calculation enables the reproducer programs to work
      properly.
      
      Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      728a756b
    • Abhijith Das's avatar
      GFS2: BUG in gfs2_adjust_quota · 8b421601
      Abhijith Das authored
      
      
      HighMem pages on i686 do not get mapped to the buffer_heads and this was
      causing a NULL pointer dereference when we were trying to memset page buffers
      to zero.
      We now use zero_user() that kmaps the page and directly manipulates page data.
      This patch also fixes a boundary condition that was incorrect.
      
      Signed-off-by: default avatarAbhi Das <adas@redhat.com>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      8b421601
    • Bob Peterson's avatar
      GFS2: Fix kernel NULL pointer dereference by dlm_astd · b1becbde
      Bob Peterson authored
      
      
      This patch fixes a problem in an error path when looking
      up dinodes.  There are two sister-functions, gfs2_inode_lookup
      and gfs2_process_unlinked_inode.  Both functions acquire and
      hold the i_iopen glock for the dinode being looked up. The last
      thing they try to do is hold the i_gl glock for the dinode.
      If that glock fails for some reason, the error path was
      incorrectly calling gfs2_glock_put for the i_iopen glock twice.
      This resulted in the glock being prematurely freed.  The
      "minimum hold time" usually kept the glock in memory, but the
      lock interface to dlm (aka lock_dlm) freed its memory for the
      glock.  In some circumstances, it would cause dlm's dlm_astd daemon
      to try to call the bast function for the freed lock_dlm memory,
      which resulted in a NULL pointer dereference.
      
      Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      b1becbde
    • Bob Peterson's avatar
      GFS2: recovery stuck on transaction lock · b7dc2df5
      Bob Peterson authored
      
      
      This patch fixes bugzilla bug #590878: GFS2: recovery stuck on
      transaction lock.  We set the frozen flag on the glock when we receive
      a completion that cannot be delivered due to blocked locks. At that
      point we check to see whether the first waiting holder has the noexp
      flag set. If the noexp lock is queued later, then we need to unfreeze
      the glock at that point in time, namely, in the glock work function.
      
      This patch was originally written by Steve Whitehouse, but since
      he's on holiday, I'm submitting it.  It's been well tested with a
      complex recovery test called revolver.
      
      Signed-off-by: default avatarSteve Whitehouse <swhiteho@redhat.com>
      Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
      b7dc2df5
    • Bob Peterson's avatar
      GFS2: O_TRUNC not working on stuffed files across cluster · a8bf2bc2
      Bob Peterson authored
      
      
      This patch replaces a statement that got dropped out by accident.
      Without the patch, truncates on stuffed (very small) files cause
      those files to have an unpredictable size.
      
      Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      a8bf2bc2
    • Linus Torvalds's avatar
      Merge master.kernel.org:/home/rmk/linux-2.6-arm · 2f7989ef
      Linus Torvalds authored
      * master.kernel.org:/home/rmk/linux-2.6-arm:
        ARM: 6226/1: fix kprobe bug in ldr instruction emulation
        ARM: Update mach-types
        ARM: lockdep: fix unannotated irqs-on
        ARM: 6184/2: ux500: use neutral PRCMU base
        ARM: 6212/1: atomic ops: add memory constraints to inline asm
        ARM: 6211/1: atomic ops: fix register constraints for atomic64_add_unless
        ARM: 6210/1: Do not rely on reset defaults of L2X0_AUX_CTRL
      2f7989ef
    • Linus Torvalds's avatar
      Merge branch 'lmb-to-memblock' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc · 6f7dd68b
      Linus Torvalds authored
      * 'lmb-to-memblock' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc:
        lmb: rename to memblock
      6f7dd68b
    • Linus Torvalds's avatar
      Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc · ea4c1a7e
      Linus Torvalds authored
      * 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc:
        powerpc/fsl-booke: Fix address issue when using relocatable kernels
        powerpc/cpm1: Mark micropatch code/data static and __init
        powerpc/cpm1: Fix build with various CONFIG_*_UCODE_PATCH combinations
        powerpc/cpm: Reintroduce global spi_pram struct (fixes build issue)
      ea4c1a7e
    • Nicolas Pitre's avatar
      ARM: 6226/1: fix kprobe bug in ldr instruction emulation · 0ebe25f9
      Nicolas Pitre authored
      
      
      From: Bin Yang <bin.yang@marvell.com>
      
      Cc: stable@kernel.org
      Signed-off-by: default avatarBin Yang <bin.yang@marvell.com>
      Signed-off-by: default avatarNicolas Pitre <nicolas.pitre@linaro.org>
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      0ebe25f9
    • Takashi Iwai's avatar
      Input: synaptics - fix wrong dimensions check · bbddd199
      Takashi Iwai authored
      The commit 83ba9ea8
      
       ommitted the return
      line for the old synaptics model accidentally.  This resulted in a wrong
      check, namely, the dimensions are checked for the old devices that don't
      support the query properly.
      
      This patch adds the return line back.
      
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
      bbddd199
  5. Jul 14, 2010
  6. Jul 13, 2010
    • Linus Torvalds's avatar
      Linux 2.6.35-rc5 · 1c5474a6
      Linus Torvalds authored
      v2.6.35-rc5
      1c5474a6
    • Linus Torvalds's avatar
      Merge branch 'arm/defconfig/reduced-v2.6.35-rc1' of git://git.pengutronix.de/git/ukl/linux-2.6 · c2330e28
      Linus Torvalds authored
      
      
      * 'arm/defconfig/reduced-v2.6.35-rc1' of git://git.pengutronix.de/git/ukl/linux-2.6:
        ARM: reduce defconfigs
      
      This is a big change, but results in no loss of information, despite us
      losing almost 200k lines:
      
       177 files changed, 652 insertions(+), 194157 deletions(-)
      
      and Grant Likely thinks powerpc can also use the same reduction
      technique.
      
      The python script that did the reduction looks like this:
      
          #! /usr/bin/env python
          # vim: set fileencoding=utf-8 :
          # Copyright (C) 2010 by Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
      
          import re
          import subprocess
          import os
          import sys
      
          # This prevents including a timestamp in the .config which makes comparing a
          # bit easier.
          os.environ['KCONFIG_NOTIMESTAMP'] = 'Yes, please'
      
          # XXX: get these using getopt
          kernel_tree = '' # os.path.join(os.environ['HOME'], 'gsrc', 'linux-2.6')
          arch = 'arm'
          target = sys.argv[1]
          defconfig_src = os.path.join(kernel_tree, 'arch/%s/configs/%s' % (arch, target))
      
          subprocess.check_call(['make', '-s', 'ARCH=%s' % arch, target])
          origconfig = list(open('.config'))
          config = list(origconfig)
          config_size = os.stat('.config').st_size
      
          i = 0
      
          while i < len(config):
              print 'test for %r' % config[i]
              defconfig = open(defconfig_src, 'w')
              defconfig.writelines(config[:i])
              defconfig.writelines(config[i + 1:])
              defconfig.close()
              subprocess.check_call(['make', '-s', 'ARCH=%s' % arch, target])
              if os.stat('.config').st_size == config_size and list(open('.config')) == origconfig:
                  del config[i]
              else:
                  i += 1
      
          defconfig = open(defconfig_src, 'w')
          defconfig.writelines(config)
          defconfig.close()
      
      which is pretty self-explanatory.
      
      Acked-by: default avatarNicolas Pitre <nico@fluxnic.net>
      Acked-by: default avatarRussell King <linux@arm.linux.org.uk>
      Acked-by: default avatarGrant Likely <grant.likely@secretlab.ca>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      c2330e28
    • Linus Torvalds's avatar
      Merge branch 'fix/hda' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6 · 7e48c028
      Linus Torvalds authored
      * 'fix/hda' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
        ALSA: hda - Restore cleared pin controls on resume
      7e48c028
    • Linus Torvalds's avatar
      Merge branch 'v4l_for_2.6.35' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6 · 9f719637
      Linus Torvalds authored
      * 'v4l_for_2.6.35' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6:
        V4L/DVB: uvc: Fix multiple symbols definitions with UVC gadget and host drivers
        V4L/DVB: v4l: mem2mem_testdev: fix g_fmt NULL pointer dereference
        V4L/DVB: uvcvideo: Power line frequency control doesn't support GET_MIN/MAX/RES
        V4L/DVB: ivtv: Add delay to ensure the decoder always restarts with a blank screen
        V4L/DVB: Documentation: Add the Philips FQ1236 MK5 to video4linux/CARDLIST.tuner
        V4L/DVB: tveeprom: Add an entry for tuner code 168: a TCL M30WTP-4N-E tuner
        V4L/DVB: tuner: Add a definition for the Philips FQ1236 MK5 NTSC tuner
        V4L/DVB: OMAP_VOUT: fix: Module params were not working through bootargs
        V4L/DVB: OMAP_VOUT: fix: Replaced dma-sg with dma-contig
        V4L/DVB: OMAP_VOUT:Build FIX: Rebased against latest DSS2 changes
      9f719637
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid · 293ffa8f
      Linus Torvalds authored
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid:
        HID: Send Report ID when numbered reports are sent over the control endpoint.
        HID: Enable HID_QUIRK_MULTI_INPUT for Retro Adaptor
        HID: add support for CH Eclipse yoke
        HID: eliminate a double lock in debug code
        HID: ntrig: add support for new firwmare versions
        HID: check for HID_QUIRK_IGNORE during probing
        HID: roccat: fix modules interdependencies
      293ffa8f
    • Joe Perches's avatar
      MAINTAINERS: fix EDAC-I7CORE file patterns · 70aff0ce
      Joe Perches authored
      
      
      File patterns are one per line.
      Fixed include file location.
      
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      70aff0ce
    • Dan Carpenter's avatar
      ocfs2: tighten up strlen() checking · e372357b
      Dan Carpenter authored
      
      
      This function is only called from one place and it's like this:
      	dlm_register_domain(conn->cc_name, dlm_key, &fs_version);
      
      The "conn->cc_name" is 64 characters long.  If strlen(conn->cc_name)
      were equal to O2NM_MAX_NAME_LEN (64) that would be a bug because
      strlen() doesn't count the NULL character.
      
      In fact, if you look how O2NM_MAX_NAME_LEN is used, it mostly describes
      64 character buffers.  The only exception is nd_name from struct
      o2nm_node.
      
      Anyway I looked into it and in this case the domain string comes from
      osb->uuid_str in ocfs2_setup_osb_uuid().  That's 32 characters and NULL
      which easily fits into O2NM_MAX_NAME_LEN.  This patch doesn't change how
      the code works, but I think it makes the code a little cleaner.
      
      Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
      Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
      e372357b
    • Tao Ma's avatar
      ocfs2: Make xattr reflink work with new local alloc reservation. · 121a39bb
      Tao Ma authored
      
      
      The new reservation code in local alloc has add the limitation
      that the caller should handle the case that the local alloc
      doesn't give use enough contiguous clusters. It make the old
      xattr reflink code broken.
      
      So this patch udpate the xattr reflink code so that it can
      handle the case that local alloc give us one cluster at a time.
      
      Signed-off-by: default avatarTao Ma <tao.ma@oracle.com>
      Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
      121a39bb
    • Tao Ma's avatar
      ocfs2: make xattr extension work with new local alloc reservation. · a78f9f46
      Tao Ma authored
      
      
      The old ocfs2_xattr_extent_allocation is too optimistic about
      the clusters we can get. So actually if the file system is
      too fragmented, ocfs2_add_clusters_in_btree will return us
      with EGAIN and we need to allocate clusters once again.
      
      So this patch change it to a while loop so that we can allocate
      clusters until we reach clusters_to_add.
      
      Signed-off-by: default avatarTao Ma <tao.ma@oracle.com>
      Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
      Cc: stable@kernel.org
      a78f9f46