Skip to content
  1. May 01, 2013
    • Mugunthan V N's avatar
      drivers: net: cpsw: fix kernel warn on cpsw irq enable · 7dcf313a
      Mugunthan V N authored
      
      
      With the commit a11fbba9 (net/cpsw: fix irq_disable() with threaded interrupts)
      from Sebastian Siewior, a kernel warning is generated as below. This warning
      is generated as the irq_enabled is not initialized for the primary interface
      and in probe it is initialized for the second interface. This patch moves
      irq_enabled initialization from second interface to primary interface.
      
      [    3.049173] net eth0: phy found : id is : 0x4dd074
      [    3.054552] net eth0: phy found : id is : 0x4dd074
      [    3.070421] ------------[ cut here ]------------
      [    3.075308] WARNING: at kernel/irq/manage.c:437 enable_irq+0x3c/0x74()
      [    3.082173] Unbalanced enable for IRQ 56
      [    3.086299] Modules linked in:
      [    3.089557] [<c001abcc>] (unwind_backtrace+0x0/0xf0) from [<c004294c>] (warn_slowpath_common+0x4c/0x68)
      [    3.099450] [<c004294c>] (warn_slowpath_common+0x4c/0x68) from [<c00429fc>] (warn_slowpath_fmt+0x30/0x40)
      [    3.109521] [<c00429fc>] (warn_slowpath_fmt+0x30/0x40) from [<c00a29fc>] (enable_irq+0x3c/0x74)
      [    3.118681] [<c00a29fc>] (enable_irq+0x3c/0x74) from [<c03a7818>] (cpsw_ndo_open+0x61c/0x684)
      [    3.127669] [<c03a7818>] (cpsw_ndo_open+0x61c/0x684) from [<c0445c08>] (__dev_open+0x9c/0xf8)
      [    3.136646] [<c0445c08>] (__dev_open+0x9c/0xf8) from [<c0445e34>] (__dev_change_flags+0x78/0x13c)
      [    3.145988] [<c0445e34>] (__dev_change_flags+0x78/0x13c) from [<c0445f64>] (dev_change_flags+0x10/0x48)
      [    3.155884] [<c0445f64>] (dev_change_flags+0x10/0x48) from [<c0736d88>] (ip_auto_config+0x198/0x111c)
      [    3.165592] [<c0736d88>] (ip_auto_config+0x198/0x111c) from [<c00086a4>] (do_one_initcall+0x34/0x180)
      [    3.175309] [<c00086a4>] (do_one_initcall+0x34/0x180) from [<c07078f8>] (kernel_init_freeable+0xfc/0x1c8)
      [    3.185393] [<c07078f8>] (kernel_init_freeable+0xfc/0x1c8) from [<c04f36ec>] (kernel_init+0x8/0xe4)
      [    3.194929] [<c04f36ec>] (kernel_init+0x8/0xe4) from [<c00133d0>] (ret_from_fork+0x14/0x24)
      [    3.203712] ---[ end trace d6f979da080bc391 ]---
      
      Cc: Sebastian Siewior <bigeasy@linutronix.de>
      Signed-off-by: default avatarMugunthan V N <mugunthanvnm@ti.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7dcf313a
    • Sergei Shtylyov's avatar
      sh_eth: use random MAC address if no valid one supplied · ff6e7228
      Sergei Shtylyov authored
      
      
      On Renesas R-Car based development boards, although a MAC address is printed on
      all the Ethernet port labels, U-Boot  doesn't write a valid MAC address  to the
      Ether MAHR/MALR registers (there's no storage provided for the Ether MAC address
      either), so we have to resort to using a random MAC address...
      
      Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Acked-by: default avatarSimon Horman <horms+renesas@verge.net.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ff6e7228
    • Matthew Whitehead's avatar
      3c509.c: call SET_NETDEV_DEV for all device types (ISA/ISAPnP/EISA) · 3b54912f
      Matthew Whitehead authored
      
      
      The venerable 3c509 driver only sets its device parent in one case, the ISAPnP one.
      It does this with the SET_NETDEV_DEV function. It should register with the device
      hierarchy in two additional cases: standard (non-PnP) ISA and EISA.
      
      - Currently they appear here:
      /sys/devices/virtual/net/eth0 (standard ISA)
      /sys/devices/virtual/net/eth1 (EISA)
      
      - Rather, they should instead be here:
      /sys/devices/isa/3c509.0/net/eth0 (standard ISA)
      /sys/devices/pci0000:00/0000:00:07.0/00:04/net/eth1 (EISA)
      
      Tested on ISA and EISA boards.
      
      Signed-off-by: default avatarMatthew Whitehead <tedheadster@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3b54912f
    • Flavio Leitner's avatar
      tg3: fix to append hardware time stamping flags · 32e19272
      Flavio Leitner authored
      
      
      The commit f233a976 (tg3: shows
      HW time stamping support only if ptp_capable is present) didn't
      append hardware flags correctly. This patch fixes it.
      
      Signed-off-by: default avatarFlavio Leitner <fbl@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      32e19272
  2. Apr 30, 2013