Skip to content
  1. Feb 07, 2019
  2. Feb 06, 2019
    • David S. Miller's avatar
      Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue · bfbae2ea
      David S. Miller authored
      
      
      Jeff Kirsher says:
      
      ====================
      Intel Wired LAN Driver Updates 2019-02-05
      
      This series contains updates to igc, e1000e, ixgbe, fm10k and driver
      documentation.
      
      Kai-Heng Feng fixes an e1000e issue where the Wake-On-LAN settings where
      being set incorrectly during a system suspend.
      
      Sasha addresses community feedback on the igc driver and provides a
      number of code cleanups to remove either unreachable or unused code.  In
      addition, added basic ethtool support for the igc driver.
      
      Mike Rapoport fixes the formatting of the kernel driver documentation so
      that the title is properly formatted and does not get lumped with the
      document sections in the HTML kernel documents generated.
      
      Jiri Kosina updates a hard coded RAR entries value with the existing
      define IXGBE_82599_RAR_ENTRIES.
      
      Jake fixes up whitespace in the fm10k driver.
      
      Konstantin Khlebnikov fixes an issue where in some cases, the e1000e
      driver will continually reset during a system boot because the watchdog
      task sees items in the transmit buffer but the carrier is off (trying to
      establish link) causing the device reset to flush the buffer.  To
      resolve, just move this check/flush into the watchdog section for when
      the carrier is off.
      
      Todd bumps the igb driver version to reflect the recent driver changes.
      ====================
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bfbae2ea
    • Sasha Neftin's avatar
      igc: Add ethtool support · 8c5ad0da
      Sasha Neftin authored
      
      
      This patch adds basic ethtool support to the device to allow
      for configuration.
      
      Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      8c5ad0da
    • Todd Fujinaka's avatar
      igb: Bump version number · a865d22d
      Todd Fujinaka authored
      
      
      With recent changes, need to bump the driver version to reflect the
      changes.
      
      Signed-off-by: default avatarTodd Fujinaka <todd.fujinaka@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      a865d22d
    • Sasha Neftin's avatar
      igc: Remove the 'igc_get_phy_id_base' method · 200a1a1a
      Sasha Neftin authored
      
      
      Remove the redundant 'igc_get_phy_id_base' method and use
      the 'igc_get_phy_id' method directly instead.
      
      Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      200a1a1a
    • Sasha Neftin's avatar
      igc: Remove the 'igc_read_mac_addr_base' method · 109f5996
      Sasha Neftin authored
      
      
      Remove the redundant 'igc_read_mac_addr_base' method and use
      the 'igc_read_mac_addr' method directly instead.
      
      Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      109f5996
    • Konstantin Khlebnikov's avatar
      e1000e: fix cyclic resets at link up with active tx · 0f9e980b
      Konstantin Khlebnikov authored
      
      
      I'm seeing series of e1000e resets (sometimes endless) at system boot
      if something generates tx traffic at this time. In my case this is
      netconsole who sends message "e1000e 0000:02:00.0: Some CPU C-states
      have been disabled in order to enable jumbo frames" from e1000e itself.
      As result e1000_watchdog_task sees used tx buffer while carrier is off
      and start this reset cycle again.
      
      [   17.794359] e1000e: eth1 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None
      [   17.794714] IPv6: ADDRCONF(NETDEV_CHANGE): eth1: link becomes ready
      [   22.936455] e1000e 0000:02:00.0 eth1: changing MTU from 1500 to 9000
      [   23.033336] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   26.102364] e1000e: eth1 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None
      [   27.174495] 8021q: 802.1Q VLAN Support v1.8
      [   27.174513] 8021q: adding VLAN 0 to HW filter on device eth1
      [   30.671724] cgroup: cgroup: disabling cgroup2 socket matching due to net_prio or net_cls activation
      [   30.898564] netpoll: netconsole: local port 6666
      [   30.898566] netpoll: netconsole: local IPv6 address 2a02:6b8:0:80b:beae:c5ff:fe28:23f8
      [   30.898567] netpoll: netconsole: interface 'eth1'
      [   30.898568] netpoll: netconsole: remote port 6666
      [   30.898568] netpoll: netconsole: remote IPv6 address 2a02:6b8:b000:605c:e61d:2dff:fe03:3790
      [   30.898569] netpoll: netconsole: remote ethernet address b0:a8:6e:f4:ff:c0
      [   30.917747] console [netcon0] enabled
      [   30.917749] netconsole: network logging started
      [   31.453353] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   34.185730] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   34.321840] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   34.465822] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   34.597423] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   34.745417] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   34.877356] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   35.005441] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   35.157376] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   35.289362] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   35.417441] e1000e 0000:02:00.0: Some CPU C-states have been disabled in order to enable jumbo frames
      [   37.790342] e1000e: eth1 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None
      
      This patch flushes tx buffers only once when carrier is off
      rather than at each watchdog iteration.
      
      Signed-off-by: default avatarKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      0f9e980b
    • Sasha Neftin's avatar
      igc: Remove unneeded code · 439c71f7
      Sasha Neftin authored
      
      
      Remove the 'igc_get_link_up_info_base method' from igc_base.c file.
      Use the 'igc_get_speed_and_duplex_copper' method directly and reduce
      the code redundancy.
      
      Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      439c71f7
    • Sasha Neftin's avatar
      igc: Remove unused code · 55fdbeaa
      Sasha Neftin authored
      
      
      Remove unused igc_adv_data_desc definition from igc_base.h file.
      Descriptors definition will be added per demand.
      
      Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      55fdbeaa
    • Jeff Kirsher's avatar
      e1000e: fix a missing check for return value · 979eff22
      Jeff Kirsher authored
      
      
      The change is based on the issue found by Kangjie Lu <kjlu@umn.edu> where
      we not checking the return value of a register read/write which could result
      in a NULL pointer dereference if the read/write fails.
      
      Since we are only trying to disable the far-end loopback, if the read
      and write of register fails, we do not want to bail out of the function.
      We just want to log that it failed to disable and continue on.
      
      CC: Sasha Neftin <sasha.neftin@intel.com>
      CC: Kangjie Lu <kjlu@umn.edu>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      979eff22