Skip to content
Commit e8a6123e authored by Lukas Wunner's avatar Lukas Wunner Committed by Thomas Gleixner
Browse files

x86/platform/intel-mid: Retrofit pci_platform_pm_ops ->get_state hook



Commit cc7cc02b ("PCI: Query platform firmware for device power
state") augmented struct pci_platform_pm_ops with a ->get_state hook and
implemented it for acpi_pci_platform_pm, the only pci_platform_pm_ops
existing till v4.7.

However v4.8 introduced another pci_platform_pm_ops for Intel Mobile
Internet Devices with commit 5823d089 ("x86/platform/intel-mid: Add
Power Management Unit driver").  It is missing the ->get_state hook,
which is fatal since pci_set_platform_pm() enforces its presence.  Andy
Shevchenko reports that without the present commit, such a device
"crashes without even a character printed out on serial console and
reboots (since watchdog)".

Retrofit mid_pci_platform_pm with the missing callback to fix the
breakage.

Acked-and-tested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fixes: cc7cc02b ("PCI: Query platform firmware for device power state")
Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: http://lkml.kernel.org/r/7c1567d4c49303a4aada94ba16275cbf56b8976b.1477221514.git.lukas@wunner.de


Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent bc33b0ca
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment