Skip to content
Commit e7820e39 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: Revert "net: avoid one atomic operation in skb_clone()"



Not sure what I was thinking, but doing anything after
releasing a refcount is suicidal or/and embarrassing.

By the time we set skb->fclone to SKB_FCLONE_FREE, another cpu
could have released last reference and freed whole skb.

We potentially corrupt memory or trap if CONFIG_DEBUG_PAGEALLOC is set.

Reported-by: default avatarChris Mason <clm@fb.com>
Fixes: ce1a4ea3

 ("net: avoid one atomic operation in skb_clone()")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 892d6eb1
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment