Skip to content
Commit c62ec461 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

PM / core: Fix direct_complete handling for devices with no callbacks

Commit 08810a41 (PM / core: Add NEVER_SKIP and SMART_PREPARE
driver flags) inadvertently prevented the power.direct_complete flag
from being set for devices without PM callbacks and with disabled
runtime PM which also prevents power.direct_complete from being set
for their parents.  That led to problems including a resume crash on
HP ZBook 14u.

Restore the previous behavior by causing power.direct_complete to be
set for those devices again, but do that in a more direct way to
avoid overlooking that case in the future.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=199693
Fixes: 08810a41

 (PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags)
Reported-by: default avatarThomas Martitz <kugel@rockbox.org>
Tested-by: default avatarThomas Martitz <kugel@rockbox.org>
Cc: 4.15+ <stable@vger.kernel.org> # 4.15+
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Reviewed-by: default avatarJohan Hovold <johan@kernel.org>
parent 771c577c
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment