Skip to content
Commit c0220d68 authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: avoid memleak after phy config transmit failure



Use only statically allocated data for PHY config packet transmission.
With the previous incarnation, some data wouldn't be freed if the packet
transmit callback was never called.

A theoretical drawback now is that, in PCs with more than one card,
card A may complete() for a waiter on card B.  But this is highly
unlikely and its impact not serious.  Bus manager B may reset bus B
before the PHY config went out, but the next phy config on B should be
fine.  However, with a timeout of 100ms, this situation is close to
impossible.

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 95984f62
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment