Skip to content
Commit 5b55d708 authored by Suleiman Souhlal's avatar Suleiman Souhlal Committed by Linus Torvalds
Browse files

vfs: Revert spurious fix to spinning prevention in prune_icache_sb

Revert commit 62a3ddef

 ("vfs: fix spinning prevention in prune_icache_sb").

This commit doesn't look right: since we are looking at the tail of the
list (sb->s_inode_lru.prev) if we want to skip an inode, we should put
it back at the head of the list instead of the tail, otherwise we will
keep spinning on it.

Discovered when investigating why prune_icache_sb came top in perf
reports of a swapping load.

Signed-off-by: default avatarSuleiman Souhlal <suleiman@google.com>
Signed-off-by: default avatarHugh Dickins <hughd@google.com>
Cc: stable@vger.kernel.org # v3.2+
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a49b7e82
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment