Skip to content
Commit 3c9fa24c authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

kvm: x86: use correct privilege level for sgdt/sidt/fxsave/fxrstor access

The functions that were used in the emulation of fxrstor, fxsave, sgdt and
sidt were originally meant for task switching, and as such they did not
check privilege levels.  This is very bad when the same functions are used
in the emulation of unprivileged instructions.  This is CVE-2018-10853.

The obvious fix is to add a new argument to ops->read_std and ops->write_std,
which decides whether the access is a "system" access or should use the
processor's CPL.

Fixes: 129a72a0

 ("KVM: x86: Introduce segmented_write_std", 2017-01-12)
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent ce14e868
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment