Skip to content
Commit 2c1cf00e authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

relay: check return of create_buf_file() properly



If create_buf_file() returns an error, don't try to reference it later
as a valid dentry pointer.

This problem was exposed when debugfs started to return errors instead
of just NULL for some calls when they do not succeed properly.

Also, the check for WARN_ON(dentry) was just wrong :)

Reported-by: default avatarKees Cook <keescook@chromium.org>
Reported-and-tested-by: default avatar <syzbot+16c3a70e1e9b29346c43@syzkaller.appspotmail.com>
Reported-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>
Fixes: ff9fb72b ("debugfs: return error values, not NULL")
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 37ea7b63
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment