Commit e37f2024 authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

input: fix send-key monitor command release event ordering 



commit 2e377f17 changed the ordering
of the release events as side effect.  Some guests are not happy with
that and don't recognise ctrl-alt-del any more.  This patch restores
the old last-pressed first-released behavior.

Cc: Amos Kong <akong@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 29429c72

ui/input-legacy.c

+9 −2
Original line number Diff line number Diff line
@@ -85,6 +85,8 @@ void qmp_send_key(KeyValueList *keys, bool has_hold_time, int64_t hold_time, 
                  Error **errp)

{

    KeyValueList *p;

    KeyValue **up = NULL;

    int count = 0;



    if (!has_hold_time) {

        hold_time = 0; /* use default */
@@ -93,11 +95,16 @@ void qmp_send_key(KeyValueList *keys, bool has_hold_time, int64_t hold_time, 
    for (p = keys; p != NULL; p = p->next) {

        qemu_input_event_send_key(NULL, copy_key_value(p->value), true);

        qemu_input_event_send_key_delay(hold_time);

        up = g_realloc(up, sizeof(*up) * (count+1));

        up[count] = copy_key_value(p->value);

        count++;

    }

    for (p = keys; p != NULL; p = p->next) {

        qemu_input_event_send_key(NULL, copy_key_value(p->value), false);

    while (count) {

        count--;

        qemu_input_event_send_key(NULL, up[count], false);

        qemu_input_event_send_key_delay(hold_time);

    }

    g_free(up);

}



static void legacy_kbd_event(DeviceState *dev, QemuConsole *src,